To: Phil Holmes m...@philholmes.net
Cc: m...@apollinemike.com; k-ohara5...@oco.net; d...@gnu.org;
lilypond-devel@gnu.org
Sent: Friday, April 27, 2012 5:58 PM
Subject: Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue
6109046)
You then need to tick a box more or two to enable
LGTM
http://codereview.appspot.com/6109046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 26 avr. 2012, at 11:43, James wrote:
Mike,
On 26 April 2012 08:51, m...@apollinemike.com m...@apollinemike.com wrote:
On 26 avr. 2012, at 09:05, James wrote:
Hello,
On 26 April 2012 07:55, m...@apollinemike.com m...@apollinemike.com wrote:
On 26 avr. 2012, at 07:28, Graham
- Original Message -
From: m...@apollinemike.com
To: James pkx1...@gmail.com
Cc: k-ohara5...@oco.net; d...@gnu.org; lilypond-devel@gnu.org
Sent: Friday, April 27, 2012 3:41 PM
Subject: Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue
6109046)
On 26 avr. 2012, at 11:43
Hello,
On 27 April 2012 15:56, Phil Holmes m...@philholmes.net wrote:
It may depend on your hardware whether this makes sense. My Ubuntu build
box can multithread within the VM, whereas my (older) Windows box can't.
Depends on the paravirtualization.
eg.
- Original Message -
From: James pkx1...@gmail.com
To: Phil Holmes m...@philholmes.net
Cc: m...@apollinemike.com; k-ohara5...@oco.net; d...@gnu.org;
lilypond-devel@gnu.org
Sent: Friday, April 27, 2012 5:58 PM
Subject: Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue
On 26 avr. 2012, at 07:28, Graham Percival wrote:
Well, right now we have nobody running the automated tests to
check that new patches are ok. So there will be no patches
accepted to lilypond.
I have a meeting in mid-May w/ the University of Paris VIII. They're donating
a computer to
Hello,
On 26 April 2012 07:55, m...@apollinemike.com m...@apollinemike.com wrote:
On 26 avr. 2012, at 07:28, Graham Percival wrote:
Well, right now we have nobody running the automated tests to
check that new patches are ok. So there will be no patches
accepted to lilypond.
I have a
On 26 avr. 2012, at 09:05, James wrote:
Hello,
On 26 April 2012 07:55, m...@apollinemike.com m...@apollinemike.com wrote:
On 26 avr. 2012, at 07:28, Graham Percival wrote:
Well, right now we have nobody running the automated tests to
check that new patches are ok. So there will be
On Thu, Apr 26, 2012 at 08:05:53AM +0100, James wrote:
Hello,
On 26 April 2012 07:55, m...@apollinemike.com m...@apollinemike.com wrote:
I have a meeting in mid-May w/ the University of Paris VIII. They're
donating a computer to LilyPond and I'll set patchy up on it.
While you can set
m...@apollinemike.com m...@apollinemike.com writes:
On 26 avr. 2012, at 09:05, James wrote:
Hello,
On 26 April 2012 07:55, m...@apollinemike.com m...@apollinemike.com wrote:
On 26 avr. 2012, at 07:28, Graham Percival wrote:
Well, right now we have nobody running the automated tests
Graham Percival gra...@percival-music.ca writes:
On Thu, Apr 26, 2012 at 08:05:53AM +0100, James wrote:
Hello,
On 26 April 2012 07:55, m...@apollinemike.com m...@apollinemike.com wrote:
I have a meeting in mid-May w/ the University of Paris
VIII. They're donating a computer to LilyPond
Mike,
On 26 April 2012 08:51, m...@apollinemike.com m...@apollinemike.com wrote:
On 26 avr. 2012, at 09:05, James wrote:
Hello,
On 26 April 2012 07:55, m...@apollinemike.com m...@apollinemike.com wrote:
On 26 avr. 2012, at 07:28, Graham Percival wrote:
Well, right now we have nobody
It would appear that you ignored
http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/465,
http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/466, the end
of http://permalink.gmane.org/gmane.comp.gnu.lilypond.devel/46312 and
http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/442.
On 25 April 2012 11:57, d...@gnu.org wrote:
It would appear that you ignored
http://permalink.gmane.org/**gmane.comp.gnu.lilypond.auto/**465http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/465
,
http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (left):
http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc#oldcode68
lily/ledger-line-spanner.cc:68: while (flip (d) != DOWN);
On 2012/04/25 11:47:07, Milimetr88
Łukasz Czerwiński milimet...@gmail.com writes:
On 25 April 2012 11:57, d...@gnu.org wrote:
It would appear that you ignored
http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/465,
http://permalink.gmane.org/gmane.comp.gnu.lilypond.auto/466,
No - just look at dates - the
On Wed, Apr 25, 2012 at 01:44:14PM +0200, Łukasz Czerwiński wrote:
As I understand, fixxcc.py will correct that automatically, so I don't
have to bother about that? Nevertheless I'll remember that for my
future patches.
fixcc.py can correct those, but this adds noise to the git
commit
I know that this is not a very positive message, but I am trying
to save you yet more anguish. The lilypond project currently does
not even function smoothly between senior developers with more
than 100 commits each; there is very little chance for a new
contributor to have a smooth and
On 25 April 2012 14:52, David Kastrup d...@gnu.org wrote:
(...)
To me, that does not look like you particularly value getting a review.
You have not fixed a single thing I pointed out. You have not checked
your submission yourself for the problems.
I didn't notice that comment. I'm not
Łukasz Czerwiński milimet...@gmail.com writes:
I have never ever get an email from Google Code. I have just checked
that triple. That's the reason for ignoring your comments. I'm sorry
that my new patch made you run your tests twice to give me the same
list of errors...
Do you run tests
On 25 April 2012 17:06, David Kastrup d...@gnu.org wrote:
Łukasz Czerwiński milimet...@gmail.com writes:
I have never ever get an email from Google Code. I have just checked
that triple. That's the reason for ignoring your comments. I'm sorry
that my new patch made you run your tests
Almost there, if the regtests run clean, but the added 'for' loops are
still not in GNU style - they need a space after 'for'. This must be
corrected before pushing. See
http://permalink.gmane.org/gmane.comp.gnu.lilypond.devel/46312 where
Keith explained this earlier.
On Wed, Apr 25, 2012 at 03:14:33PM +0200, Łukasz Czerwiński wrote:
I know that this is not a very positive message, but I am trying
to save you yet more anguish. Â The lilypond project currently does
not even function smoothly between senior developers with more
than 100
Reviewers: Keith, Graham Percival,
http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh
File flower/include/direction.hh (right):
http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode63
flower/include/direction.hh:63: // huh?
On 2012/04/24
Looks good to me,
but I suggest you also solve the bug you found (issue 2493) in this
patch but preferably as a separate commit.
Then you can convert all the loops.
http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh
File flower/include/direction.hh (right):
LGTM
http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh
File flower/include/direction.hh (right):
http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode78
flower/include/direction.hh:78: #define DOWN_and_UP(d) \
I see that our code uses both
27 matches
Mail list logo
