Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-04-04 Thread thomasmorley65
On 2013/04/03 08:31:26, dak wrote: Perhaps double-check that the % end verbatim occurs only where expected in master, Done. and then close as fixed, possibly with the version number where the fix traveled in via makelsr. Done. https://codereview.appspot.com/7834043/

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-04-03 Thread Janek Warchoł
Hi, On Wed, Apr 3, 2013 at 1:41 AM, thomasmorle...@googlemail.com wrote: On 2013/04/02 21:35:23, janek wrote: Is this patch still valid? I don't see any ' signs being removed, Meanwhile I removed the '-signs from the relevant snippets in LSR as well. I wasn't aware that a new release

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-04-03 Thread David Kastrup
Janek Warchoł janek.lilyp...@gmail.com writes: Hi, On Wed, Apr 3, 2013 at 1:41 AM, thomasmorle...@googlemail.com wrote: On 2013/04/02 21:35:23, janek wrote: Is this patch still valid? I don't see any ' signs being removed, Meanwhile I removed the '-signs from the relevant snippets in

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-04-02 Thread janek . lilypond
Is this patch still valid? I don't see any ' signs being removed, only some semi-random side-effects here and there. best, Janek https://codereview.appspot.com/7834043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-04-02 Thread thomasmorley65
On 2013/04/02 21:35:23, janek wrote: Is this patch still valid? I don't see any ' signs being removed, Meanwhile I removed the '-signs from the relevant snippets in LSR as well. I wasn't aware that a new release would contain them. So it is indeed invalid. git grep #'# only returns some

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-03-26 Thread dak
https://codereview.appspot.com/7834043/diff/13001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly File Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly (right):

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-03-25 Thread dak
https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly File Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly (right):

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-03-24 Thread dak
https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly File Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly (right):

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-03-17 Thread janek . lilypond
This patch needs a review from someone more knowledgeable in docs/snippets than me. https://codereview.appspot.com/7834043/diff/2001/Documentation/snippets/new/applying-note-head-styles-depending-on-the-step-of-the-scale.ly File

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-03-17 Thread thomasmorley65
On 2013/03/17 16:24:16, janek wrote: This patch needs a review from someone more knowledgeable in docs/snippets than me. +1 All I did was: I copied the files from /Documentation/snippets into /Documentation/snippets/new. Removed the '-signs, deleted the comments above the old

Re: Removes '-signs in vectors - follow-up (issue 7834043)

2013-03-14 Thread thomasmorley65
Please review this patch as follow-up fix for issue 3010. It was the first time I run scripts/auxiliar/makelsr.py Hope I did it right. https://codereview.appspot.com/7834043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org