LGTM
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly
File input/regression/markup-rest-styles.ly (right):
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly#newcode18
input/regression/markup-rest-styles.ly:18:
On 2012/12/04 19:49:00, benko.pal wrote:
LGTM
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly
File input/regression/markup-rest-styles.ly (right):
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly#newcode18
LGTM, thanks!
https://codereview.appspot.com/6850073/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2012/11/30 01:33:08, thomasmorley65 wrote:
On 2012/11/29 20:42:21, benko.pal wrote:
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly
File input/regression/markup-rest-styles.ly (right):
On 2012/12/02 15:41:01, dak wrote:
mailto:thomasmorle...@googlemail.com writes:
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
no. could you push to a dev/ branch?
Sorry. I'm still a newbie in devel tasks.
If you have a
thomasmorle...@googlemail.com writes:
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
no. could you push to a dev/ branch?
Sorry. I'm still a newbie in devel tasks.
If you have a branch where you checked in your changes, you
thomasmorle...@googlemail.com writes:
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
no. could you push to a dev/ branch?
Sorry. I'm still a newbie in devel tasks.
If you have a branch where you checked in your changes, you can
On 2012/11/29 00:41:14, thomasmorley65 wrote:
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
I did now, it's OK with me.
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly
File
On 2012/11/29 20:42:21, benko.pal wrote:
On 2012/11/29 00:41:14, thomasmorley65 wrote:
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
I did now,
Thanks for doing this.
it's OK with me.
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
no. could you push to a dev/ branch?
Sorry. I'm still a newbie in devel tasks.
Especially with the tools needed for it.
Imagine that I tried to upload my new patch this evening. It
On 2012/11/26 21:11:53, thomasmorley65 wrote:
On 2012/11/26 15:09:58, benko.pal wrote:
http://codereview.appspot.com/6850073/diff/6004/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
On 2012/11/25 23:03:43, thomasmorley65 wrote:
On 2012/11/21 08:05:09, benko.pal wrote:
[...]
there are no separate glyphs for rests and multi measure rests: the
M in glyph
names stands not for MultiMeasure, but for Minus.
Didn't know that.
that makes for rewriting the
cond below, I'm
On 2012/11/26 11:37:26, benko.pal wrote:
I just meant that instead of checking several times whether dealing
with
multi-measure rest or not, you may convert duration log at a single
place (with
the caveat of turning a negative sign to 'M' instead of '-').
Probably even without the caveat.
On 2012/11/26 11:51:03, dak wrote:
On 2012/11/26 11:37:26, benko.pal wrote:
I just meant that instead of checking several times whether dealing
with
multi-measure rest or not, you may convert duration log at a single
place
(with
the caveat of turning a negative sign to 'M' instead of
So I'd suggest not treating the '-' at all (to make things not more
confusing than they already are) and letting the font backend sort
things out.
I concur.
http://codereview.appspot.com/6850073/diff/6004/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
On 2012/11/26 15:09:58, benko.pal wrote:
So I'd suggest not treating the '-' at all (to make things not more
confusing than they already are) and letting the font backend sort
things out.
I concur.
Ok, I'll try.
On 2012/11/21 08:05:09, benko.pal wrote:
[...]
there are no separate glyphs for rests and multi measure rests: the M
in glyph
names stands not for MultiMeasure, but for Minus.
Didn't know that.
that makes for rewriting the
cond below, I'm afraid, but it will be simpler.
Well, I want the
http://codereview.appspot.com/6850073/diff/9001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/6850073/diff/9001/scm/define-markup-commands.scm#newcode3247
scm/define-markup-commands.scm:3247: M
there are no separate glyphs for rests
Hi Werner,
thanks for reviewing.
New patch set uploded.
http://codereview.appspot.com/6850073/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2012/11/19 05:11:38, lemzwerg wrote:
http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm#newcode3341
scm/define-markup-commands.scm:3341:
Reviewers: ,
Message:
Please review
Description:
markup-commands rest-by-number and rest
Introduces two new markup-commands:
rest-by-number and rest
similiar to the existing note-by-number and note.
Two regression-tests for them are added.
Please review this at
2012/11/19 thomasmorle...@googlemail.com:
Reviewers: ,
Message:
Please review
Description:
markup-commands rest-by-number and rest
Introduces two new markup-commands:
rest-by-number and rest
similiar to the existing note-by-number and note.
Two regression-tests for them are added.
On 11/18/2012 04:54 PM,c wrote:
Reviewers: ,
Message:
Please review
To help this get formal attention, Harm, I've created an issue on our
tracker, with reference to your Rietveld item. We strongly encorage
developers to use the git-cl tool for uploading patches, as it takes
care of the
2012/11/19 Colin Campbell c...@shaw.ca:
On 11/18/2012 04:54 PM,c wrote:
[...]
To help this get formal attention, Harm, I've created an issue on our
tracker, with reference to your Rietveld item.
Thanks for doing this.
We strongly encorage
developers to use the git-cl tool for uploading
http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm#newcode3341
scm/define-markup-commands.scm:3341: breve, longa and maxima are valid
input-strings
25 matches
Mail list logo
