Reviewers: ,
Message:
It's possible to add a markup to a footer/header of a specified page,
using #(which-page page-number).
Multiple settings are possible.
Please review as
http://codereview.appspot.com/6352049
-Harm
Description:
which-page
It's possible to add a markup to a footer/header
On 2012/06/29 10:13:42, t.daniels_treda.co.uk wrote:
Thomas Morley wrote Friday, June 29, 2012 10:32 AM
Of course all features (old and new) should be documented.
But, AFAICT, non of the possibilities offered in /ly/titling-init.ly
(i.e. first-page, last-page, not-first-page,
http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely#newcode1018
Documentation/notation/input.itely:1018: @item not-first-page
@tab
Great work so far.
Some minor suggestions:
http://codereview.appspot.com/6498052/diff/5001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/5001/scm/bar-line.scm#newcode203
scm/bar-line.scm:203:
If a user defines some curious bar-lines like:
http://codereview.appspot.com/6498052/diff/10001/Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
File
Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
(right):
More nit-picking:
http://codereview.appspot.com/6498052/diff/7003/python/convertrules.py
File python/convertrules.py (right):
http://codereview.appspot.com/6498052/diff/7003/python/convertrules.py#newcode3395
python/convertrules.py:3395: @rule ((2, 17, 2), rNew bar line
interface)
There's no
On 2012/09/20 18:08:15, Graham Percival wrote:
We normally do not include \override in most sections of the Notation
manual.
Instead, we ask users to submit LSR snippets showing the \override,
then we
include those snippets in the docs. This allows us to improve the
documentation
with
One tiny addition:
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm#newcode1053
scm/bar-line.scm:1053: (define-bar-line :|] :|] #f |)
When we provide a bracket-repeat-sign for
After testing the patch's functionality, only:
LGTM
http://codereview.appspot.com/6588056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2012/11/05 22:40:36, lemzwerg wrote:
Very nice!
Can't review the code.
But from description:
GREAT
http://codereview.appspot.com/6812088/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Reviewers: ,
Message:
Please review
Description:
markup-commands rest-by-number and rest
Introduces two new markup-commands:
rest-by-number and rest
similiar to the existing note-by-number and note.
Two regression-tests for them are added.
Please review this at
Hi Werner,
thanks for reviewing.
New patch set uploded.
http://codereview.appspot.com/6850073/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2012/11/19 05:11:38, lemzwerg wrote:
http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/6850073/diff/1/scm/define-markup-commands.scm#newcode3341
scm/define-markup-commands.scm:3341:
On 2012/11/22 11:04:00, Trevor Daniels wrote:
[...]
I might chop the explanations - users in
general don't need this level of understanding.
Well, in the past I sometimes was beaten by the not explained why? and
how? in the docs.
So I'd always vote for deeper explanations in an additional
On 2012/11/21 08:05:09, benko.pal wrote:
[...]
there are no separate glyphs for rests and multi measure rests: the M
in glyph
names stands not for MultiMeasure, but for Minus.
Didn't know that.
that makes for rewriting the
cond below, I'm afraid, but it will be simpler.
Well, I want the
On 2012/11/25 23:06:58, Trevor Daniels wrote:
LGTM
Trevor
+1
Harm
http://codereview.appspot.com/6851102/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2012/11/22 12:42:04, Trevor Daniels wrote:
[...]
The Extending Manual is the place for explanations useful to
developers. Granted this is rather embryonic at present, due
mainly to a dearth of knowledgeable people willing to contribute
to it. It would benefit greatly from further input ;)
On 2012/11/26 15:09:58, benko.pal wrote:
So I'd suggest not treating the '-' at all (to make things not more
confusing than they already are) and letting the font backend sort
things out.
I concur.
Ok, I'll try.
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
no. could you push to a dev/ branch?
Sorry. I'm still a newbie in devel tasks.
Especially with the tools needed for it.
Imagine that I tried to upload my new patch this evening. It
On 2012/11/29 20:42:21, benko.pal wrote:
On 2012/11/29 00:41:14, thomasmorley65 wrote:
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
I did now,
Thanks for doing this.
it's OK with me.
https://codereview.appspot.com/6850073
On 2012/11/30 01:33:08, thomasmorley65 wrote:
On 2012/11/29 20:42:21, benko.pal wrote:
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly
File input/regression/markup-rest-styles.ly (right):
https://codereview.appspot.com/6850073/diff/7/input/regression
On 2012/12/02 15:41:01, dak wrote:
mailto:thomasmorle...@googlemail.com writes:
On 2012/11/27 20:03:06, benko.pal wrote:
Did you had a look on the compiled output of the new reg-tests?
no. could you push to a dev/ branch?
Sorry. I'm still a newbie in devel tasks.
If you have a
On 2012/12/04 19:49:00, benko.pal wrote:
LGTM
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly
File input/regression/markup-rest-styles.ly (right):
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly#newcode18
Reviewers: ,
Message:
Please review.
I didn't touch the translations. Correct?
git grep #'#
returns one file I don't know what to do with:
Binary file Documentation/pictures/baer-sarabande-original.jpg matches
Description:
Removes '-signs from vectors
Removes '-signs in vectors from the
Reviewers: ,
Message:
Please review
Description:
Changes lilypond-example for rest-by-number
Please review this at https://codereview.appspot.com/6924053/
Affected files:
M scm/define-markup-commands.scm
Index: scm/define-markup-commands.scm
diff --git a/scm/define-markup-commands.scm
Can't review parser-code, but from description:
LGTM
For the sake of easier understanding I'd have given these
examples,though, to show that printing yes/no is more a matter of
accident:
% fingering is printed
%\displayMusic
{ \tweak #'color #red -3 c }
% fingering is not printed
On 2012/12/26 13:15:05, J_lowe wrote:
Is there any case where a snippet would not have the docs tag?
James
Some statistic from the last LSR-update:
The 2.12.3-LSR contained 645 snippets.
291 were tagged docs.
There are many LSR-snippets showing nice code/features, but not all of
them are
LGTM
Two questions:
a) Where is `identity´ defined? I can't find it, neither in LilyPond nor
in the guile-manual.
b) Why are the definitions in lily-library.scm not all (or nearly all)
defined public?
Some examples:
split-list
other-axis
index-cell
sign
I see no reason _not_ to make
Reviewers: ,
Message:
Please review
Description:
Introducing two new markup-commands: draw-dashed-line and
draw-dotted-line.
Adding a reg-test for them.
Please review this at https://codereview.appspot.com/7029045/
Affected files:
A input/regression/markup-line-styles.ly
M
On 2012/12/30 16:42:56, dak wrote:
On 2012/12/30 16:30:45, J_lowe wrote:
Excuse my ignorance but is the \xxx-xxx-xxx ok in terms of
consistency of name
of command and/or is 'draw' redundant?
\line arranges a text line, \draw-line draws an actual line, so the
name choice
seems ok.
On 2012/12/31 14:59:45, david.nalesnik wrote:
Harm--
This looks great! Thank you for the 'full-length option. I can't be
alone in
hating lines ending with incomplete dashes.
Hi David,
thanks for reviewing!
All I have is a suggestion or two, and some quibbles.
Besides what I've
Reviewers: ,
Message:
Quite trivial.
Nevertheless, please review
Description:
typo in time-signature-settings.scm
Fixing missing space in commented example
issue 3074
Please review this at https://codereview.appspot.com/7030052/
Affected files:
M scm/time-signature-settings.scm
Index:
On 2013/01/07 15:35:37, J_lowe wrote:
I didn't think Thomas had push privileges (based on older commits last
year).
I asked Marc to push. But you were faster. :)
Please close Rietveld issue, thank you.
James
Closed.
https://codereview.appspot.com/7030052/
Reviewers: ,
Message:
Please review.
The regtests markup-note.ly and markup-note-styles.ly are modified.
Changes are expected.
Description:
\note-by-number supports flag-styles
Issue 3104
For mensural and neomensural the flag is changed due to the
note-head-style.
Straight flags are possible
Reviewers: ,
Message:
Please review
Description:
oversight in repeats.itely
Old bar-line-glyphs corrected
Fix for issue 3150
Please review this at https://codereview.appspot.com/7232068/
Affected files:
M Documentation/notation/repeats.itely
Index: Documentation/notation/repeats.itely
Don't know why two identical patch-sets were uploaded
On 2013/02/02 16:11:19, dak wrote:
https://codereview.appspot.com/7231072/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
On 2013/02/13 22:56:30, Trevor Daniels wrote:
I definitely prefer the alternative you suggest in para 3.
You would not then need the warning, which is only necessary due to
the
complicated 2-stage interface.
I'd second.
Regarding:
melody =
\relative c' {
%\override Script
On 2013/02/14 09:21:07, dak wrote:
So the message is we can do, but we still need to figure out _what_
we can do. Proposals?
Well, currently I don't have a good idea.
Though, some time ago Arnold posted his approach on -user:
LGTM
One suggestion:
https://codereview.appspot.com/7400057/diff/1/input/regression/test-output-distance.ly
File input/regression/test-output-distance.ly (right):
https://codereview.appspot.com/7400057/diff/1/input/regression/test-output-distance.ly#newcode20
Hi Mike,
one thought.
The image Trevor Bača posted
http://lists.gnu.org/archive/html/lilypond-user/2013-03/pngIGBdggySyh.png
shows that the left ends of a decrecsendo-hairpin are vertical aligned
even if the hairpin isn't extended horizontal but ascending.
Currently the vertical alignment is
Hi Mike,
decrescendo doesn't work!!
My idea about drag-hairpin seems not too hard to implement, ofcourse
there would be need to do a clean definition of the property, currently
LilyPond returns a unsurprisingly warning:
#(define-public ((elbowed-hairpin coords mirrored?) grob)
(define
Hi Mike,
sorry to have some more nit-picks.
https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm#newcode1051
scm/output-lib.scm:1051: 0.1
Hard-coded thickness.
Why not
On 2013/03/11 23:38:17, thomasmorley65 wrote:
https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm#newcode1052
scm/output-lib.scm:1052: 1.0
I'd do the scaling here.
ly:stencil-scale would be superfluous than.
Either scaling-method will change the direction of constante
Hi Mike,
sorry to be such an inch pincher.
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm#newcode1061
scm/output-lib.scm:1061: (thick (* thick (layout-line-thickness
Please review this patch as follow-up fix for issue 3010.
It was the first time I run scripts/auxiliar/makelsr.py
Hope I did it right.
https://codereview.appspot.com/7834043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2013/03/17 07:27:37, MikeSol wrote:
On 2013/03/13 21:38:59, thomasmorley65 wrote:
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/7615043/diff/23001/scm/output-lib.scm#newcode1061
scm/output
On 2013/03/17 16:24:16, janek wrote:
This patch needs a review from someone more knowledgeable in
docs/snippets than
me.
+1
All I did was:
I copied the files from /Documentation/snippets into
/Documentation/snippets/new.
Removed the '-signs, deleted the comments above the old
On 2013/03/17 12:42:02, mike7 wrote:
You'd have to have a wrapper function with a call to ly:scale-stencil
with a -1
to the Y axis based on the direction of the grob.
Sure.
Or in
(define (my-c-p-s ...
as it is done for `decresc?´
This is doable, but I'd wait to see from someone who knows
On 2013/03/17 16:25:55, Joseph Rushton Wakeling wrote:
On 2013/03/17 14:37:52, thomasmorley65 wrote:
I want to say that they are always printed with the line going up
irrespective
of the side of the staff, but I could be wrong.
There are Ferneyhough scores with dynamics above the staff
Some nitpicks.
Otherwise LGTM
https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely#newcode73
Documentation/changes.tely:73: Two ways of letting graphical
On 2013/03/30 19:38:09, dak wrote:
Address Thomas' comments
The description doesn't explain why
\relative c'' { a e' \single \omit NoteHead ais1 }
returns a programming error.
Though, this is definitely not a topic of \single, \omit or Changes in
general.
LGTM
On 2013/04/02 21:35:23, janek wrote:
Is this patch still valid? I don't see any ' signs being removed,
Meanwhile I removed the '-signs from the relevant snippets in LSR as
well. I wasn't aware that a new release would contain them.
So it is indeed invalid.
git grep #'# only returns some
On 2013/04/03 08:31:26, dak wrote:
Perhaps double-check that the % end verbatim occurs only where
expected
in master,
Done.
and then close as fixed, possibly with the version number
where the fix traveled in via makelsr.
Done.
https://codereview.appspot.com/7834043/
Can't review C++ -code, though, from description, I do not understand
the reason for it.
Well, ofcourse it will merge better with barlines, but can you give an
example where the problem isn't solvable with at most medium effort?
Ah, wait, I just found
http://lsr.dsi.unimi.it/LSR/Search?q=color
On 2013/04/11 23:44:03, thomasmorley65 wrote:
Ah, wait, I just found
http://lsr.dsi.unimi.it/LSR/Search?q=color
Regarding it with very high zoom shows a greater disadvantage of
draw-line.
Nevertheless, I think it's more a problem of said snippet, worth
fixing.
Sorry, wrong link.
Should
One nitpick.
Otherwise LGTM
https://codereview.appspot.com/10543044/diff/1/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):
https://codereview.appspot.com/10543044/diff/1/Documentation/notation/vocal.itely#newcode629
Documentation/notation/vocal.itely:629:
Reviewers: ,
Message:
Please review.
Description:
Add @code{} to middleCOffset
Wraps middleCOffset from doc-string of ly:set-middle-C!
(pitch-scheme.cc) into @code{}
Fix issue 3424
Please review this at https://codereview.appspot.com/10566043/
Affected files:
M lily/pitch-scheme.cc
I didn't apply the patch and I can't review C++, though, after a first
quick glance, some nitpicks:
https://codereview.appspot.com/10965043/diff/1/scm/define-event-classes.scm
File scm/define-event-classes.scm (right):
On 2013/07/06 00:05:35, dak wrote:
https://codereview.appspot.com/10965043/diff/1/scm/define-event-classes.scm
File scm/define-event-classes.scm (right):
https://codereview.appspot.com/10965043/diff/1/scm/define-event-classes.scm#newcode87
scm/define-event-classes.scm:87: (define
Some thoughts, otherwise LGTM.
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
https://codereview.appspot.com/10935046/diff/1/Documentation/notation/fretted-strings.itely#newcode1864
Reviewers: ,
Message:
Please review.
Description:
More details about limitation of \addlyrics in
Documentation/notation/vocal.itely
Add a hint, that \addlyrics does not work with TabStaff
Fix for issue 3450
Please review this at https://codereview.appspot.com/11062043/
Affected files:
M
Reviewers: ,
Message:
Please review.
Description:
Fix some oversights of \layout in \book
follow-up for issue 3151
Please review this at https://codereview.appspot.com/10794044/
Affected files:
M Documentation/notation/input.itely
Index: Documentation/notation/input.itely
diff --git
Reviewers: ,
Message:
Please review.
(git-cl seems to work - currently)
Description:
adding markup-commands \oval and \ellipse
\oval and \ellipse are drawing an oval respectively an ellipse around
their argument.
Also adding a reg-test for markup-commands framing their argument.
Please
This disturbed me to, though, not to a point that I started to work on
it my own. ;)
One thought:
https://codereview.appspot.com/12732043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
LGTM
https://codereview.appspot.com/12732043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/12732043/diff/7001/Documentation/extending/programming-interface.itely
File Documentation/extending/programming-interface.itely (right):
https://codereview.appspot.com/12732043/diff/7001/Documentation/extending/programming-interface.itely#newcode277
On 2013/08/15 10:36:06, dak wrote:
Also, the only thing that makes this \displayMarkup rather than
\displayScheme is the restriction of the argument type to markup?.
Perhaps
it would make sense to call the whole function \displayScheme instead
and allow
arguments of type scheme? here?
+1
LGTM
https://codereview.appspot.com/13088043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2013/08/18 10:20:07, janek wrote:
LGTM (but i'm not a parser expert)
I've no clue about the parser, from description:
LGTM
Sorry for a possibly ignorant question: will this patch also remove
the error in
case of
mus = { a }
\mus
?
No.
If not, would there be an easy way to fix that?
Reviewers: ,
Message:
Hi,
please review, though, I don't expect any visible changes in reg-tests
or docs.
Description:
Some clean up about grace-settings in music-functions.scm
- Stores a list,general-grace-settings, used by make-voice-props-set and
make-voice-props-override.
- Settings to be
Hi,
please review.
https://codereview.appspot.com/13612043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
typo
LGTM
https://codereview.appspot.com/13300048/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/13300048/diff/1/Documentation/changes.tely#newcode66
Documentation/changes.tely:66: the allowance of horizontal sapce for
tempo and
LGTM
https://codereview.appspot.com/13904043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
Question:
considering LSR-update, I recently added an earlier version of it to the
LSR
http://lsr.dsi.unimi.it/LSR/Item?id=887
Should I replace it with this one?
https://codereview.appspot.com/13826047/
___
lilypond-devel mailing list
Reviewers: ,
Message:
Please review.
Description:
Making flat flags available
The markup-command 'note-ny-number' and the relvant regression-
tests are extended, too.
The sippet 'using-alternative-flag-styles.ly' from
Documentation/snippets/new/ isn't changed for now, will be tackled
in a
Although, I can't review C++, I've applied the patch for testing
(hopefully without mistake)
Testing this code
{ c''1_\mf^\ \break d''_\mp^\! }
I've got:
programming error: Spanner `Hairpin' is not fully contained in parent
spanner. Ignoring orphaned part
{ c''1_\mf
^\ \break
On 2013/10/06 23:10:16, dak wrote:
On 2013/10/06 23:00:25, thomasmorley651 wrote:
[...]
Or am I completely wrong and this patch has nothing to do with the
problem
above?
In this case, you are completely wrong.
[...]
Anyway, thanks for clarifying.
Reviewers: ,
Message:
Please review.
Description:
format-metronome-mark and metronome-markup don't support styles other
than default
issue 3096
- introducing 'styled-metronome-markup' with the possibility to set
different styles for note-head and flag. Also, and currently quite
theoretical,
On 2013/10/17 21:29:04, dak wrote:
The interface looks cumbersome to use. Why don't you just take the
styles that
are used in the Score?
Well, short answer: I don't know how.
It might mean adding the respective properties to the
font-interface (MetronomeMark has both font-interface and
LGTM
https://codereview.appspot.com/35440044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Can't review parser code.
From description: great
https://codereview.appspot.com/78690043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
Please review
Description:
Clearify use of break-align-orders in NR A.17 Layout properties
Issue 3939
It should be sufficient to refer to
'Separating key cancellations from key signature changes' from
Documentation/snippets to show how to get different settings for
On 2014/06/02 23:23:23, Carl wrote:
On 2014/06/02 21:47:59, thomasmorley651 wrote:
Better referencing
I think that this is a wrong approach. The list of properties in the
.scm file
is not the appropriate place to teach the use of the properties.
Furthermore,
in my opinion there should
Reviewers: ,
Message:
Please review
Description:
Color and/or parenthesize single dots in fret-diagrams
Issue 2752
Makes it possible to color and/or parenthesize single dots in
fret-diagram-verbose
Introducing two properties for use in fret-diagram-details
- fret-label-horizontal-offset
On 2014/06/14 18:48:14, J_lowe wrote:
https://codereview.appspot.com/102450043/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
On 2014/06/15 07:46:22, marc wrote:
Hi Harm,
great work, mostly LGTM, just two small nitpicks.
https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):
https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm#newcode119
On 2014/07/06 06:46:53, Mark Polesky wrote:
Hi, I'm proposing to get rid of the BarLine.thin-kern property with
this patch,
so if you're opposed, let me know.
You can see my comments/rationale here:
http://code.google.com/p/lilypond/issues/detail?id=3995
Thanks,
Mark
I disagree!
'kern
On 2014/07/06 12:53:55, Mark Polesky wrote:
On 2014/07/06 11:52:56, thomasmorley651 wrote:
I disagree!
'kern and 'thin-kern _are_ used differently.
Look at the output from:
Harm,
what am I missing? To my eye (compiling this with the latest
snapshot), your
example shows that thin-kern
On 2014/07/07 07:25:15, marc wrote:
On 2014/07/07 01:31:01, Mark Polesky wrote:
On 2014/07/06 11:52:56, thomasmorley651 wrote:
I disagree!
'kern and 'thin-kern _are_ used differently.
But *do* we need two different variables which then are used with
exactly the
same value?
Do we need
On 2014/07/07 20:48:17, Mark Polesky wrote:
[...]
this raises
a new question: How do I tweak the distance between the half-note's
two stems in
tablature?
\new TabStaff {
\tabFullNotation
c2
}
You can't.
It's hardcoded with tabvoice::draw-double-stem-for-half-notes in
Reviewers: ,
Message:
please review
Description:
typo/oversight in align-interface.cc and page-layout-problem.cc
issue 4008
fix oversight in doc-string of align-interface.cc
fix typo in comment of page-layout-problem.cc
Please review this at https://codereview.appspot.com/115770043/
One nitpick, otherwise LGTM
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2541
Can't review the C++ part.
Some nitpicks in the regtest.
Will it be possible to tweak the first part of the Tie etc at line-end
as well?
With a combi of setting 'minimum-length-after-break' and
'minimum-length?
If yes, I'd show an example in the regtest. At least it should be
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly
File input/regression/minimum-length-after-break.ly (right):
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly#newcode15
please review
https://codereview.appspot.com/199460043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
please review
Description:
making measure-counter-stencil public
Issue 4292
In order to work with 'make-stencil-boxer' etc
Please review this at https://codereview.appspot.com/203130043/
Affected files (+1, -1 lines):
M scm/output-lib.scm
Index: scm/output-lib.scm
'using-alternative-flag-styles.ly' is not in Documentation/snippets/new/
any more.
I changed it directly in LSR. The changed snippet will show up after
next LSR-import.
Looks I can't post to the tracker-issue for 3591 any more, because it's
closed.
https://codereview.appspot.com/14303044/
On 2015/02/09 06:09:34, lemzwerg wrote:
LGTM. It would be nice if David's checker script could be added, too.
More, I'd consider it a good idea to use the checker on the current
patch again.
There was such a mess that I'm not sure I corrected all.
LGTM
https://codereview.appspot.com/201140043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
https://codereview.appspot.com/186640043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
1 - 100 of 449 matches
Mail list logo
