Re: OLL/snippets renaming (Re: Broken (?) snippets in openlilylib/snippets)
Hi Paul,
thanks for your thoughts and suggestion.
Am 12.07.2017 um 18:04 schrieb Paul:
> On 07/11/2017 10:35 AM, Urs Liska wrote:
>
>> I would like to rename some directories and move some snippets. In
>> particular the "notation-snippets" and the "input-shorthands" seem
>> somewhat blurred to me. And, with the nicer syntax of \loadModule I
>> would prefer shorter and less redundant names.
>>
>>\loadModule snippets.lyrics.align-on-vowels
>>
>> is more convenient and expressive than
>>
>>\loadModule snippets.notation-snippets.align-lyrics-on-vowels
>>
>> etc.
>>
>> The question is:
>>
>> How many people are actually using the snippets repository, and how much
>> inconvenience would that be for these people. I *can* take some care
>> about "deprecating" and redirecting includes, but doing this generally
>> would actually make the whole thing totally convoluted. So actually I'd
>> prefer a clean cut and starting over with a new and cleaner structure.
>>
>> Opinions? Objections?
>
> No objections here. Seems like a job for some kind of versioning or
> renaming of the snippets collection as a whole? ("snippets2"?) Then
> you could preserve backwards compatibility and get your clean break.
>
> Or... this may not be helpful... but would it work to just move the
> contents of snippets out into their own modules, deprecating the
> "snippets" grouping, but leaving it in place, as is, for now for
> backwards compatibility? So then you'd have, say:
>
> \loadModule lyrics.align-on-vowels
>
> Not sure what the larger repercussions of this would be, as I haven't
> kept up with how things are organized. Feel free to disregard.
I mostly adopted your idea, which sounds - mostly - great to me.
I have made a copy of the snippets repository with the name oll-misc.
This pretty much reflects what this repository is actually about in my
opinion - and it moves away from confusingly duplicating with the LSR.
In this new repository I have all the liberty to throw out stuff that
has long been reimplemented elsewhere (in openLilyLib and also in
LilyPond itself), reorganize and rename items to my liking and also move
things out of the repo into other packages.
I'm very sorry that I don't have the time to bring everything in a clean
shape at the same time but at least it'll be a clean and hopefully final
structure.
The "cost" of that solution is that the snippets repository will
probably be even more exposed to bitrot as it already is now ...
I'll add a big deprecation warning to the README, though, encouraging
anyone not to continue using openlilylib/snippets.
Best
Urs
>
> -Paul
>
>
> ___
> lilypond-user mailing list
> lilypond-user@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-user
--
u...@openlilylib.org
https://openlilylib.org
http://lilypondblog.org
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: OLL/snippets renaming (Re: Broken (?) snippets in openlilylib/snippets)
No objections here too.
Best,
James
> Original Message
> Subject: OLL/snippets renaming (Re: Broken (?) snippets in
> openlilylib/snippets)
> Local Time: July 11, 2017 11:35 AM
> UTC Time: July 11, 2017 2:35 PM
> From: u...@openlilylib.org
> To: lilypond-user@gnu.org
> Hi all,
> by now I"ve fixed a number of the below issues and created a few items
> on the issue tracker for the remaining ones.
> Right now I"m wrapping things up a little bit, and part of this is an
> urge to restructure the repository somewhat. In the beginning of the
> repository there was no proper strategy for a directory structure,
> basically whenever someone didn"t immediately know where to put a new
> snippet they decided to create a new directory ;-)
> I would like to rename some directories and move some snippets. In
> particular the "notation-snippets" and the "input-shorthands" seem
> somewhat blurred to me. And, with the nicer syntax of \loadModule I
> would prefer shorter and less redundant names.
> \loadModule snippets.lyrics.align-on-vowels
> is more convenient and expressive than
> \loadModule snippets.notation-snippets.align-lyrics-on-vowels
> etc.
> The question is:
> How many people are actually using the snippets repository, and how much
> inconvenience would that be for these people. I *can* take some care
> about "deprecating" and redirecting includes, but doing this generally
> would actually make the whole thing totally convoluted. So actually I"d
> prefer a clean cut and starting over with a new and cleaner structure.
> Opinions? Objections?
> Urs
> Am 06.07.2017 um 18:17 schrieb Urs Liska:
>> Hi all,
>>
>> I"m wrapping up a number of things in openLilyLib, and I came across
>> snippets where the example files don"t compile (with LilyPond 2.19.60).
>> Please go through this list and if you feel responsible for the snippet
>> please have a look:
>>
>> * notation-snippets/align-lyrics-on-vowels
>> (warning: ignored infinite X-offset)
>> * notation-snippets/alternating-time-signatures
>> (well, that"s me, I"ll keep it as a reference)
>> * notation-snippets/blackmensural-notation
>> * notation-snippets.lyric-syllable-magnetic-snap
>> * notation-snippets.metric-mod
>> * notation-snippets.scale-vertical-spacing
>> * notation-snippets/shaping-bezier-curves/slur-attachments-example.ly
>>
>> * editorial-tools/git-commands
>> (me again)
>> * input-shorthands/easy-octaves
>> * specific-solutions/xelatex-markup-list
>> * templates/predefined-instruments
>>
>> * notation-snippets.scaling-stencils
>> Is this a snippet or an example?
>>
>> * is input-shorthands/sizeContext still necessary or has this been
>> included in Lilypond in the meantime?
>>
>>
>> Maybe this isn"t all that has to be done, I also realized that this
>> repository is very inconsistent in style and quality. However, I want
>> the snippets repository to become a member of the openLilyLib package
>> family, which means that - in addition to the existing style of
>> including the "definitions.ily" files of a directory the stuff can be
>> loaded as "modules".
>>
>> Currently this relies on snippets on the "make-modules" branch and
>> oll-core on the "config" branch, but I intend to merge both in the next
>> days.
>>
>> This will result in input code like for example
>>
>> \include "oll-core/package.ily"
>> \loadPackage page-layout
>> \loadPackage \with {
>> modules = arrows.frames
>> }
>> analysis
>> \loadModule snippets.notation-snippets.compound-slurs
>> \loadModules snippets
>> #"((notation-snippets compound-slurs)
>> (input-shorthands easy-custom-dynamics))
>>
>> An overview of this mechanism can be found on
>> https://github.com/openlilylib/oll-core/wiki
>>
>> Going through most of the directory structure made me realize that I
>> would really like to move and rename many modules. For example
>> "easy-custom-dynamics" should not be accessible through
>> snippets.input-shorthands.easy-custom-dynamics
>> but through
>> snippets.notation.custom-dynamics
>> Also there are many verbose directory names that should be shortened:
>> snippets.notation-snippets => snippets.notation etc.
>>
>> The problem is that such a reorganization and renaming would of course
>> break lots of existing files ...
>>
>> Best for now
>> Urs
>>
> --
> u...@openlilylib.org
> https://openlilylib.org
> http://lilypondblog.org
> ___
> lilypond-user mailing list
> lilypond-user@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-user___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: OLL/snippets renaming (Re: Broken (?) snippets in openlilylib/snippets)
On 07/11/2017 10:35 AM, Urs Liska wrote:
I would like to rename some directories and move some snippets. In
particular the "notation-snippets" and the "input-shorthands" seem
somewhat blurred to me. And, with the nicer syntax of \loadModule I
would prefer shorter and less redundant names.
\loadModule snippets.lyrics.align-on-vowels
is more convenient and expressive than
\loadModule snippets.notation-snippets.align-lyrics-on-vowels
etc.
The question is:
How many people are actually using the snippets repository, and how much
inconvenience would that be for these people. I *can* take some care
about "deprecating" and redirecting includes, but doing this generally
would actually make the whole thing totally convoluted. So actually I'd
prefer a clean cut and starting over with a new and cleaner structure.
Opinions? Objections?
No objections here. Seems like a job for some kind of versioning or
renaming of the snippets collection as a whole? ("snippets2"?) Then you
could preserve backwards compatibility and get your clean break.
Or... this may not be helpful... but would it work to just move the
contents of snippets out into their own modules, deprecating the
"snippets" grouping, but leaving it in place, as is, for now for
backwards compatibility? So then you'd have, say:
\loadModule lyrics.align-on-vowels
Not sure what the larger repercussions of this would be, as I haven't kept up
with how things are organized. Feel free to disregard.
-Paul
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: OLL/snippets renaming (Re: Broken (?) snippets in openlilylib/snippets)
On 11.07.2017 16:35, Urs Liska wrote: So actually I'd prefer a clean cut and starting over with a new and cleaner structure. +1 for that :-) Best, Simon ___ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
OLL/snippets renaming (Re: Broken (?) snippets in openlilylib/snippets)
Hi all,
by now I've fixed a number of the below issues and created a few items
on the issue tracker for the remaining ones.
Right now I'm wrapping things up a little bit, and part of this is an
urge to restructure the repository somewhat. In the beginning of the
repository there was no proper strategy for a directory structure,
basically whenever someone didn't immediately know where to put a new
snippet they decided to create a new directory ;-)
I would like to rename some directories and move some snippets. In
particular the "notation-snippets" and the "input-shorthands" seem
somewhat blurred to me. And, with the nicer syntax of \loadModule I
would prefer shorter and less redundant names.
\loadModule snippets.lyrics.align-on-vowels
is more convenient and expressive than
\loadModule snippets.notation-snippets.align-lyrics-on-vowels
etc.
The question is:
How many people are actually using the snippets repository, and how much
inconvenience would that be for these people. I *can* take some care
about "deprecating" and redirecting includes, but doing this generally
would actually make the whole thing totally convoluted. So actually I'd
prefer a clean cut and starting over with a new and cleaner structure.
Opinions? Objections?
Urs
Am 06.07.2017 um 18:17 schrieb Urs Liska:
> Hi all,
>
> I'm wrapping up a number of things in openLilyLib, and I came across
> snippets where the example files don't compile (with LilyPond 2.19.60).
> Please go through this list and if you feel responsible for the snippet
> please have a look:
>
> * notation-snippets/align-lyrics-on-vowels
> (warning: ignored infinite X-offset)
> * notation-snippets/alternating-time-signatures
> (well, that's me, I'll keep it as a reference)
> * notation-snippets/blackmensural-notation
> * notation-snippets.lyric-syllable-magnetic-snap
> * notation-snippets.metric-mod
> * notation-snippets.scale-vertical-spacing
> * notation-snippets/shaping-bezier-curves/slur-attachments-example.ly
>
> * editorial-tools/git-commands
> (me again)
> * input-shorthands/easy-octaves
> * specific-solutions/xelatex-markup-list
> * templates/predefined-instruments
>
> * notation-snippets.scaling-stencils
> Is this a snippet or an example?
>
> * is input-shorthands/sizeContext still necessary or has this been
> included in Lilypond in the meantime?
>
>
> Maybe this isn't all that has to be done, I also realized that this
> repository is very inconsistent in style and quality. However, I want
> the snippets repository to become a member of the openLilyLib package
> family, which means that - in addition to the existing style of
> including the "definitions.ily" files of a directory the stuff can be
> loaded as "modules".
>
> Currently this relies on snippets on the "make-modules" branch and
> oll-core on the "config" branch, but I intend to merge both in the next
> days.
>
> This will result in input code like for example
>
> \include "oll-core/package.ily"
> \loadPackage page-layout
> \loadPackage \with {
> modules = arrows.frames
> }
> analysis
> \loadModule snippets.notation-snippets.compound-slurs
> \loadModules snippets
> #'((notation-snippets compound-slurs)
> (input-shorthands easy-custom-dynamics))
>
> An overview of this mechanism can be found on
> https://github.com/openlilylib/oll-core/wiki
>
> Going through most of the directory structure made me realize that I
> would really like to move and rename many modules. For example
> "easy-custom-dynamics" should not be accessible through
> snippets.input-shorthands.easy-custom-dynamics
> but through
> snippets.notation.custom-dynamics
> Also there are many verbose directory names that should be shortened:
> snippets.notation-snippets => snippets.notation etc.
>
> The problem is that such a reorganization and renaming would of course
> break lots of existing files ...
>
> Best for now
> Urs
>
--
u...@openlilylib.org
https://openlilylib.org
http://lilypondblog.org
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: Broken (?) snippets in openlilylib/snippets
On Mon, 2017-07-10 at 14:02 +0200, Urs Liska wrote: > > Am 06.07.2017 um 20:37 schrieb Graham King: > > On Thu, 2017-07-06 at 18:17 +0200, Urs Liska wrote: > >> Hi all, > >> > >> I'm wrapping up a number of things in openLilyLib, and I came across > >> snippets where the example files don't compile (with LilyPond 2.19.60). > >> Please go through this list and if you feel responsible for the snippet > >> please have a look: > >> > >> * notation-snippets/blackmensural-notation > > This one is just a copy of Lukas Pietch's code from January 2011 that I > > was trying to get to work with a recent lilypond. The files have been > > completely superseded by Lukas' more recent work and may safely be > > deleted. > > > > Alas, the more recent version doesn't work either (there is a missing > > file). Full details at > > https://lists.gnu.org/archive/html/lilypond-user/2016-05/msg00212.html > > Sorry, I'm not really sure what to think of these two seemingly > contradictory statements. Is it now working *anywhere*? Can I remove the > snippet from the repository? > What exactly should I do? Sorry if I was unclear. The snippet in your repository should be removed, in my opinion. For lilypond-user's information only: There is a more recent version, at a URL in the message to which I referred; however, until we find/re-invent its missing file, I don't see any point in including it in openlilylib. -- Graham ___ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
align-lyrics-on-vowels Re: Broken (?) snippets in openlilylib/snippets
I should have looked somewhat more closely at the output: Am 06.07.2017 um 18:17 schrieb Urs Liska: > * notation-snippets/align-lyrics-on-vowels > (warning: ignored infinite X-offset) fails with the following message: lilypond: /home/gub/NewGub/gub/target/linux-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/skyline.cc:198 <19>: void Skyline::normalize(): Assertion `buildings_.front ().start_ == -infinity_f' failed. Exited with return code 6. which is somewhat strange as I ran LilyPond 2.19.60 from a binary release. Any further ideas? How is this related to any other current development with lyrics? Urs -- u...@openlilylib.org https://openlilylib.org http://lilypondblog.org ___ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: Broken (?) snippets in openlilylib/snippets
Am 06.07.2017 um 20:37 schrieb Graham King: > On Thu, 2017-07-06 at 18:17 +0200, Urs Liska wrote: >> Hi all, >> >> I'm wrapping up a number of things in openLilyLib, and I came across >> snippets where the example files don't compile (with LilyPond 2.19.60). >> Please go through this list and if you feel responsible for the snippet >> please have a look: >> >> * notation-snippets/blackmensural-notation > This one is just a copy of Lukas Pietch's code from January 2011 that I > was trying to get to work with a recent lilypond. The files have been > completely superseded by Lukas' more recent work and may safely be > deleted. > > Alas, the more recent version doesn't work either (there is a missing > file). Full details at > https://lists.gnu.org/archive/html/lilypond-user/2016-05/msg00212.html Sorry, I'm not really sure what to think of these two seemingly contradictory statements. Is it now working *anywhere*? Can I remove the snippet from the repository? What exactly should I do? Urs > > -- Graham > > > ___ > lilypond-user mailing list > lilypond-user@gnu.org > https://lists.gnu.org/mailman/listinfo/lilypond-user -- u...@openlilylib.org https://openlilylib.org http://lilypondblog.org ___ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: Broken (?) snippets in openlilylib/snippets
Am 08.07.2017 um 20:21 schrieb Paul: > > On 07/08/2017 02:03 PM, Paul wrote: > >> This fixes the snippet on LilyPond 2.19.41 (The most recent I have >> installed.) > > Just installed LilyPond 2.19.63 and my fixed vertical spacing snippet > works fine with it. > > I realized that you (Urs) may have another approach in mind for > detecting lilypond versions... I don't really use OLL as a whole... > so my previous email just had a fix for the standalone file for this > snippet... > Thanks. I took this as an opportunity to fix the broken handling of version predicates in the snippets repo. Now the "old" OLL functions (lilypond-greater-than? etc.) and the backported ly:version? are present in general-tools/lilypond-version-predicates. Both work, but the old ones produce a warning. I've updated your snippet, and made it a module in https://github.com/openlilylib/snippets/commit/bf7e829077d707da89e3d9eec0fd36817ce17bfb https://github.com/openlilylib/snippets/commit/1ed2958b04ea75177c30d7146a65f6d458fe52a5 https://github.com/openlilylib/snippets/commit/ee2e83c423edeb64a7e387388a772a9052756af9 Best Urs ___ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: Broken (?) snippets in openlilylib/snippets
On 07/08/2017 02:03 PM, Paul wrote: This fixes the snippet on LilyPond 2.19.41 (The most recent I have installed.) Just installed LilyPond 2.19.63 and my fixed vertical spacing snippet works fine with it. I realized that you (Urs) may have another approach in mind for detecting lilypond versions... I don't really use OLL as a whole... so my previous email just had a fix for the standalone file for this snippet... -Paul ___ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: Broken (?) snippets in openlilylib/snippets
On 07/06/2017 12:17 PM, Urs Liska wrote:
* notation-snippets.scale-vertical-spacing
This one is mine.
https://github.com/openlilylib/snippets/tree/master/notation-snippets/scale-vertical-spacing
Here is the problematic line 90 in definitions.ily:
(paper (if (lilypond-less-than? "2.19.22")
It can be fixed by replacing it with:
(paper (if (ly:version? < '(2 19 22))
and adding these two shims at the top of the file:
% borrowed from scm/lily-library.scm (added in LilyPond 2.19.57)
% can be removed when support for 2.18 is dropped
#(if (not (defined? 'lexicographic-list-compare?))
(define (lexicographic-list-compare? op a b)
"Lexicographically compare two lists @var{a} and @var{b} using
the operator @var{op}. The types of the list elements have to
be comparable with @var{op}. If the lists are of different length
the trailing elements of the longer list are ignored."
(let* ((ca (car a))
(iseql (op ca ca)))
(let loop ((ca ca) (cb (car b)) (a (cdr a)) (b (cdr b)))
(let ((axb (op ca cb)))
(if (and (pair? a) (pair? b)
(eq? axb iseql (op cb ca)))
(loop (car a) (car b) (cdr a) (cdr b))
axb))
#(if (not (defined? 'ly:version?))
(define (ly:version? op ver)
"Using the operator @var{op} compare the currently executed LilyPond
version with a given version @var{ver} which is passed as a list of
numbers."
(lexicographic-list-compare? op (ly:version) ver)))
This fixes the snippet on LilyPond 2.19.41 (The most recent I have
installed.)
Should I make a new branch and do a pull request for these changes, or...?
Cheers,
-Paul
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: Broken (?) snippets in openlilylib/snippets
On Thu, 2017-07-06 at 18:17 +0200, Urs Liska wrote: > Hi all, > > I'm wrapping up a number of things in openLilyLib, and I came across > snippets where the example files don't compile (with LilyPond 2.19.60). > Please go through this list and if you feel responsible for the snippet > please have a look: > > * notation-snippets/blackmensural-notation This one is just a copy of Lukas Pietch's code from January 2011 that I was trying to get to work with a recent lilypond. The files have been completely superseded by Lukas' more recent work and may safely be deleted. Alas, the more recent version doesn't work either (there is a missing file). Full details at https://lists.gnu.org/archive/html/lilypond-user/2016-05/msg00212.html -- Graham ___ lilypond-user mailing list lilypond-user@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-user
Re: Broken (?) snippets in openlilylib/snippets
One more thing: I realize that there are quite a lot open branches in
the repo (from numerous contributors), which may cause an additional set
of hiccups. So these should be considered as well ...
Am 06.07.2017 um 18:17 schrieb Urs Liska:
> Hi all,
>
> I'm wrapping up a number of things in openLilyLib, and I came across
> snippets where the example files don't compile (with LilyPond 2.19.60).
> Please go through this list and if you feel responsible for the snippet
> please have a look:
>
> * notation-snippets/align-lyrics-on-vowels
> (warning: ignored infinite X-offset)
> * notation-snippets/alternating-time-signatures
> (well, that's me, I'll keep it as a reference)
> * notation-snippets/blackmensural-notation
> * notation-snippets.lyric-syllable-magnetic-snap
> * notation-snippets.metric-mod
> * notation-snippets.scale-vertical-spacing
> * notation-snippets/shaping-bezier-curves/slur-attachments-example.ly
>
> * editorial-tools/git-commands
> (me again)
> * input-shorthands/easy-octaves
> * specific-solutions/xelatex-markup-list
> * templates/predefined-instruments
>
> * notation-snippets.scaling-stencils
> Is this a snippet or an example?
>
> * is input-shorthands/sizeContext still necessary or has this been
> included in Lilypond in the meantime?
>
>
> Maybe this isn't all that has to be done, I also realized that this
> repository is very inconsistent in style and quality. However, I want
> the snippets repository to become a member of the openLilyLib package
> family, which means that - in addition to the existing style of
> including the "definitions.ily" files of a directory the stuff can be
> loaded as "modules".
>
> Currently this relies on snippets on the "make-modules" branch and
> oll-core on the "config" branch, but I intend to merge both in the next
> days.
>
> This will result in input code like for example
>
> \include "oll-core/package.ily"
> \loadPackage page-layout
> \loadPackage \with {
> modules = arrows.frames
> }
> analysis
> \loadModule snippets.notation-snippets.compound-slurs
> \loadModules snippets
> #'((notation-snippets compound-slurs)
> (input-shorthands easy-custom-dynamics))
>
> An overview of this mechanism can be found on
> https://github.com/openlilylib/oll-core/wiki
>
> Going through most of the directory structure made me realize that I
> would really like to move and rename many modules. For example
> "easy-custom-dynamics" should not be accessible through
> snippets.input-shorthands.easy-custom-dynamics
> but through
> snippets.notation.custom-dynamics
> Also there are many verbose directory names that should be shortened:
> snippets.notation-snippets => snippets.notation etc.
>
> The problem is that such a reorganization and renaming would of course
> break lots of existing files ...
>
> Best for now
> Urs
>
--
u...@openlilylib.org
https://openlilylib.org
http://lilypondblog.org
___
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user
