Re: [PATCH V2 2/3] arm/dt: add very basic dts file for babbage board

2011-03-15 Thread Grant Likely
On Tue, Mar 08, 2011 at 11:46:47AM +0800, Shawn Guo wrote: On Tue, Mar 08, 2011 at 11:31:07AM +0800, Jason Hui wrote: Hi, Shawn, On Tue, Mar 8, 2011 at 11:11 AM, Shawn Guo shawn@freescale.com wrote: On Tue, Mar 08, 2011 at 10:20:33AM +0800, Jason Hui wrote: Hi, Shawn, On

Re: [PATCH V4 3/5] serial/imx: parse from device tree support

2011-03-15 Thread Grant Likely
Minor comments, but otherwise goes first. On Thu, Mar 10, 2011 at 12:59:43PM +0800, Jason Liu wrote: Signed-off-by: Jason Liu jason@linaro.org Signed-off-by: Jason Liu r64...@freescale.com Signed-off-by: Jeremy Kerr jeremy.k...@canonical.com Jeremy's s-o-b should go at the top of the

Re: [PATCH V4 4/5] net/fec: check id_entry pointer before using it

2011-03-15 Thread Grant Likely
On Thu, Mar 10, 2011 at 12:59:44PM +0800, Jason Liu wrote: The id_entry will possibly be NULL, So, need check id_entry and make sure it not NULL before using it. Signed-off-by: Jason Liu jason@linaro.org Signed-off-by: Jason Liu r64...@freescale.com Other than the double s-o-b lines,

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Grant Likely
On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: On Mon, Mar 07, 2011 at 10:53:37AM -0700, Grant Likely wrote: On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo shawn@linaro.org wrote: The 'rate' is added for fixed-clock support, while 'pll_base' is for pll clock.  These two

Re: [PATCH 3/5] arm/dt: mx51: dynamically add clocks per dt nodes

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 09:18:40PM +0800, Shawn Guo wrote: This patch is to change the static clock creating and registering to the dynamic way, which scans dt clock nodes, associate clk with device_node, and then add them to clkdev accordingly. It's a pretty straight translation from non-dt

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Shawn Guo
On Tue, Mar 15, 2011 at 01:41:01AM -0600, Grant Likely wrote: On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: On Mon, Mar 07, 2011 at 10:53:37AM -0700, Grant Likely wrote: On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo shawn@linaro.org wrote: The 'rate' is added for fixed-clock

Re: [PATCH 5/5] of/clock: eliminate function __of_clk_get_from_provider

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 09:18:42PM +0800, Shawn Guo wrote: With the platform clock support, the 'struct clk' should have been associated with device_node-data. So the use of function __of_clk_get_from_provider can be eliminated. Signed-off-by: Shawn Guo shawn@linaro.org ---

Re: [PATCH 5/5] of/clock: eliminate function __of_clk_get_from_provider

2011-03-15 Thread Shawn Guo
On Tue, Mar 15, 2011 at 01:54:05AM -0600, Grant Likely wrote: On Mon, Mar 14, 2011 at 09:18:42PM +0800, Shawn Guo wrote: With the platform clock support, the 'struct clk' should have been associated with device_node-data. So the use of function __of_clk_get_from_provider can be eliminated.

Re: [PATCH 3/7] mmc: make the reference to sdhci_tegra_dt_pdata conditional

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 10:25:55PM +0800, Shawn Guo wrote: Wrap tegra dt_id with CONFIG_MMC_SDHCI_TEGRA to make the reference to sdhci_tegra_dt_pdata conditional, otherwise it will stop build for other mmc driver when OF is enabled. Signed-off-by: Shawn Guo shawn@linaro.org Looks right

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Grant Likely
On Tue, Mar 15, 2011 at 03:50:29PM +0800, Shawn Guo wrote: On Tue, Mar 15, 2011 at 01:41:01AM -0600, Grant Likely wrote: On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: On Mon, Mar 07, 2011 at 10:53:37AM -0700, Grant Likely wrote: On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo

Re: [PATCH 5/5] of/clock: eliminate function __of_clk_get_from_provider

2011-03-15 Thread Grant Likely
On Tue, Mar 15, 2011 at 03:59:16PM +0800, Shawn Guo wrote: On Tue, Mar 15, 2011 at 01:54:05AM -0600, Grant Likely wrote: On Mon, Mar 14, 2011 at 09:18:42PM +0800, Shawn Guo wrote: With the platform clock support, the 'struct clk' should have been associated with device_node-data. So the

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Shawn Guo
On Tue, Mar 15, 2011 at 02:02:56AM -0600, Grant Likely wrote: On Tue, Mar 15, 2011 at 03:50:29PM +0800, Shawn Guo wrote: On Tue, Mar 15, 2011 at 01:41:01AM -0600, Grant Likely wrote: On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: On Mon, Mar 07, 2011 at 10:53:37AM -0700,

Re: [PATCH 2/2 android/device/linaro/common] mount mmc partitions instead of mtd partitions

2011-03-15 Thread Alexander Sack
On Mon, Mar 14, 2011 at 3:37 PM, Jeremy Chang jeremy.ch...@linaro.org wrote: All partitions from mmc is expected. This depends on Jim Huang's patch init: support mmc device mount in android/system/core to work. Signed-off-by: Jeremy Chang jeremy.ch...@linaro.org ---  init.rc |   12

Re: [PATCH 2/2 android/device/linaro/common] mount mmc partitions instead of mtd partitions

2011-03-15 Thread Jim Huang
On 15 March 2011 16:29, Alexander Sack a...@linaro.org wrote: On Mon, Mar 14, 2011 at 3:37 PM, Jeremy Chang jeremy.ch...@linaro.org wrote: All partitions from mmc is expected. This depends on Jim Huang's patch init: support mmc device mount in android/system/core to work. what happened with

Re: [PATCH] [android/devices/linaro/common] Correct permission, owner and group on files in the root tarball

2011-03-15 Thread Alexander Sack
would be great to have a more verbose git comment as of why we are doing this. e.g. what was the problem and what was the solution. also why do we need to have a copy of mktarball.sh rather than fixing that one directly. On Fri, Mar 11, 2011 at 4:05 PM, Patrik Ryd patrik@linaro.org wrote:

Re: [PATCH] arm/dt: Add dtb make rule

2011-03-15 Thread Jason Liu
2011/3/15 Rob Herring robherri...@gmail.com: Grant, On 03/10/2011 01:46 PM, Rob Herring wrote: From: Rob Herringrob.herr...@calxeda.com Add a make rule to compile dt blobs for ARM. Signed-off-by: Rob Herringrob.herr...@calxeda.com Can you pick this one up in your ARM tree. Test result

Getting rid of update-alternative in cross toolchain packages

2011-03-15 Thread Marcin Juszkiewicz
Some time ago I looked at cross toolchain packages to find how they handle installation of several versions at same time. It was done by using 'update-alternatives' tool and was broken. We fixed it during Ubuntu/Maverick cycle but u-a is still in use (just versions are used now to take care of

Re: [PATCH] [android/devices/linaro/common] Correct permission, owner and group on files in the root tarball

2011-03-15 Thread Patrik Ryd
On 15 March 2011 12:28, Alexander Sack a...@linaro.org wrote: would be great to have a more verbose git comment as of why we are doing this. e.g. what was the problem and what was the solution. also why do we need to have a copy of mktarball.sh rather than fixing that one directly. This

Re: [PATCH] [android/devices/linaro/common] Correct permission, owner and group on files in the root tarball

2011-03-15 Thread Alexander Sack
On Tue, Mar 15, 2011 at 2:35 PM, Patrik Ryd patrik@linaro.org wrote: On 15 March 2011 12:28, Alexander Sack a...@linaro.org wrote: would be great to have a more verbose git comment as of why we are doing this. e.g. what was the problem and what was the solution. also why do we need to

Re: LAVA integration effort for Android validation

2011-03-15 Thread Paul Larson
On Mon, Mar 14, 2011 at 11:22 AM, Jeremy Chang jeremy.ch...@linaro.orgwrote: Hi, list: I am working on Validation part for Android, in which mainly inclusive of integrating existing benchmark and testing suites into abrek, like 0xbench and android CTS. For now in my thought, if these

Re: gcc: Thumb interworking and weakly linked functions

2011-03-15 Thread Ulrich Weigand
Aneesh V ane...@ti.com wrote: I was trying to build u-boot in Thumb2 for OMAP4. Everything was fine until I added some patches recently. One of these patches introduced an API (let's say foo()) that has a weakly linked alias(let's say __foo()) and a strongly linked implementation(the real

Re: LAVA integration effort for Android validation

2011-03-15 Thread Alexander Sack
On Tue, Mar 15, 2011 at 4:09 PM, Paul Larson paul.lar...@linaro.org wrote: On Mon, Mar 14, 2011 at 11:22 AM, Jeremy Chang jeremy.ch...@linaro.org wrote: Hi, list:    I am working on Validation part for Android, in which mainly inclusive of integrating existing benchmark and testing suites

Re: Yet another memory provider: can linaro organize a meeting?

2011-03-15 Thread Robert Fekete
On 8 March 2011 20:23, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Andy, On Tuesday 08 March 2011 20:12:45 Andy Walls wrote: On Tue, 2011-03-08 at 16:52 +0100, Laurent Pinchart wrote: [snip] It really shouldn't be that hard to get everyone involved together and

Re: Getting rid of update-alternative in cross toolchain packages

2011-03-15 Thread Steve Langasek
On Tue, Mar 15, 2011 at 01:00:04PM +0100, Marcin Juszkiewicz wrote: Some time ago I looked at cross toolchain packages to find how they handle installation of several versions at same time. It was done by using 'update-alternatives' tool and was broken. We fixed it during Ubuntu/Maverick cycle

Re: Yet another memory provider: can linaro organize a meeting?

2011-03-15 Thread Jesse Barker
On Tue, Mar 15, 2011 at 9:07 AM, Robert Fekete robert.fek...@linaro.orgwrote: On 8 March 2011 20:23, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Andy, On Tuesday 08 March 2011 20:12:45 Andy Walls wrote: On Tue, 2011-03-08 at 16:52 +0100, Laurent Pinchart wrote:

Re: Yet another memory provider: can linaro organize a meeting?

2011-03-15 Thread Alex Deucher
On Tue, Mar 15, 2011 at 12:07 PM, Robert Fekete robert.fek...@linaro.org wrote: On 8 March 2011 20:23, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Andy, On Tuesday 08 March 2011 20:12:45 Andy Walls wrote: On Tue, 2011-03-08 at 16:52 +0100, Laurent Pinchart wrote: [snip]

Re: [PATCH 4/7] mmc: consolidate sdhci_pltfm_data and sdhci_of_data into one

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 10:25:56PM +0800, Shawn Guo wrote: This patch is motivated by the work of supporting sdhci-esdhc-imx as an OF device. The sdhci-esdhc-imx driver was well designed to be able to work with either platform or OF bus, with a little effort to decouple the driver from

Re: [PATCH 5/7] mmc: support sdhci-esdhc-imx as an OF device

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 10:25:57PM +0800, Shawn Guo wrote: Signed-off-by: Shawn Guo shawn@linaro.org dt support can be added directly to sdchi-pltfm.c drivers now. There is no longer any need to use sdhci-of-core.c any more. For an example, see the patch titled of/tegra: add sdhci device

Re: Better reviews for the same cost in gcc-linaro

2011-03-15 Thread Michael Hope
On Tue, Mar 15, 2011 at 11:53 PM, Andrew Stubbs andrew.stu...@linaro.org wrote: Richard may know all this, but I'm just going to post anyway in case some people reading can benefit from some tips. I find that bzr is slow - there's no getting around it, but there are some tricks that can help.

Re: linaro android build system issues

2011-03-15 Thread Michael Hudson-Doyle
On Fri, 11 Mar 2011 17:23:45 +1300, Michael Hudson-Doyle michael.hud...@linaro.org wrote: Hi all, For some reason the jenkins instance that powers the android build system isn't auto provisioning slaves from ec2, so builds are being queued but not executed. If you notice this happen and

Re: Better reviews for the same cost in gcc-linaro

2011-03-15 Thread Martin Pool
On 15 March 2011 22:44, Loïc Minier loic.min...@linaro.org wrote:   7) merge to trunk (with the inevitable ChangeLog merge failure      that you mentioned).  bzr has plugins to merge changelog entries for some types of  changelogs; I wonder whether we could use these here.  Another option  

Re: [PATCH V4 3/5] serial/imx: parse from device tree support

2011-03-15 Thread Jason Hui
Hi, Grant, On Tue, Mar 15, 2011 at 3:07 PM, Grant Likely grant.lik...@secretlab.ca wrote: Minor comments, but otherwise goes first. On Thu, Mar 10, 2011 at 12:59:43PM +0800, Jason Liu wrote: Signed-off-by: Jason Liu jason@linaro.org Signed-off-by: Jason Liu r64...@freescale.com

Re: [PATCH V4 5/5] net/fec: add device tree matching support

2011-03-15 Thread Jason Hui
Hi, Grant, On Tue, Mar 15, 2011 at 3:14 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, Mar 10, 2011 at 12:59:45PM +0800, Jason Liu wrote: Signed-off-by: Jason Liu jason@linaro.org Signed-off-by: Jason Liu r64...@freescale.com ---  drivers/net/fec.c |   13 +  1

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Jason Hui
Hi, Grant, On Tue, Mar 15, 2011 at 3:03 PM, Grant Likely grant.lik...@secretlab.ca wrote: Hi Jason, Minor comments below. On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: Signed-off-by: Jason Liu jason@linaro.org Signed-off-by: Jason Liu r64...@freescale.com This looks

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Grant Likely
On Tue, Mar 15, 2011 at 9:34 PM, Jason Hui jason@linaro.org wrote: Hi, Grant, On Tue, Mar 15, 2011 at 3:03 PM, Grant Likely grant.lik...@secretlab.ca wrote: Hi Jason, Minor comments below. On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: Signed-off-by: Jason Liu

Re: LAVA integration effort for Android validation

2011-03-15 Thread Sachin Kamat
On 16 March 2011 10:03, Michael Hudson-Doyle michael.hud...@canonical.comwrote: On Tue, 15 Mar 2011 11:17:14 -0500, Paul Larson paul.lar...@linaro.org wrote: I like statically IP. How do we know which board would get which IP? One idea would be to set up a DNS for internal board names.

[PATCH-Android] [android/libcore] Disable Werror option to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I2c4699686ada362b43b836ace61636fc000720d3 --- NativeCode.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/NativeCode.mk b/NativeCode.mk index 4c6ffa5..7b56aef 100644 --- a/NativeCode.mk +++

[PATCH-Android] [android/external/elfcopy] Modified to eliminate build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I01286388a1bef915cb06adae862d9f3a0397b059 --- elfcopy.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/elfcopy.c b/elfcopy.c index ed1e6ce..da054c7 100644 --- a/elfcopy.c +++ b/elfcopy.c @@ -2456,7 +2456,6

[PATCH-Android] [android/frameworks/opt/emoji] Disable Werror option to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I61a9d5c9b5aef8358a04d0e1ac8964f905f0970a --- Android.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Android.mk b/Android.mk index 331d794..181f115 100644 --- a/Android.mk +++ b/Android.mk @@ -32,7

[PATCH-Android] [android/frameworks/base] Modified to eliminate build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: Id31f863427cd3a7d5d5abced71de78a76ae3d028 --- libs/utils/RefBase.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libs/utils/RefBase.cpp b/libs/utils/RefBase.cpp index 0bd1af4..d28b751 100644 ---

[PATCH-Android] Patches to build Android using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Hi, The next set of patches will help in building Android source code out of the box using Linaro GCC 4.5/4.6 toolchains. The patches basically try to circumvent the build problem caused by stricter GCC 4.5/4.6. These patches are based on remotes/m/linaro_android_2.3.2 branch. Regards, Sachin

[PATCH-Android] [android/external/webkit] Modified to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I2cd4ccdf7edc39b025ef39bd5db0154c616aa5a9 --- WebKit/android/nav/FindCanvas.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/WebKit/android/nav/FindCanvas.cpp b/WebKit/android/nav/FindCanvas.cpp index

[PATCH-Android] [android/system/media] File renamed to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I39652f14b362c42ebc2ceb37952d8e57cf89692c --- opensles/libopensles/Android.mk |2 +- opensles/libopensles/IAndroidEffect.c | 130 --- opensles/libopensles/IAndroidEffect.cpp | 130

[PATCH-Android] [android/build] Disable Werror option to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I471e831d569b37345752d788f5a213ffd6616690 --- core/config.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/core/config.mk b/core/config.mk index a76aec8..45100fb 100644 --- a/core/config.mk +++

Re: [PATCH-Android] [android/system/media] File renamed to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Jassi Brar
On Wed, Mar 16, 2011 at 10:46 AM, Sachin Kamat sachin.ka...@linaro.org wrote:  Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I39652f14b362c42ebc2ceb37952d8e57cf89692c ---  opensles/libopensles/Android.mk         |    2 +-  opensles/libopensles/IAndroidEffect.c   |  130

Re: [PATCH-Android] [android/system/media] File renamed to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Thanks Jassi.. Resending the patch (created using -M) Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Change-Id: I39652f14b362c42ebc2ceb37952d8e57cf89692c --- opensles/libopensles/Android.mk|2 +- .../{IAndroidEffect.c =