[PATCH 2/6] Remove utils/utils_sanity.sh

2019-01-11 Thread Luis Machado
This sanity check is a dummy one. It doesn't check anything at the moment, so deleting it seems to be appropriate. 2019-01-11 Luis Machado * utils/utils_sanity.sh: Remove. Signed-off-by: Luis Machado --- utils/utils_sanity.sh | 39 --- 1 file

[PATCH 4/6] Adjust compiler flag variables

2019-01-11 Thread Luis Machado
In order to pass additional compiler flags while still keeping the required flags intact (-pthread for example), we add a local set of flags on top of the exsiting CFLAGS. 2019-01-11 Luis Machado * Test.mk (CFLAGS): Set to "-g -Wall" (FLAGS): New variable. Set t

[PATCH 0/6] Improve pm-qa's build system series

2019-01-11 Thread Luis Machado
Hi, For the sake of keeping things organized and easier to review, i've broken up the previous change into smaller pieces. Luis Machado (6): Make the default target only build the utils Remove utils/utils_sanity.sh Invoke scripts with sudo Adjust compiler flag variables Add install

[PATCH 6/6] Add missing phony targets

2019-01-11 Thread Luis Machado
The following patch adds some missing phony targets. 2019-01-11 Luis Machado * Makefile: New phony target list. * Test.mk: Likewise. Signed-off-by: Luis Machado --- Makefile | 2 ++ Test.mk | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Makefile b/Makefile index

[PATCH 1/6] Make the default target only build the utils

2019-01-11 Thread Luis Machado
The following patch adjusts the main Makefile and secondary Makefile (Test.mk) so the default target only builds the pm-qa utils from sources, without running the tests. Also document some variables and targets. 2018-01-11 Luis Machado * Makefile: Document target &quo

[PATCH 5/6] Add install target

2019-01-11 Thread Luis Machado
The following patch adds an install target so we can install the utils/scripts somewhere. The default prefix is /opt/pm-qa. 2019-01-11 Luis Machado * Makefile (prefix, SRC, EXEC, SUBDIRS, INSTALL_FILES): New variables. (install): New target. * README: Document install

[PATCH 3/6] Invoke scripts with sudo

2019-01-11 Thread Luis Machado
We were requiring the user to run the whole makefile as sudo. The following patch uses sudo to call the sanity check scripts and the functional tests only. 2019-01-11 Luis Machado * Test.mk: Invoke sanity tests and functional tests with sudo. Signed-off-by: Luis Machado

Re: [PATCH 0/6] Improve pm-qa's build system series

2019-01-14 Thread Luis Machado
Thanks Lisa! On 1/13/19 10:11 PM, Lisa Nguyen wrote: Hi Luis, On Fri, Jan 11, 2019 at 9:53 AM Luis Machado wrote: Hi, For the sake of keeping things organized and easier to review, i've broken up the previous change into smaller pieces. Luis Machado (6): Make the default target only

Re: [PATCH PM-QA v1] Android.mk: fix compiling errors caused by unused parameters

2019-04-29 Thread Luis Machado
Sorry for the delay, i was out on vacation and i'm back today. The change below looks OK to me. I'll track who's responsible for pm-qa and will get this through. On 4/16/19 1:05 AM, 阮正旺 wrote: Hi Luis, Can you help me review this patch? Kind Regards, Zhengwang  Original Message