Re: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume()

2008-02-20 Thread Alan Stern
-power.entry, dpm_locked); - mutex_unlock(dpm_list_mtx); break; } mutex_lock(dpm_list_mtx); Acked-by: Alan Stern [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message

Re: [linux-pm] [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance

2008-02-15 Thread Alan Stern
that the kobject is still registered, then you also know that there is already a reference to it. So you have no reason to take an additional reference. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-10 Thread Alan Stern
, then the routine should only be called directly or indirectly from a suspend or resume method or from the suspend or resume core. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: USB D3 vs system S3

2008-01-09 Thread Alan Stern
to change anything. The USB autosuspend code affects only the controller's USB interface -- it doesn't touch the PCI side. An autosuspended controller will remain in D0. Until somebody tries writing autosuspend code for PCI devices... Alan Stern - To unsubscribe from this list: send the line

Re: USB D3 vs system S3

2008-01-09 Thread Alan Stern
On Wed, 9 Jan 2008, Carlos Corbacho wrote: On Wednesday 09 January 2008 16:07:04 Alan Stern wrote: Currently there's no need to change anything. Ok. The USB autosuspend code affects only the controller's USB interface -- it doesn't touch the PCI side. An autosuspended controller

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-09 Thread Alan Stern
for destroy_suspended_device() should contain an extra paragraph warning that the routine should never be called except within the scope of a system sleep transition. In practice this means it has to be directly or indirectly invoked by a suspend or resume method. It looks good. Alan Stern

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-07 Thread Alan Stern
details. Once we have settled on the correct approach for 1-4, the implementation should be relatively easy. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-07 Thread Alan Stern
violation. With an asynchronous approach, on the other hand, this wouldn't be a problem. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-07 Thread Alan Stern
On Mon, 7 Jan 2008, Rafael J. Wysocki wrote: On Monday, 7 of January 2008, Alan Stern wrote: On Mon, 7 Jan 2008, Rafael J. Wysocki wrote: Please see the patch at: http://lkml.org/lkml/2008/1/6/298 . It represents my current idea about how to do that. It has some problems

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-07 Thread Alan Stern
leaning towards the asynchronous approach. I'll prepare a new patch and send it later today. Okay. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-06 Thread Alan Stern
are (1) messing up the PM device list pointers, and (2) calling a driver's suspend/resume methods while its remove method is running. (1) is handled by the pm_list_mutex and (2) is handled by locking dev-sem. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-06 Thread Alan Stern
wrong with it. All that will happen is that the removal will start before the suspend and finish after the resume. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-05 Thread Alan Stern
On Sat, 5 Jan 2008, Rafael J. Wysocki wrote: On Saturday, 5 of January 2008, Alan Stern wrote: On Sat, 5 Jan 2008, Rafael J. Wysocki wrote: Another thing to watch out for: Just in case somebody ends up calling destroy_suspended_device(dev) from within dev's own resume method, you

Re: [PATCH] PM: Acquire device locks on suspend

2008-01-05 Thread Alan Stern
On Sat, 5 Jan 2008, Rafael J. Wysocki wrote: On Saturday, 5 of January 2008, Alan Stern wrote: On Sat, 5 Jan 2008, Rafael J. Wysocki wrote: Still, even doing that is not enough, since someone can call destroy_suspended_device() from a .suspend() routine and then the device will end

Re: [PATCH 1/4] PM: Introduce destroy_suspended_device()

2008-01-04 Thread Alan Stern
to unregister_dropped_devices() in the error path of device_suspend() -- in theory even an aborted suspend might cause a device to malfunction. Otherwise this looks okay. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED

Re: [PATCH 1/4] PM: Introduce destroy_suspended_device()

2008-01-02 Thread Alan Stern
-pm-acquire-device-locks-prior-to-suspending.patch installed. That patch conflicts with this one. One of the these two patches will have to be rewritten to apply on top of the other. Which do you think should be changed? Alan Stern - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 0/3] PM: Do not destroy/create devices while suspended

2007-12-25 Thread Alan Stern
or after tasks leave the freezer? -- I'm not sure.) So the idea is send appropriate announcements at the usual time for CPUs that do come back up normally, and don't send anything right away for CPUs that fail to come up. Just keep track of which ones failed, and then later take care of them. Alan

Re: [PATCH 0/3] PM: Do not destroy/create devices while suspended

2007-12-24 Thread Alan Stern
it was beforehand? Is any special handling needed for this, or is it already accounted for? Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC][PATCH -mm] PM: Introduce set_target method in pm_ops

2007-06-23 Thread Alan Stern
, and when the call returns the system has already left that state. But with a low-performance On state, when the call returns the system will still be in the new state. Is the PM core prepared to handle this difference? Alan Stern - To unsubscribe from this list: send the line unsubscribe linux

Re: [RFC][PATCH -mm] PM: Introduce set_target method in pm_ops

2007-06-23 Thread Alan Stern
-performance run state? Or should that be handled automatically within the kernel? Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linux-pm] Re: [2.6.22-rc1-mm1] vaio laptop (SZ72B) immediately resumes after STR

2007-06-22 Thread Alan Stern
Restarting tasks... show this, and the last two lines show the root hub's interface being resumed. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linux-pm] Re: [2.6.22-rc1-mm1] vaio laptop (SZ72B) immediately resumes after STR

2007-06-22 Thread Alan Stern
would handle it already. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linux-pm] Re: [2.6.22-rc1-mm1] vaio laptop (SZ72B) immediately resumes after STR

2007-06-22 Thread Alan Stern
a user's point of view, I get the feeling that plug and unplug aren't useful wakeup events. But I may be wrong... and desktop users are likely to have different requirements from laptop users. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message

Re: [linux-pm] Re: [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help)

2007-06-21 Thread Alan Stern
the target state) that it can pass to the provider. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linux-pm] Re: [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help)

2007-06-21 Thread Alan Stern
-- and I think a cookie would be better than a struct. There are other possible ways to disseminate the information. The details don't matter much, and relatively few drivers would care. However the form of the information is a legitimate concern at this point. Alan Stern - To unsubscribe from

Re: [linux-pm] Re: [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help)

2007-06-21 Thread Alan Stern
On Thu, 21 Jun 2007, David Brownell wrote: On Thursday 21 June 2007, Alan Stern wrote: On Thu, 21 Jun 2007, David Brownell wrote: If a driver wants to find out whether some resource will be available in the target system state, the only way is to ask the resource's provider

Re: [linux-pm] Re: [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help)

2007-06-21 Thread Alan Stern
On Thu, 21 Jun 2007, Rafael J. Wysocki wrote: Does anyone have any objections to adding a new pm_op that will tell the ACPI core (or generally, a platform core code) what target system sleep state we are going to enter? Go for it! Alan Stern - To unsubscribe from this list: send the line

Re: [linux-pm] [RFD] How to tell ACPI drivers what the target sleep state is (was: Re: [PATCH 1/2] acpi choose sleep state help)

2007-06-20 Thread Alan Stern
or whether wakeup should be enabled? Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linux-pm] Re: [2.6.22-rc1-mm1] vaio laptop (SZ72B) immediately resumes after STR

2007-06-19 Thread Alan Stern
and immediate resume. To reduce the amount of clutter you might want to rmmod uhci-hcd before starting the test. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [linux-usb-devel] [Bugme-new] [Bug 8249] New: NMI watchdog detected LOCKUP when plugging USB devices with acpi=off

2007-03-22 Thread Alan Stern
try turning off the HAL daemon and renaming the usblp.ko file so that it won't get loaded automatically. Then after plugging in the printer you could insmod the renamed driver file by hand, and see whether that causes the oops. Then start HAL by hand and see whether that causes the oops. Alan Stern

Re: USB suspend/resume in linux

2006-10-13 Thread Alan Stern
really works on that. Would be nice if someone gives this a try... Alan Stern has been working on USB autosuspend for quite some time and there are some patches in -mm and in the recent mainline, AFAICT. Rafael is right. 2.6.19-rc1 already contains code that will suspend ports if the attached

RE: USB suspend/resume in linux

2006-10-13 Thread Alan Stern
another reason not to do this: Power Management Event handling for PCI devices isn't working. So the controller would not automatically go back into D0 when you plugged in a new USB device. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message

Re: [linux-pm] [BUG] sleeping function called from invalid context during resume

2006-07-10 Thread Alan Stern
be set to 0, so that the routine will call down_trylock() instead of down() or schedule_timeout_interruptible(). Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [linux-pm] [BUG] sleeping function called from invalid context during resume

2006-07-10 Thread Alan Stern
compile. Along with the other changes to include/acpi/platform/aclinux.h, you need to define acpi_size. The easiest way is to #include acpi/actypes.h and then remove the unneeded definitions of acpi_cpu_flags and acpi_thread_id. Alan Stern - To unsubscribe from this list: send the line unsubscribe

RE: [linux-pm] [BUG] sleeping function called from invalid context during resume

2006-07-10 Thread Alan Stern
in e-mail, or the one checked into git? My appologies if they don't match. I've compiled this into a few dozen kernels at this point. I was referring to the patch in the email. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message

RE: [linux-pm] [BUG] sleeping function called from invalid context during resume

2006-07-10 Thread Alan Stern
report. Let's continue further discussion there, off-list. Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [linux-pm] [BUG] sleeping function called from invalid context during resume

2006-07-07 Thread Alan Stern
on a patch for ACPI (a couple of routines that make blocking calls with interrupts disabled) and I'd like to know what to do with it. Should I just send it to Len and linux-acpi as is? Alan Stern - To unsubscribe from this list: send the line unsubscribe linux-acpi in the body of a message

Re: Help with Averatec C3500

2006-04-06 Thread Alan Stern
On Thu, 6 Apr 2006, Bjorn Helgaas wrote: Alan, could you give me a hint about what you mean? ACPI doesn't ioremap device registers, so I'm not sure what the problem is. After posting the above request to the linux-usb list, Alan Stern responded