On Mon, 25 Feb 2008, David Brownell wrote:
int __must_check sysfs_create_link(struct kobject *kobj, struct kobject
*target,
const char *name);
Perhaps you disabled those warnings. (And FWIW, I don't see any
reasonable way to handle such faults, so
On Mon, 25 Feb 2008, Rafael J. Wysocki wrote:
2.6.25-rc2-git7 has regression, thinkpad keys do not work any more.
Probably this commit broke things 6c231bd5eb07ce546517019f334652b9ecfc329a
This commit is indeed broken, and I have a tentative fix for it. But I'd
like to have a better
On Mon, 25 Feb 2008, Lukas Hejtmanek wrote:
On Mon, Feb 25, 2008 at 05:03:54PM -0300, Henrique de Moraes Holschuh wrote:
This commit is indeed broken, and I have a tentative fix for it. But I'd
like to have a better description of just how the thinkpad keys do not
work anymore, to make
On Mon, 25 Feb 2008, Lukas Hejtmanek wrote:
volume keys work. But anything through acpid does not. Even AC/battery switch
is not signalized. So the bug may be somewhere else?
Yeah, there is an EC-related regression in 2.6.25-rc3 that bites your
thinkpad. I don't have a link to it right now,
On Fri, 22 Feb 2008, Zhang, Rui wrote:
pwm[1-*]_enable = 1 : manual fan control (using pwm[1-*])
2+: automatic fan control (by acpi thermal driver)
And pwm[1-*]_enable = 0 should try to bump the fan to the fasted speed
possible, BTW. This is not very obvious :-)
Many hwmon
On Thu, 21 Feb 2008, Sergio Monteiro Basto wrote:
On Thu, 2008-02-21 at 00:13 -0300, Henrique de Moraes Holschuh wrote:
On Wed, 20 Feb 2008, Matthew Garrett wrote:
It doesn't punish them. They're the ones who are going to work with us
to ensure that Linux works on their hardware
On Wed, 20 Feb 2008, Tomas Carnecky wrote:
A lot has been discussed in linux-acpi, though mostly hidden in related
threads. Ask Henrique, he's been trying to come up with a proper _OSI()
interface. See for example this thread:
No, I haven't. Len is the mastermind behind it, AFAIK. I am
On Wed, 20 Feb 2008, Matthew Garrett wrote:
Let's look at this differently. Most hardware is produced by vendors who
don't care about Linux. We need to make that hardware work anyway. The
only way we can achieve that is to be bug-compatible with Windows.
Therefore, any way in which Linux
On Tue, 19 Feb 2008, Thomas Renninger wrote:
Looks quite a bad idea IMO. 2.6.24 means what? SuSE's? Mainline's?
Debian's? At what patch level? With which user patches tacked on top? And
at what level of userspace support (X.org can make a LOT of difference
here)?
So you think on
On Wed, 20 Feb 2008, Thomas Renninger wrote:
AFAIK, there is no problem with the *ACPI* brightness firmware on ThinkPads.
At all. Its only quirk is that you want to call _BCL at least once at
driver load.
No it's not that it's:
- you call BCLL, a totally undefined AML function, found out
On Mon, 18 Feb 2008, Thomas Renninger wrote:
The problem is that OSI is used by Windows to pass the exact Windows
(not OS) version they are running, this function should be called WOSI.
We of course want to run on the latest fix-ups here and should pass
Windows 2006 (or whatever latest string
On Sat, 16 Feb 2008, Len Brown wrote:
On Friday 15 February 2008 23:17, Henrique de Moraes Holschuh wrote:
The video output port control feature is not very useful on many ThinkPads
(especially when a X server is running), and lately userspace is getting
better and better at it, so it makes
On Fri, 15 Feb 2008, Lukas Hejtmanek wrote:
On Thu, Feb 14, 2008 at 10:24:52AM -0200, Henrique de Moraes Holschuh wrote:
as of 2.6.25-rc1, there is no more /sys/class/backlight/acpi_video1 which
controlled LVDS backlight on Lenovo ThinkPad T61. There is still
acpi_video0 which seems
On Fri, 15 Feb 2008, Matthew Garrett wrote:
On Fri, Feb 15, 2008 at 04:34:34PM +0530, Thomas, Sujith wrote:
Len had mentioned in one of his responses that there is scope for
evolving
and we can do that. As you pointed out if there are
differences in the way temperatures are reported out,
Thanks to Damjan [EMAIL PROTECTED] for noticing this one.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index
Fix a stray ibm-acpi that should have been replaced with thinkpad-acpi.
Thanks to Damjan [EMAIL PROTECTED] for noticing this one.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/laptops/thinkpad-acpi.txt |2 +-
1 files changed, 1 insertions(+), 1 deletions
The open() and close() hooks for the input device are useful even when
hotkey NVRAM polling support is not in use, so it is better to always have
them around.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 13 -
1 files changed, 8
, otherwise we might lose the
first event we try to send through the input layer. The change is an
obviously desired one: instead of issuing thinkpad-acpi specific events
over the ACPI netlink socket, issue a generic event over an input device.
Here's the shortlog:
Henrique de Moraes Holschuh (9
is
set).
Add an attribute to report this information, hotkey_tablet_mode. This
attribute has poll()/select() support, and can be used along with EV_SW
SW_TABLET_MODE to hook userspace to tablet events.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/laptops/thinkpad
Fix a few spelling errors, and also document the EV_SW events thinkpad-acpi
can issue.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/laptops/thinkpad-acpi.txt | 48 +-
1 files changed, 27 insertions(+), 21 deletions(-)
diff --git
Fixes some minor points in the radio switch code and docs.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/laptops/thinkpad-acpi.txt |2 +-
drivers/misc/thinkpad_acpi.c|8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/Kconfig | 17 +
drivers/misc/thinkpad_acpi.c | 20 +---
2 files changed, 30 insertions(+), 7 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 1abc95c
Issue EV_SW SW_TABLET_MODE events for HKEY events 0x5009 and 0x500A on the
X41t/X60t/X61t. As usual, we suppress the HKEY events on the netlink
interface to avoid sending duplicate events to userspace.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/laptops
On Sat, 09 Feb 2008, Len Brown wrote:
On Friday 08 February 2008 20:49, Carlos Corbacho wrote:
On Saturday 09 February 2008 01:31:57 Carlos Corbacho wrote:
thinkpad-acpi - Move thinkpad-acpi.txt to Documentation/laptops
This patch [2/5] doesn't seem to have made it to the list. If
On Sat, 09 Feb 2008, Carlos Corbacho wrote:
On Saturday 09 February 2008 18:22:17 Henrique de Moraes Holschuh wrote:
BTW Carlos, sending a git diff would have resulted in much smaller diffs
(since git diff can do renames instead of add/delete) :) I believe all of
us can deal just fine
On Fri, 08 Feb 2008, Carlos Corbacho wrote:
I'm currently working on producing some documentation for acer-wmi, but
before
submitting it, I'm wondering where the best place in Documentation/ is for it
to live?
The only other laptop driver I've seen so far in Documentation/ is
On Thu, 07 Feb 2008, Len Brown wrote:
On Tuesday 05 February 2008 09:55, Henrique de Moraes Holschuh wrote:
The only duplication which I can see of is in the reporting of
temperature, which is quite reasonable for a thermal management module
to have.
Well, HdMH and I apparently
Richard,
Would you accept the addition of brightness_get to the led class? Please
look at the first patch in this small patch set series. I need it for
thinkpad-acpi...
The other two patches to thinkpad-acpi are included for reference on how I
intend to useg the new brightness_get stuff, and
Add a sysfs led class interface to the thinklight (light subdriver).
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
Cc: Richard Purdie [EMAIL PROTECTED]
---
Documentation/thinkpad-acpi.txt | 25 -
drivers/misc/thinkpad_acpi.c| 39
the
kernel's back), reality goes out of sync with the led class' idea of what
the led is doing, which is annoying at best.
Behaviour for drivers that do not or cannot read the led status is
unchanged.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
Cc: Richard Purdie [EMAIL PROTECTED
Add a sysfs led class interface to the led subdriver.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
Cc: Richard Purdie [EMAIL PROTECTED]
---
Documentation/thinkpad-acpi.txt | 46 +--
drivers/misc/thinkpad_acpi.c| 120 +++
2
The new thermal managemeny sysfs class that was just merged into acpi-test,
especially when dealing with temperature measurement and fan control, has a
lot of common ground with the hwmon interface.
However, the ACPI model for thermal cooling devices (fans, etc) and thermal
zones (temp sensors)
Len,
Given that there are four cleanup patches in the batch, I didn't even
attempt to bother with checkpatch on anything before the some checkpatch
fluff patch. There are, for example, no tab/space problems in the final
thinkpad_acpi.c file.
After the entire patchset is applied, there are still
On Tue, 22 Jan 2008, Matthew Garrett wrote:
On Tue, Jan 22, 2008 at 04:33:29PM +0800, Zhang Rui wrote:
I have no obvious objection on either of these two proposals.
But one thing to mention is that
both of these two patches is written on the assumption that the
brightness levels listed in
On Sun, 20 Jan 2008, Len Brown wrote:
[0.00] BIOS-provided physical RAM map:
[0.00] BIOS-e820: - 0009dc00 (usable)
[0.00] BIOS-e820: 0009dc00 - 000a (reserved)
[0.00] BIOS-e820: 000ce000 -
On Sat, 19 Jan 2008, Theodore Tso wrote:
Sure, and that means they have to *tell* *us* what they are doing so
we can be compatible with Windows. The concern is that they may be
doing stuff that isn't in the standard ACPI spec, but which needs to
be a certain way in order to be compatible with
On Sat, 19 Jan 2008, Len Brown wrote:
and if they did, nobody updates their bios anyway.
Actually, that only depends on us. If you drop support for people using
known-bad BIOS versions that give you greif, they have no choice but to go
away, or to upgrade. And so far, I have never had anyone
On Sat, 19 Jan 2008, Theodore Tso wrote:
On Sat, Jan 19, 2008 at 10:08:30AM -0200, Henrique de Moraes Holschuh wrote:
Actually, that only depends on us. If you drop support for people using
known-bad BIOS versions that give you greif, they have no choice but to go
away, or to upgrade
On Thu, 17 Jan 2008, Matthew Garrett wrote:
On Thu, Jan 17, 2008 at 05:24:50AM -0500, Len Brown wrote:
+ {
+ .callback = dmi_enable_osi_linux,
+ .ident = Lenovo ThinkPad T61,
+ .matches = {
+DMI_MATCH(DMI_SYS_VENDOR, LENOVO),
+
On Wed, 16 Jan 2008, Johannes Weiner wrote:
Define _sta() helper conditionally; also remove its prototype from
the internal header and also some other unneeded ones.
This function is only needed when the bay or the dock subdriver is
enabled. Otherwise, gcc complains about an unused static
Equivalent patch already sent to Len Brown for 2.6.25, removing the header
file altogether...
--
One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie. -- The Silicon Valley Tarot
Another version of this patch has been sent to Len Brown for 2.6.25 already.
--
One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie. -- The Silicon Valley Tarot
Henrique Holschuh
-
To
On Wed, 16 Jan 2008, Johannes Weiner wrote:
Johannes, thanks for the patches, but NAK. A similar group of patches that
clean up the _sta and heander file (kills it, actually) has already been
sent to Len Brown to be merged for 2.6.25.
Sorry, I missed to check his tree in advance. And if
On Mon, 14 Jan 2008, Matthew Garrett wrote:
Userspace is in a better position to make this determination. Of course,
That's fine with me.
this also means not passing the Linux OSI to the firmware. Our hardware
interaction is sufficiently in flux that any attempt to work around it
in the
On Sun, 13 Jan 2008, Pavel Machek wrote:
The reason it shoudl be turned off is that backlight enabling
backlight from a native graphics driver is much faster than running
through the video BIOS POST. So if we keep the OSI(Linux)
video BIOS POST workaround in place permanently, it would
A bit more on this issue. I have received a report that on a X61, it
actually works the opposite from the T61 and you need acpi_osi=!Linux to
get the mute key to work.
Well, I am asking the users to track down exactly *where* the mute key is
comming from in each case (ACPI or keyboard
On Sat, 12 Jan 2008, Len Brown wrote:
Lenovo has been attempting to make things a bit easier for Linux on their
ThinkPads, by disabling the more obnoxious behaviours of the firmware (used
by their Windows drivers) when in Linux. It looks like they used the OSI
string for that.
[...]
While helping a user find out what happened to his mute key, I found out
that the Lenovo BIOSes need the OSI string Linux defined to behave properly
in Linux.
Lenovo has been attempting to make things a bit easier for Linux on their
ThinkPads, by disabling the more obnoxious behaviours of the
On Tue, 08 Jan 2008, Matthew Garrett wrote:
On Mon, Jan 07, 2008 at 10:32:46PM -0200, Henrique de Moraes Holschuh wrote:
Should we? Why? We lose information doing that. Instead of a nice linear
0-100% brightness scale, you are now back to an 8 or 16-level non-linear
brightness scale
On Tue, 08 Jan 2008, Matthew Garrett wrote:
On Tue, Jan 08, 2008 at 10:06:53AM -0200, Henrique de Moraes Holschuh wrote:
Is there a *real* technical reason why we can't just round to the nearest?
That will work well with any firmware, and it will not remove functionality
from any box, while
General cleanup of module glue: Do some code reordering, and add
missing parameter help text.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 83 +-
1 files changed, 50 insertions(+), 33 deletions(-)
diff
The major code reorganization and cleanups, and new HKEY events, plus
poll()/select() support are good reasons to checkpoint a new version...
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/thinkpad-acpi.txt |4 ++--
drivers/misc/thinkpad_acpi.c|2 +-
2
When both CONFIG_THINKPAD_ACPI_DOCK and CONFIG_THINKPAD_ACPI_BAY are
undefined, _sta is not used and that causes a gcc warning. Fix it
(and I think this is a regression, I am pretty sure I fixed this once
before, sorry about that).
Issue reported by: Pritt Laes.
Signed-off-by: Henrique de
Fix some of the crap reported by checkpatch.pl.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 291 +-
1 files changed, 175 insertions(+), 116 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b
Use a generic message on hotkey_notify to log unknown and unhandled events,
and cleanup hotkey_notify a little.
Also, document event 0x5010 (brightness changed notification) and do not
log it as an unknown event (even if we do not use it for anything right
now).
Signed-off-by: Henrique de Moraes
The NVRAM polling support for hot keys is reason enough to
bump up the version string. Do it.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/thinkpad-acpi.txt |4 ++--
drivers/misc/thinkpad_acpi.c|2 +-
2 files changed, 3 insertions(+), 3 deletions
Remove dead code, and anything in the old changelog that is not a thank
you credit, or a key point to track down history.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 55 +++--
1 files changed, 4 insertions
the firmware doesn't set the hot key
mask to exactly what we asked it to;
5. Add proper locking to the data structures.
Only (4) should be user-noticeable, but there is a chance (5) fixes
some unknown/unreported race conditions.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED
Make some small internal thinkpad-acpi changes to the hotkey subdriver code
that will make it easier to add NVRAM polling support.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 82 +
1 files changed, 42
this-and-that
patch in various points of the stack :)
As usual, the patch set is available at:
git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git
for-upstream/acpi-test
The branch root is latest Linus' tree.
Shortlog of the above branch:
Henrique de Moraes Holschuh (20):
ACPI
breakages...
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 68 ++---
1 files changed, 63 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index cf56647..7b1080f
Add a handler for suspend events.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index dd6fa81
Move most subdriver-related stuff imported from the header file closer to
their subdriver code. Also, delete unneeded forward declarations.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 613 +-
1 files
that add poll()/select() capabilities to any pre-existing
attributes will also increment the sysfs interface version.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/thinkpad-acpi.txt |9 +
drivers/misc/thinkpad_acpi.c| 36
Remove the header file. Private header files used by a single .c file are
in bad taste, and I know better now.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 632 -
drivers/misc/thinkpad_acpi.h | 656
Update the copyright headers to include 2008.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index 91bda31..05f5329
it is not reported.
The idea is that if any of these attributes are non-zero, userspace might
want to do something at the end of the wake up from sleep procedures,
such as offering to send the machine back into sleep as soon as it is safe
to do so.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED
Tomas Carnecky reports that events 0x5009 and 0x500a are swivel events, and
that 0x500b/0x500c are tablet pen storage bay events.
Document these events, and avoid nasty messages when they happen.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
Documentation/thinkpad-acpi.txt
Rename defines with IBM in their name that are related to the older
driver name (ibm-acpi) to TPACPI, unless they are specific to IBM
ThinkPads.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 324 +-
1
On Tue, 08 Jan 2008, Richard Purdie wrote:
On Tue, 2008-01-08 at 15:54 +, Matthew Garrett wrote:
On Tue, Jan 08, 2008 at 03:45:02PM +, Richard Purdie wrote:
I did't get enough context above but I went through the archives and it
seems this is about linearising backlight values.
On Tue, 08 Jan 2008, Richard Purdie wrote:
So be it, then. But my request that we get a way to add the information we
are losing to the backlight class still stands.
The thing is does this 0-100 value have a use to userspace? Its
You can request something like middle brightness please
On Mon, 07 Jan 2008, Matthew Garrett wrote:
On Sun, Jan 06, 2008 at 11:36:23PM -0200, Henrique de Moraes Holschuh wrote:
Bah, I spoke too soon. Latest round of BIOSes seems to have broken this,
either that or I completely misunderstood the older AML code.
Rounding to the nearest
On Thu, 27 Dec 2007, Henrique de Moraes Holschuh wrote:
On Wed, 26 Dec 2007, Matthew Garrett wrote:
On Wed, Dec 26, 2007 at 02:10:27PM -0800, Andrew Morton wrote:
Vice versa for me. The thinkpad_acpi driver in 2.6.23 _does_ work,
but its interface vanished in 2.6.24-rc5 and the acpi
On Wed, 26 Dec 2007, Matthew Garrett wrote:
On Wed, Dec 26, 2007 at 02:10:27PM -0800, Andrew Morton wrote:
Vice versa for me. The thinkpad_acpi driver in 2.6.23 _does_ work,
but its interface vanished in 2.6.24-rc5 and the acpi driver does not
work.
As I said, the interface for the
On Wed, 26 Dec 2007, Andrew Morton wrote:
Vice versa for me. The thinkpad_acpi driver in 2.6.23 _does_ work,
but its interface vanished in 2.6.24-rc5 and the acpi driver does not
work.
As I said, give thinkpad-acpi the brightness_enable=1 parameter, and it will
export its backlight interface,
On Wed, 26 Dec 2007, Andrew Morton wrote:
For thinkpad-acpi at least, it is not a regression. 2.6.23/0.16 did NOT
support your thinkpad (it will pretend to work, but it won't work 100% right
as it only supports 8 levels of backlight control).
Well it may have been partially working, but
On Sun, 23 Dec 2007, Andrew Morton wrote:
When I fire up the latest Linus tree on my thinkpad t61p I get:
thinkpad_acpi: ThinkPad ACPI Extras v0.17
thinkpad_acpi: http://ibm-acpi.sf.net/
thinkpad_acpi: ThinkPad BIOS 7LET44WW (1.14 ), EC 7KHT22WW-1.06
thinkpad_acpi: Lenovo ThinkPad T61p
On Mon, 24 Dec 2007, Matthew Garrett wrote:
On Sun, Dec 23, 2007 at 12:00:57AM -0800, Andrew Morton wrote:
and /sys/class/backlight/thinkpad_screen/brightness is no longer present, so
my `brightness' script no longer works. That, my friends, is a regression.
The thinkpad_acpi brightness
Len,
Please send this patch series (which is composed of a single patch) to
Linus for merging in 2.6.24-rc.
It fixes problems on the latest Lenovo ThinkPads (the *61 series), on
most Linux distros.
Thank you.
--
One disk to rule them all, One disk to find them. One disk to bring
them all
-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index ab23a32..cf56647 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc
On Fri, 07 Dec 2007, Thomas Renninger wrote:
I see the danger of applications misusing this as an interface and
implementing workarounds for unsupported ACPI parts and (this is the
real problem) stop working on the real problems or a proper
implementation.
Exactly. Or causing shadow issues
On Thu, 29 Nov 2007, Rafael J. Wysocki wrote:
A deskptop suite trying to emulate the ThinkVantage suite in a ThinkPad
might want to check that the user woke up the laptop just to eject the bay,
and ask him if he wants the box to go back to sleep, and maybe even offer to
do so automatically
On Wed, 28 Nov 2007, Alexey Starikovskiy wrote:
Having it as /dev/ec0 should not introduce too many problems...
As long as it is with a debugging intent, and not as a place to plug
userspace drivers at. That would be much too dangerous IMO.
Also, it has much smaller impact than /dev/mem or
On Tue, 27 Nov 2007, Rafael J. Wysocki wrote:
On Monday, 26 of November 2007, Pascal d'Hermilly wrote:
When the computer suspends and comes back does it send a signal to the
running applications?
No, it doesn't. Applications aren't supposed to notice the suspend.
Except, of course, when
On Tue, 27 Nov 2007, Rafael J. Wysocki wrote:
in recent kernel, I got the following warnings while booting. It's ACPI
related. Does anybode care? Lenovo ThinkPad T61 (6465CTO).
Could we know the BIOS version, please?
--
One disk to rule them all, One disk to find them. One disk to bring
On Mon, 19 Nov 2007, Alex Chiang wrote:
Ugh, seems that stacked git got very confused when I did a
git-fetch git-rebase origin. Also, guess it figures that I
Being a very heavy stgit user myself, I have to say you must give up git
rebase on any stgit branch, and use stg rebase instead...
On Mon, 19 Nov 2007, Alexey Starikovskiy wrote:
Henrique de Moraes Holschuh wrote:
On Thu, 08 Nov 2007, Alexey Starikovskiy wrote:
handle explicitly. There doesn't seem to be any status enum value
defined that makes more sense than 'unknown' for a battery at a
critical charge level.
Maybe
for the parameter, and also
avoid any nastyness from BUG_ON while at it.
How to reproduce: modprobe thinkpad-acpi brightness
Error report by Mike Kershaw.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
Tested-by: Mike Kershaw [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c |8
On Thu, 15 Nov 2007, Len Brown wrote:
This patch:
a nit to prove that I read this before dumping it into my test branch...
Hey, I never doubted you read all my patchsets :-)
the perfect patch never refers to itself as a patch
in its check-in comments -- since by the time it is checked
On Wed, 14 Nov 2007, Zhang Rui wrote:
On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
ACPI: video - properly handle errors when registering proc elements
Have acpi_video_device_add_fs() and acpi_video_bus_add_fs()
properly unwind proc creation after error.
Hi, Dmitry,
The
Len,
This patchset has most of my current thinkpad-acpi queue. The target is
2.6.25, I am submitting they early for testing in acpi-test.
As usual, the patch set is available at:
git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git
for-upstream/acpi-test
The branch root is latest Linus'
Make some small internal thinkpad-acpi changes to the hotkey subdriver code
that will make it easier to add NVRAM polling support.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 82 +
1 files changed, 42
General cleanup of module glue: Do some code reordering, and add
missing parameter help text.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 83 +-
1 files changed, 50 insertions(+), 33 deletions(-)
diff
Remove dead code, and anything in the old changelog that is not a thank
you credit, or a key point to track down history.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 55 +++--
1 files changed, 4 insertions
to exactly what we asked it to;
5. Do the proper locking on the data structures.
Only (4) is user-noticeable, unless (5) fixes some corner-case races.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 184 +-
drivers
Remove the header file. Private header files used by a single .c file are
in bad taste, and I know better now.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 632 -
drivers/misc/thinkpad_acpi.h | 656
Reorder code in the file to get rid of more of the forward declarations,
and to make things cleaner and more organized.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c | 1493 +-
1 files changed, 734 insertions
Use a generic message on hotkey_notify to log unknown and unhandled events,
and cleanup hotkey_notify a little.
Also, document event 0x5010 (brightness changed notification) and do not
log it as an unknown event (even if we do not use it for anything right
now).
Signed-off-by: Henrique de Moraes
, as
it is not very small, and unlikely to be useful on any ThinkPad newer
than a T40, X31 or R52.
This patch is based on a previous effort by Richard Hughes.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
Cc: Richard Hughes [EMAIL PROTECTED]
---
Documentation/thinkpad-acpi.txt | 60
Request that thinkpad-acpi threads be frozen during suspend or hibernate.
Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
---
drivers/misc/thinkpad_acpi.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc
1 - 100 of 514 matches
Mail list logo
