Re: 2.6.25-rc2 Thinkpad T30 docking fails with oops.

2008-02-22 Thread Kristen Carlson Accardi
On Fri, 22 Feb 2008 00:34:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 19 Feb 2008 20:47:08 + Paul Martin [EMAIL PROTECTED] wrote: Now, this was working in 2.6.23, but is not in any later kernel. Previously reported, but I guess that the previous report was ignored due to

Re: 2.6.25-rc2 Thinkpad T30 docking fails with oops.

2008-02-22 Thread Kristen Carlson Accardi
On Fri, 22 Feb 2008 00:34:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 19 Feb 2008 20:47:08 + Paul Martin [EMAIL PROTECTED] wrote: Now, this was working in 2.6.23, but is not in any later kernel. Previously reported, but I guess that the previous report was ignored due to

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-28 Thread Kristen Carlson Accardi
On Wed, 28 Nov 2007 13:31:47 -0800 Gary Hade [EMAIL PROTECTED] wrote: FYI, the node contains 2 hotpluggable PCIe slots and 5 non-hotpluggable PCIe slots but 'pci_slot' only exposed the 2 hotpluggable slots. This does not appear to be due to a 'pci_slot' driver problem since I looked at the

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-19 Thread Kristen Carlson Accardi
On Sat, 17 Nov 2007 11:29:54 -0700 Alex Chiang [EMAIL PROTECTED] wrote: I have done quite a bit more testing, and verified that this series plays nicely with acpiphp during all stages of the series. Notably, you can modprobe/rmmod acpiphp repeatedly no matter where you are in the series, and

Re: [PATCH 4/4, v4] ACPI, PCI: ACPI PCI slot detection driver

2007-11-19 Thread Kristen Carlson Accardi
On Mon, 19 Nov 2007 15:04:18 -0700 Alex Chiang [EMAIL PROTECTED] wrote: Documentation/accounting/getdelays.c | 43 +- Documentation/feature-removal-schedule.txt |9 - Documentation/hwmon/sysfs-interface | 31 + Documentation/markers.txt|6 +-

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Kristen Carlson Accardi
On Wed, 14 Nov 2007 18:55:21 +0900 Kenji Kaneshige [EMAIL PROTECTED] wrote: Matthew Wilcox : On Tue, Nov 13, 2007 at 03:33:14PM -0800, Kristen Carlson Accardi wrote: As far as being able to retrieve the slot number (which it seemed from the HP manageablity application perspective

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-13 Thread Kristen Carlson Accardi
On Tue, 13 Nov 2007 12:26:32 -0800 Greg KH [EMAIL PROTECTED] wrote: On Tue, Nov 13, 2007 at 01:21:54PM -0700, Alex Chiang wrote: * Greg KH [EMAIL PROTECTED]: On Mon, Nov 12, 2007 at 05:08:53PM -0700, Alex Chiang wrote: Recently, Matthew Wilcox sent out the following mail about

what is writing to /sys/bus/pci/slot/slot_no/power really supposed to do?

2007-10-01 Thread Kristen Carlson Accardi
Hi, I notice in acpiphp that the code path for powering down the slot via sysfs does not execute the _EJ0 method, but instead simply looks for _PS3 and of couse disables all the bridges and devices. I suppose this could be valid depending on your definition of what

Re: [Pcihpd-discuss] what is writing to /sys/bus/pci/slot/slot_no/power really supposed to do?

2007-10-01 Thread Kristen Carlson Accardi
On Mon, 1 Oct 2007 10:43:41 -0700 Gary Hade [EMAIL PROTECTED] wrote: On Mon, Oct 01, 2007 at 10:08:58AM -0700, Kristen Carlson Accardi wrote: Hi, I notice in acpiphp that the code path for powering down the slot via sysfs does not execute the _EJ0 method, but instead simply looks

Re: [Pcihpd-discuss] what is writing to /sys/bus/pci/slot/slot_no/power really supposed to do?

2007-10-01 Thread Kristen Carlson Accardi
On Mon, 1 Oct 2007 11:33:54 -0700 Gary Hade [EMAIL PROTECTED] wrote: In this case, I did send it directly to you with [EMAIL PROTECTED] on [EMAIL PROTECTED] the CC line. You and Greg subsequently signed off on it and it entered mainline at 2.6.23-rc1. Gary Yay! Problem solved, that

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Kristen Carlson Accardi
On Tue, 25 Sep 2007 00:14:36 +0100 Matthew Garrett [EMAIL PROTECTED] wrote: Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code

Re: Docking support?

2007-06-08 Thread Kristen Carlson Accardi
On Fri, 7 Nov 2036 16:00:45 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Fri 08. Jun - 18:47:06, Samuel Thibault wrote: [...] Also, I'd really like to receive ACPI docking events in userland for triggering video devices configuration for instance. Via udev. Unfortunately I just

Re: Docking support?

2007-06-08 Thread Kristen Carlson Accardi
On Fri, 8 Jun 2007 18:47:06 +0800 Samuel Thibault [EMAIL PROTECTED] wrote: Hi, The dock driver seems to work for me for undocking: when I press the button on my docking station, kernel prints a message and the button turns blank, telling me that I can get my laptop out. However, when I

[PATCH] ACPI: bay: send envp with uevent

2007-05-18 Thread Kristen Carlson Accardi
event 1, or it may be event 0. Event 1 may also be a remove request. It would be best if you check the number of your event with udevmonitor before writing any udev scripts for inserting and removing drive bays. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Cc: Stephan Berberig

[PATCH] ACPI: dock: cleanup the uid patch

2007-05-09 Thread Kristen Carlson Accardi
ACPI: dock: cleanup the uid patch Make uid sysfs file error path free memory, and cleanup sysfs file when removing driver. Also fix CodingStyle violations. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Cc: Illya A. Volynets-Evenbakh [EMAIL PROTECTED] Index: 2.6-git/drivers/acpi

[PATCH] ACPI: dock: fix opps after dock driver fails to initialize

2007-05-09 Thread Kristen Carlson Accardi
by zeroing the pointer after freeing. Signed-off-by: Chuck Ebbert [EMAIL PROTECTED] Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/acpi/dock.c |6 ++ 1 file changed, 6 insertions(+) Index: 2.6-git/drivers/acpi/dock.c

[PATCH] ACPI: dock: use dynamically allocated platform device

2007-05-09 Thread Kristen Carlson Accardi
ACPI: dock: use dynamically allocated platform device Get rid of no release function warnings by switching to dynamically allocating the platform_device and using the platform device release routine in the base driver. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git

[PATCH] ACPI: dock: add immediate_undock option

2007-05-09 Thread Kristen Carlson Accardi
Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/acpi/dock.c === --- 2.6-git.orig/drivers/acpi/dock.c +++ 2.6-git/drivers/acpi/dock.c @@ -40,6 +40,13 @@ MODULE_AUTHOR(Kristen Carlson Accardi) MODULE_DESCRIPTION

[PATCH] ACPI: dock: unsuppress uevents

2007-05-09 Thread Kristen Carlson Accardi
ACPI: dock: unsuppress uevents Platform devices may not send uevents by default - override the setting so that we can send uevents on dock/undock. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/acpi/dock.c

Re: [ibm-acpi-devel] CONFIG_IBM_BAY

2007-03-20 Thread Kristen Carlson Accardi
On Mon, 19 Mar 2007 21:12:40 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Mon, 19 Mar 2007, Kristen Carlson Accardi wrote: Is this what you had in mind? (Warning - I didn't test this). Allow the driver to be loaded with an option that will allow userspace to control

Re: CONFIG_IBM_BAY

2007-03-20 Thread Kristen Carlson Accardi
On Mon, 19 Mar 2007 21:07:06 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: In the meanwhile, I would really appreciate a way to hook ibm-acpi into bay so that I can provide the ACPI events ibm-acpi used to generate... we can deprecate them and remove them in one year's time, or

Re: CONFIG_IBM_BAY

2007-03-20 Thread Kristen Carlson Accardi
On Tue, 20 Mar 2007 16:53:21 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Mon 19. Mar - 11:04:12, Kristen Carlson Accardi wrote: On Sun, 18 Mar 2007 19:55:30 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Sun 18. Mar - 15:36:52, Henrique de Moraes Holschuh wrote: On Sun, 18 Mar

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Mon, 19 Mar 2007 13:22:43 + Matthew Garrett [EMAIL PROTECTED] wrote: On Sun, Mar 18, 2007 at 09:27:51AM +0100, Holger Macht wrote: I don't prefer any solution, whether doing it inside the kernel, or doing it in userspace. What would be good would be to know what's the 'right' way

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Sun, 18 Mar 2007 19:55:30 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Sun 18. Mar - 15:36:52, Henrique de Moraes Holschuh wrote: On Sun, 18 Mar 2007, Holger Macht wrote: those ThinkPads where it is needed. Afterwards it does the corresponding dock/undock request on ibm_acpi. And

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Mon, 19 Mar 2007 15:37:46 +0100 Holger Macht [EMAIL PROTECTED] wrote: Sure. What actually bothers me is that in its current state, the dock station driver signals 'green' on the dock station as soon as the user presses the hardware undock button, but regardlessly of anything else. I think

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Sun, 18 Mar 2007 15:36:52 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Sun, 18 Mar 2007, Holger Macht wrote: those ThinkPads where it is needed. Afterwards it does the corresponding dock/undock request on ibm_acpi. And this works reliably good what I can see from the

Re: ibm-acpi bay and acpi generic bay convergence

2007-03-19 Thread Kristen Carlson Accardi
On Sat, 17 Mar 2007 16:24:29 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Thu, 15 Mar 2007, Henrique de Moraes Holschuh wrote: 3. is_ejectable_bay is too simple-minded. It could work for batteries, if it didn't try so hard to detect only sata/ata devices as bays. Maybe

Re: CONFIG_IBM_BAY

2007-03-15 Thread Kristen Carlson Accardi
On Thu, 15 Mar 2007 14:55:06 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: Note that these are all just stop-gap measures. We either need to have ACPI_BAY do everything needed in ThinkPads (like handling bay batteries), or to make both drivers work together, or I'll just pull all

Re: CONFIG_IBM_BAY

2007-03-15 Thread Kristen Carlson Accardi
On Thu, 15 Mar 2007 14:55:06 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: Please look at the patch I just sent. It allows ibm-acpi to load if ACPI_BAY is loaded. It will, of course, cause ACPI_BAY to refuse to load if ibm-acpi is already loaded, but that's probably fine as

Re: [PATCH] ACPI: ibm-acpi: allow module to load when acpi notifiers can't be set

2007-03-15 Thread Kristen Carlson Accardi
Carlson Accardi [EMAIL PROTECTED] --- Len, you can pull this patch from: git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git branch for-upstream/acpi-release Please send it to Linus for merge in 2.6.21. It will clash with the patches in acpi-test that are waiting for 2.6.22

Re: CONFIG_IBM_BAY

2007-03-15 Thread Kristen Carlson Accardi
On Thu, 15 Mar 2007 16:31:24 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Thu, 15 Mar 2007, Kristen Carlson Accardi wrote: I think we should focus our efforts on a generic (non platform specific) solution that can work across many laptops (i.e. ACPI_BAY). Let's make

Re: [PATCH] ACPI: eliminate useless bay events

2007-03-14 Thread Kristen Carlson Accardi
On Tue, 6 Mar 2007 23:16:49 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Tue, 06 Mar 2007, Kristen Carlson Accardi wrote: Eliminate bay events on resume if nothing has changed. Are these *really* useless? What if the *contents* of the bay changed? Humm... good point. I

[PATCH] ACPI: eliminate useless bay events

2007-03-06 Thread Kristen Carlson Accardi
Eliminate bay events on resume if nothing has changed. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/acpi/bay.c === --- 2.6-git.orig/drivers/acpi/bay.c +++ 2.6-git/drivers/acpi/bay.c @@ -51,6 +51,7

Re: [patch 05/13] ACPI: Make bay depend on dock

2007-02-23 Thread Kristen Carlson Accardi
, [EMAIL PROTECTED] wrote: From: Kristen Carlson Accardi [EMAIL PROTECTED] Since the bay driver depends on the dock driver for proper notification, make this driver depend on the dock driver. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Signed-off-by: Andrew

Re: [GIT PATCH] ACPI patches for 2.6.21

2007-02-09 Thread Kristen Carlson Accardi
On Fri, 9 Feb 2007 23:09:29 + Pavel Machek [EMAIL PROTECTED] wrote: Hi! Per your request, and the request of the distros, we've changed how ACPICA Core releases are integrated into Linux so that each upstream (CVS) check-in appears as a single git commit. While this process is not

Re: [patch 1/2] acpi: Remove procfs from bay

2006-12-22 Thread Kristen Carlson Accardi
On Fri, 22 Dec 2006 11:43:55 + Pavel Machek [EMAIL PROTECTED] wrote: Hi! Remove the procfs related code from the bay driver. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] This changes userland interface... how many apps will it break

[patch 0/2] more patches for removable drive bay

2006-12-16 Thread Kristen Carlson Accardi
Hi Len, Here's a set of patches for changing the removable drive bay driver (drivers/acpi/bay) from using the old proc interface to using a sysfs interface instead. I made the bay driver a platform driver, and so it's entries will now be located in /sys/devices/platform/bay.X. There are still 2

[patch 2/2] Convert the bay driver to be a platform driver

2006-12-16 Thread Kristen Carlson Accardi
Convert the bay driver to be a platform driver, so that we can have sysfs entries. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/acpi/bay.c | 87 + 1 file changed, 75 insertions(+), 12 deletions(-) --- kristen-2.6

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-12 Thread Kristen Carlson Accardi
On Tue, 12 Dec 2006 14:31:10 -0800 Jesse Barnes [EMAIL PROTECTED] wrote: On Tuesday, December 12, 2006 2:15 pm, Stefan Schmidt wrote: Hello. On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote: On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht [EMAIL PROTECTED] wrote: Well

Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-11 Thread Kristen Carlson Accardi
On Sat, 9 Dec 2006 12:59:58 +0100 Holger Macht [EMAIL PROTECTED] wrote: Well, I like to have them ;-) Ok - how is this? Send a uevent to indicate a device change whenever we dock or undock, so that userspace may now check the dock status via sysfs. Signed-off-by: Kristen Carlson Accardi

[patch 3/3] acpi: Fix symbol conflict between acpiphp and dock

2006-12-04 Thread Kristen Carlson Accardi
From: Prarit Bhargava [EMAIL PROTECTED] Fix bug which will cause acpiphp to not be able to load when dock.ko cannot load. Signed-off-by: Prarit Bhargava [EMAIL PROTECTED] Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/acpi/dock.c |8 +++- 1 file changed, 7

[patch 0/3] Dock patches

2006-12-04 Thread Kristen Carlson Accardi
Hi Len, Here are a set of patches for the dock station driver (drivers/acpi/dock). One makes the dock station driver also a platform driver. The second adds sysfs entries which will be created under /sys/devices/platform/dock.0 to allow the user to read the status of the dock station (1 for

[patch 1/3] Make the dock station driver a platform device driver.

2006-12-04 Thread Kristen Carlson Accardi
Make the dock station driver a platform device driver so that we can create sysfs entries under /sys/device/platform. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/acpi/dock.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) --- kristen-2.6

[patch 2/3] acpi: Add a docked sysfs file to the dock driver.

2006-12-04 Thread Kristen Carlson Accardi
. Signed-off-by: Brandon Philips [EMAIL PROTECTED] Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/acpi/dock.c | 95 +++- 1 file changed, 79 insertions(+), 16 deletions(-) --- kristen-2.6.orig/drivers/acpi/dock.c +++ kristen-2.6

Re: Comments about commit 'PCI: docking station: remove dock uevents'?

2006-11-13 Thread Kristen Carlson Accardi
On Mon, 13 Nov 2006 12:14:37 + Matthew Garrett [EMAIL PROTECTED] wrote: On Sun, Nov 12, 2006 at 03:07:37PM +0100, Holger Macht wrote: I'm currently looking at docking station support for various laptops/vendors and what can be done to get them working. At the moment, userspace has to

Re: Comments about commit 'PCI: docking station: remove dock uevents'?

2006-11-13 Thread Kristen Carlson Accardi
On Mon, 13 Nov 2006 20:57:40 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Mon 13. Nov - 19:50:25, Matthew Garrett wrote: On Mon, Nov 13, 2006 at 08:43:27PM +0100, Holger Macht wrote: What I'm doing at the moment (for about a week ;-) is to echo - - - to

Re: acpiphp makes noise on every lid close/open

2006-11-07 Thread Kristen Carlson Accardi
On Tue, 7 Nov 2006 21:44:09 +0100 David Weinehall [EMAIL PROTECTED] wrote: On Mon, Nov 06, 2006 at 10:21:17AM +0100, Pavel Machek wrote: Hi! With 2.6.19-rc4, acpi complains about acpiphp_glue: cannot get bridge info each time I close/reopen the lid... On thinkpad x60. Any ideas?

[patch] acpi: use mutex instead of spinlock in dock driver

2006-10-30 Thread Kristen Carlson Accardi
http://bugzilla.kernel.org/show_bug.cgi?id=7303 Use a mutex instead of a spinlock for locking the hotplug list because we need to call into the acpi subsystem which might sleep. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/acpi/dock.c | 16 1 file

Re: USB resume problem with IBM dock

2006-10-12 Thread Kristen Carlson Accardi
On Thu, 12 Oct 2006 00:02:42 -0400 David Abrahams [EMAIL PROTECTED] wrote: Hi, I hope I've come to the right place; I'm going based on the information in my kernel's MAINTAINERS file. I have been using suspend2 with a 2.6.18 kernel, my Thinkpad T60p, and a Thinkpad Advanced dock. When

[patch 1/2] acpi: check if parent is on dock

2006-09-07 Thread Kristen Carlson Accardi
When determining if a device is on a dock station, we should check the parent of the device as well. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/acpi/dock.c === --- 2.6-git.orig/drivers/acpi

patch [0/2]: acpi: add generic removable drive bay support

2006-09-07 Thread Kristen Carlson Accardi
Hello, Ever since I put out the docking station patches people have been asking me if I could get removable drive bays to work as well. These are devices such as the IBM/Lenovo Ultrabay, or the Dell Module Bay - basically removable disk drives. There is an IBM platform specific solution that

Re: [patch] pci/hotplug acpiphp: fix Kconfig for Dock dependencies

2006-07-26 Thread Kristen Carlson Accardi
-off-by: Anil S Keshavamurthy [EMAIL PROTECTED] Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/pci/hotplug/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 2.6-git.orig/drivers/pci/hotplug/Kconfig +++ 2.6-git/drivers/pci/hotplug/Kconfig @@ -76,7 +76,7

Re: ACPI bombing, ACPI Exception (acpi_bus-0071): AE_NOT_FOUND

2006-07-25 Thread Kristen Carlson Accardi
On Fri, 21 Jul 2006 16:13:23 -0400 George Nychis [EMAIL PROTECTED] wrote: Hey guys, I am running a 2.6.18-rc1-git7 kernel on my IBM Thinkpad x60s, with CONFIG_ACPI_DOCK=y Whenever the computer is inserted into the dock, ACPI seems to bomb: http://rafb.net/paste/results/GW5E8747.html I

Re: ACPI bombing, ACPI Exception (acpi_bus-0071): AE_NOT_FOUND

2006-07-25 Thread Kristen Carlson Accardi
On Tue, 25 Jul 2006 09:44:06 -0700 Brown, Len [EMAIL PROTECTED] wrote: Hey guys, I am running a 2.6.18-rc1-git7 kernel on my IBM Thinkpad x60s, with CONFIG_ACPI_DOCK=y Whenever the computer is inserted into the dock, ACPI seems to bomb:

[patch] pci/hotplug acpiphp: fix Kconfig for Dock dependencies

2006-07-25 Thread Kristen Carlson Accardi
dependent on the ACPI_DOCK option, but yet does not allow the option of acpiphp being built-in when dock is built as a module. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- drivers/pci/hotplug/Kconfig | 17 - 1 file

Re: dock problem - Dell Latitude+2.6.18-rc2

2006-07-18 Thread Kristen Carlson Accardi
On Tue, 18 Jul 2006 19:57:12 +0200 Jaroslaw Gorny [EMAIL PROTECTED] wrote: Hi, I've got one Dell Latitude D505 with a dock-station, like this: http://laptoptravel.com/product.aspx?pc=DELLDPORTV=DT Hi! Can you please run an experiment in which you boot your laptop undocked, and then dock and