Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-21 Thread Bjorn Helgaas
On Wednesday 09 May 2007 01:22:29 pm David Brownell wrote: static int acpi_pci_set_power_state(struct pci_dev *dev, pci_power_t state) { ... + switch (state) { + case PCI_D0: + case PCI_D1: + case PCI_D2: + case PCI_D3hot: + case PCI_D3cold: + return

Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-21 Thread David Brownell
On Monday 21 May 2007, Bjorn Helgaas wrote: On Wednesday 09 May 2007 01:22:29 pm David Brownell wrote: static int acpi_pci_set_power_state(struct pci_dev *dev, pci_power_t state) { ... + switch (state) { + case PCI_D0: + case PCI_D1: + case PCI_D2: + case PCI_D3hot:

Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-21 Thread Bjorn Helgaas
On Monday 21 May 2007 11:55:54 am David Brownell wrote: On Monday 21 May 2007, Bjorn Helgaas wrote: We had a bug[1] a while back where e1000 would suspend a device and call pci_power_state(), which used ACPI to turn off the slot. The only problem was that this was a dual-port card and the

Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-21 Thread David Brownell
On Monday 21 May 2007, Bjorn Helgaas wrote: On Monday 21 May 2007 11:55:54 am David Brownell wrote: On Monday 21 May 2007, Bjorn Helgaas wrote: We had a bug[1] a while back where e1000 would suspend a device and call pci_power_state(), which used ACPI to turn off the slot. The only

Re: [linux-pm] [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-14 Thread Pavel Machek
Hi! Provide new ACPI method tracking the target system state, for use during suspend() and other PM calls. It returns ACPI_STATE_S0 except during true suspend paths. Use that to finally implement the platform_pci_choose_state() hook on ACPI platforms. It calls _S3D and similar methods,

Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-10 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 21:22, David Brownell wrote: Provide new ACPI method tracking the target system state, for use during suspend() and other PM calls. It returns ACPI_STATE_S0 except during true suspend paths. Use that to finally implement the platform_pci_choose_state() hook on ACPI

Re: [patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-10 Thread David Brownell
On Thursday 10 May 2007, Rafael J. Wysocki wrote: On Wednesday, 9 May 2007 21:22, David Brownell wrote: Provide new ACPI method tracking the target system state, for use during suspend() and other PM calls. It returns ACPI_STATE_S0 except during true suspend paths. Use that to finally

[patch 2.6.21-git] pci_choose_state() works, does ACPI magic

2007-05-09 Thread David Brownell
Provide new ACPI method tracking the target system state, for use during suspend() and other PM calls. It returns ACPI_STATE_S0 except during true suspend paths. Use that to finally implement the platform_pci_choose_state() hook on ACPI platforms. It calls _S3D and similar methods, and uses the