Re: [PATCH] Ignore ACPI video devices that aren't present in hardware

2008-02-06 Thread Len Brown
thanks for the update, matthew. applied, -len On Wednesday 06 February 2008 20:44, Matthew Garrett wrote: Vendors often ship machines with a choice of integrated or discrete graphics, and use the same DSDT for both. As a result, the ACPI video module will locate devices that may not exist on

Re: [PATCH] Ignore ACPI video devices that aren't present in hardware

2008-02-02 Thread Matthew Garrett
On Sat, Feb 02, 2008 at 02:12:17AM -0500, Len Brown wrote: But I have to agree with Thomas' feedback: I also wonder why you added this to acpi_video_bus_add_fs and not acpi_video_bus_add, but it's functionally the same. or perhaps acpi_video_bus_check()? Yeah, that's fair enough. I'll

Re: [PATCH] Ignore ACPI video devices that aren't present in hardware

2008-01-26 Thread Matthew Garrett
On Thu, Jan 24, 2008 at 05:21:17PM -0500, Len Brown wrote: _ADR returns a bus-specific format. In the case of a video device, section B.6.1 says that _ADR returns a 32-bit device ID, and that No, that's only true for the output devices - not the parent device. The parent device is what's

Re: [PATCH] Ignore ACPI video devices that aren't present in hardware

2008-01-22 Thread Zhang Rui
On Thu, 2008-01-17 at 20:02 +0800, Matthew Garrett wrote: On Thu, Jan 17, 2008 at 11:57:11AM +0100, Thomas Renninger wrote: Does it make sense to add this as a separate function, searching for a physical PCI device for an ACPI device may pop up more often in the future? This is a kind of

Re: [PATCH] Ignore ACPI video devices that aren't present in hardware

2008-01-22 Thread Julian Sikorski
Zhang Rui pisze: On Thu, 2008-01-17 at 20:02 +0800, Matthew Garrett wrote: On Thu, Jan 17, 2008 at 11:57:11AM +0100, Thomas Renninger wrote: Does it make sense to add this as a separate function, searching for a physical PCI device for an ACPI device may pop up more often in the future?

Re: [PATCH] Ignore ACPI video devices that aren't present in hardware

2008-01-17 Thread Thomas Renninger
On Thu, 2008-01-17 at 03:39 +, Matthew Garrett wrote: Vendors often ship machines with a choice of integrated or discrete graphics, and use the same DSDT for both. As a result, the ACPI video module will locate devices that may not exist on this specific platform. Attempt to determine

Re: [PATCH] Ignore ACPI video devices that aren't present in hardware

2008-01-17 Thread Matthew Garrett
On Thu, Jan 17, 2008 at 11:57:11AM +0100, Thomas Renninger wrote: Does it make sense to add this as a separate function, searching for a physical PCI device for an ACPI device may pop up more often in the future? This is a kind of _STA (present or not) function for PCI ACPI devices then. No,