Re: [PATCH] Repost: asus strict model checking

2006-08-03 Thread Thomas Renninger
On Wed, 2006-08-02 at 22:49 +0400, Alexey Starikovskiy wrote: I was referring to this peace of artwork(asus_info is pointer to DSDT header): -- if (hotk-model == END_MODEL) { /* match failed */

Re: [PATCH] Repost: asus strict model checking

2006-08-02 Thread Thomas Renninger
On Tue, 2006-08-01 at 21:44 +0400, Alexey Starikovskiy wrote: Thomas Renninger wrote: On Tue, 2006-08-01 at 20:11 +0400, Alexey Starikovskiy wrote: Checks for Samsung P30/P35 are real hacks IMHO. Why? Because this DSDT signature could appear on any machine, and has nothing to do with ASUS

Re: [PATCH] Repost: asus strict model checking

2006-08-02 Thread Alexey Starikovskiy
I was referring to this peace of artwork(asus_info is pointer to DSDT header): -- if (hotk-model == END_MODEL) { /* match failed */ if (asus_info strncmp(asus_info-oem_table_id,

RE: [PATCH] Repost: asus strict model checking

2006-08-02 Thread Brown, Len
As long as this is not officially specified (by ACPI consortium and/or vendors) and such special Devices exist, it is the best we can do. Platform specific methods will never be in the APCI spec -- by the virtue that they are non-standard and platform specific by definition. The vendors should

Re: [PATCH] Repost: asus strict model checking

2006-08-01 Thread Thomas Renninger
On Tue, 2006-08-01 at 17:58 +0400, Alexey Starikovskiy wrote: Thomas, Is it possible to use DMI interface for this kind of system identification? IMO it should be sufficient to use the already provided Asus hotkey model identification. Using dmidecode to check for Asus and then fallback to the

Re: [PATCH] Repost: asus strict model checking

2006-08-01 Thread Thomas Renninger
On Tue, 2006-08-01 at 20:11 +0400, Alexey Starikovskiy wrote: Checks for Samsung P30/P35 are real hacks IMHO. Why? Thomas Thomas Renninger wrote: On Tue, 2006-08-01 at 17:58 +0400, Alexey Starikovskiy wrote: Thomas, Is it possible to use DMI interface for this kind of system