Re: [PATCH 05/27] block: ensure that async polled IO is marked REQ_NOWAIT

2018-12-04 Thread Jens Axboe
On 12/4/18 7:48 AM, Christoph Hellwig wrote: > On Fri, Nov 30, 2018 at 10:17:49AM -0700, Jens Axboe wrote: >>> Setting REQ_NOWAIT from inside the block layer will make the code that >>> submits requests harder to review. Have you considered to make this code >>> fail I/O if REQ_NOWAIT has not been

Re: [PATCH 05/27] block: ensure that async polled IO is marked REQ_NOWAIT

2018-12-04 Thread Christoph Hellwig
On Fri, Nov 30, 2018 at 10:17:49AM -0700, Jens Axboe wrote: > > Setting REQ_NOWAIT from inside the block layer will make the code that > > submits requests harder to review. Have you considered to make this code > > fail I/O if REQ_NOWAIT has not been set and to require that the context > > that

Re: [PATCH 05/27] block: ensure that async polled IO is marked REQ_NOWAIT

2018-11-30 Thread Jens Axboe
On 11/30/18 10:12 AM, Bart Van Assche wrote: > On Fri, 2018-11-30 at 09:56 -0700, Jens Axboe wrote: >> We can't wait for polled events to complete, as they may require active >> polling from whoever submitted it. If that is the same task that is >> submitting new IO, we could deadlock waiting for

Re: [PATCH 05/27] block: ensure that async polled IO is marked REQ_NOWAIT

2018-11-30 Thread Bart Van Assche
On Fri, 2018-11-30 at 09:56 -0700, Jens Axboe wrote: > We can't wait for polled events to complete, as they may require active > polling from whoever submitted it. If that is the same task that is > submitting new IO, we could deadlock waiting for IO to complete that > this task is supposed to be

[PATCH 05/27] block: ensure that async polled IO is marked REQ_NOWAIT

2018-11-30 Thread Jens Axboe
We can't wait for polled events to complete, as they may require active polling from whoever submitted it. If that is the same task that is submitting new IO, we could deadlock waiting for IO to complete that this task is supposed to be completing itself. Signed-off-by: Jens Axboe ---