Re: [PATCH 12/13] floppy: end whole request on error

2018-10-11 Thread Omar Sandoval
On Thu, Oct 11, 2018 at 12:39:51PM -0600, Jens Axboe wrote: > On 10/11/18 12:30 PM, Omar Sandoval wrote: > > From: Omar Sandoval > > > > If floppy_end_request() gets passed an error, it should end the whole > > request, not just the current segment. > > I don't think this is correct, we should

Re: [PATCH 12/13] floppy: end whole request on error

2018-10-11 Thread Jens Axboe
On 10/11/18 12:30 PM, Omar Sandoval wrote: > From: Omar Sandoval > > If floppy_end_request() gets passed an error, it should end the whole > request, not just the current segment. I don't think this is correct, we should still just end the individual chunks. -- Jens Axboe

[PATCH 12/13] floppy: end whole request on error

2018-10-11 Thread Omar Sandoval
From: Omar Sandoval If floppy_end_request() gets passed an error, it should end the whole request, not just the current segment. Signed-off-by: Omar Sandoval --- drivers/block/floppy.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/block/floppy.c