Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Damien Le Moal
On 2018/11/21 11:49, Jens Axboe wrote: > On 11/20/18 7:45 PM, Damien Le Moal wrote: >> On 2018/11/21 11:11, Jens Axboe wrote: >>> On 11/20/18 4:58 PM, Damien Le Moal wrote: On 2018/11/21 2:31, Jens Axboe wrote: > I think the below should fix it, we haven't necessarily setup an > ioc

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Jens Axboe
On 11/20/18 7:45 PM, Damien Le Moal wrote: > On 2018/11/21 11:11, Jens Axboe wrote: >> On 11/20/18 4:58 PM, Damien Le Moal wrote: >>> On 2018/11/21 2:31, Jens Axboe wrote: I think the below should fix it, we haven't necessarily setup an ioc if we're just doing as passthrough request.

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Damien Le Moal
On 2018/11/21 11:11, Jens Axboe wrote: > On 11/20/18 4:58 PM, Damien Le Moal wrote: >> On 2018/11/21 2:31, Jens Axboe wrote: >>> I think the below should fix it, we haven't necessarily setup an >>> ioc if we're just doing as passthrough request. >>> >>> >>> diff --git a/block/blk-mq-sched.c

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Damien Le Moal
On 2018/11/21 11:11, Jens Axboe wrote: > On 11/20/18 4:58 PM, Damien Le Moal wrote: >> On 2018/11/21 2:31, Jens Axboe wrote: >>> I think the below should fix it, we haven't necessarily setup an >>> ioc if we're just doing as passthrough request. >>> >>> >>> diff --git a/block/blk-mq-sched.c

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Jens Axboe
On 11/20/18 4:58 PM, Damien Le Moal wrote: > On 2018/11/21 2:31, Jens Axboe wrote: >> I think the below should fix it, we haven't necessarily setup an >> ioc if we're just doing as passthrough request. >> >> >> diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c >> index

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Damien Le Moal
On 2018/11/21 10:24, Ming Lei wrote: > On Tue, Nov 20, 2018 at 11:58:09PM +, Damien Le Moal wrote: >> On 2018/11/21 2:31, Jens Axboe wrote: >>> I think the below should fix it, we haven't necessarily setup an >>> ioc if we're just doing as passthrough request. >>> >>> >>> diff --git

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Ming Lei
On Tue, Nov 20, 2018 at 10:31:19AM -0700, Jens Axboe wrote: > On 11/20/18 10:21 AM, Ming Lei wrote: > > On Mon, Nov 19, 2018 at 12:51:26PM +0900, Damien Le Moal wrote: > >> bio->bi_ioc is never set so always NULL. Remove references to it in > >> bio_disassociate_task() and in rq_ioc() and delete

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Damien Le Moal
On 2018/11/21 2:31, Jens Axboe wrote: > I think the below should fix it, we haven't necessarily setup an > ioc if we're just doing as passthrough request. > > > diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c > index 13b8dc332541..f096d8989773 100644 > --- a/block/blk-mq-sched.c > +++

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Jens Axboe
On 11/20/18 10:21 AM, Ming Lei wrote: > On Mon, Nov 19, 2018 at 12:51:26PM +0900, Damien Le Moal wrote: >> bio->bi_ioc is never set so always NULL. Remove references to it in >> bio_disassociate_task() and in rq_ioc() and delete this field from >> struct bio. With this change, rq_ioc() always

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-20 Thread Ming Lei
On Mon, Nov 19, 2018 at 12:51:26PM +0900, Damien Le Moal wrote: > bio->bi_ioc is never set so always NULL. Remove references to it in > bio_disassociate_task() and in rq_ioc() and delete this field from > struct bio. With this change, rq_ioc() always returns > current->io_context without the need

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-19 Thread Adam Manzanares
On Mon, 2018-11-19 at 12:51 +0900, Damien Le Moal wrote: > bio->bi_ioc is never set so always NULL. Remove references to it in > bio_disassociate_task() and in rq_ioc() and delete this field from > struct bio. With this change, rq_ioc() always returns > current->io_context without the need for a

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-19 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/7] block: Remove bio->bi_ioc

2018-11-19 Thread Christoph Hellwig
On Mon, Nov 19, 2018 at 12:51:26PM +0900, Damien Le Moal wrote: > bio->bi_ioc is never set so always NULL. Remove references to it in > bio_disassociate_task() and in rq_ioc() and delete this field from > struct bio. With this change, rq_ioc() always returns > current->io_context without the need

[PATCH 2/7] block: Remove bio->bi_ioc

2018-11-18 Thread Damien Le Moal
bio->bi_ioc is never set so always NULL. Remove references to it in bio_disassociate_task() and in rq_ioc() and delete this field from struct bio. With this change, rq_ioc() always returns current->io_context without the need for a bio argument. Further simplify the code and make it more readable