Re: [PATCH 5/6] ide: don't acquire queue_lock in ide_complete_pm_rq

2018-11-16 Thread Omar Sandoval
On Fri, Nov 16, 2018 at 09:40:04AM +0100, Christoph Hellwig wrote: > On Fri, Nov 16, 2018 at 12:37:32AM -0800, Omar Sandoval wrote: > > On Fri, Nov 16, 2018 at 09:10:05AM +0100, Christoph Hellwig wrote: > > > blk_mq_stop_hw_queues doesn't need any locking, and the ide > > > dev_flags field isn't

Re: [PATCH 5/6] ide: don't acquire queue_lock in ide_complete_pm_rq

2018-11-16 Thread Christoph Hellwig
On Fri, Nov 16, 2018 at 12:37:32AM -0800, Omar Sandoval wrote: > On Fri, Nov 16, 2018 at 09:10:05AM +0100, Christoph Hellwig wrote: > > blk_mq_stop_hw_queues doesn't need any locking, and the ide > > dev_flags field isn't protected by it either. > > Is it a bug that dev_flags is no longer

Re: [PATCH 5/6] ide: don't acquire queue_lock in ide_complete_pm_rq

2018-11-16 Thread Omar Sandoval
On Fri, Nov 16, 2018 at 09:10:05AM +0100, Christoph Hellwig wrote: > blk_mq_stop_hw_queues doesn't need any locking, and the ide > dev_flags field isn't protected by it either. Is it a bug that dev_flags is no longer protected by queue_lock after the mq conversion? > Signed-off-by: Christoph

[PATCH 5/6] ide: don't acquire queue_lock in ide_complete_pm_rq

2018-11-16 Thread Christoph Hellwig
blk_mq_stop_hw_queues doesn't need any locking, and the ide dev_flags field isn't protected by it either. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-pm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c index 56690f523100..192e6c65d34e