Re: btrfs volume mounts and dies (was Re: Segfault in btrfsck)

2010-01-06 Thread Sander
Hello Steve, Steve Freitas wrote (ao): Should I take it by the lack of list response that I should just flush this partition down the toilet and start over? Or is everybody either flummoxed or on vacation? I don't have your original mail, but I think I remember you mentioned a lot of bad

Re: snapshot/subvolume removal

2010-01-06 Thread Piavlo
TARUISI Hiroaki wrote: Hi, We can delete snapshot with btrfsctl -D . It's available for your btrfs-progs version. -D works great Also how can I know if some directory is subvolume or snapshot or just a normal directory? Is there a way to list all the existing snapshots subvolumes under

Re: [RFC 00/12] btrfs core patches for direct I/O

2010-01-06 Thread Andi Kleen
jim owens jow...@hp.com writes: The existing core code for pagecache doesn't work for directio because the existing I/O routines depend on peeking inside a struct page to get the valid btrfs inode info. Sorry, no can do, we don't own that page. And rewriting the whole pagecache I/O stack to

[PATCH]btrfs: Remove a extra condition

2010-01-06 Thread liu weni
This patch remove a extra condition. In this place, the outer is if (!cur || !uptodate) and then, there are 2 ways: !cur or ! uptodate. The else if (!uptodate) is not necessary. I think else is better. --- Signed-off-by: Liuwenyi qingshen...@gmail.com --- diff --git a/fs/btrfs/ctree.c

Re: btrfs volume mounts and dies (was Re: Segfault in btrfsck)

2010-01-06 Thread Steve Freitas
Hi Sander, On Wed, 2010-01-06 at 08:52 +0100, Sander wrote: I don't have your original mail, but I think I remember you mentioned a lot of bad sectors on that disk reported by SMART. If that is indeed the case it might be dificult for the people who might be able to help you, to help you.

[PATCH 1/1] FS: btrfs, fix memory leaks

2010-01-06 Thread Jiri Slaby
Stanse found 2 memory leaks in relocate_block_group and __btrfs_map_block. cluster and multi are not freed/assigned on all paths. Fix that. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Chris Mason chris.ma...@oracle.com Cc: linux-btrfs@vger.kernel.org --- fs/btrfs/relocation.c |4 +++-

Re: btrfs volume mounts and dies (was Re: Segfault in btrfsck)

2010-01-06 Thread Johannes Hirte
Am Mittwoch 06 Januar 2010 16:59:55 schrieb Steve Freitas: Hi Sander, On Wed, 2010-01-06 at 08:52 +0100, Sander wrote: I don't have your original mail, but I think I remember you mentioned a lot of bad sectors on that disk reported by SMART. If that is indeed the case it might be

Re: btrfs volume mounts and dies (was Re: Segfault in btrfsck)

2010-01-06 Thread Steve Freitas
Hi Johannes, On Wed, 2010-01-06 at 18:24 +0100, Johannes Hirte wrote: Am Mittwoch 06 Januar 2010 16:59:55 schrieb Steve Freitas: Thanks for your response. You're correct about the bad sector warning. So please correct me if I have some mistaken assumptions. I thought btrfs would be

Re: btrfs-progs: New utility to swap subvolumes

2010-01-06 Thread Goffredo Baroncelli
Hello, here [*] you can find my script. Please pay attention to the fact that it is only tested on my *ubuntu* box. The program has 4 main commands: $ ./snapmng.sh snapmng.sh [-n] create snapname [comment] Create a new snapshot. snapmng.sh list