Re: ENOTEMPTY on rm -rf for snapshot and subvolume

2010-04-08 Thread Chris Mason
On Wed, Apr 07, 2010 at 05:44:20PM -0700, Harshavardhana wrote: Hi Everyone, Recently i created a snapshot of an existing volume which had some amount of data. Now that after creating the snapshot i have tried deleting the same snapshot. But i am getting ENOTEMPTY for

Re: btrfs Bug?

2010-04-08 Thread Chris Mason
On Tue, Apr 06, 2010 at 05:08:12PM +, yoost...@netzero.com wrote: Background: Was checking E-mail and browsing the internet when suddenly Pidgin crashed out. I thought that was pretty weird so I went to go re-start Pidgin when I noticed the machine hang really hard for about 30 seconds.

Re: Poor performance with qemu

2010-04-08 Thread Avi Kivity
On 03/30/2010 03:56 PM, Chris Mason wrote: On Sun, Mar 28, 2010 at 05:18:03PM +0200, Diego Calleja wrote: Hi, I'm using KVM, and the virtual disk (a 20 GB file using the raw qemu format according to virt-manager and, of course, placed on a btrfs filesystem, running the latest mainline git)

Re: Poor performance with qemu

2010-04-08 Thread Gordan Bobic
Avi Kivity wrote: On 03/30/2010 03:56 PM, Chris Mason wrote: On Sun, Mar 28, 2010 at 05:18:03PM +0200, Diego Calleja wrote: Hi, I'm using KVM, and the virtual disk (a 20 GB file using the raw qemu format according to virt-manager and, of course, placed on a btrfs filesystem, running the

Re: Poor performance with qemu

2010-04-08 Thread Chris Mason
On Thu, Apr 08, 2010 at 05:58:17PM +0300, Avi Kivity wrote: On 03/30/2010 03:56 PM, Chris Mason wrote: On Sun, Mar 28, 2010 at 05:18:03PM +0200, Diego Calleja wrote: Hi, I'm using KVM, and the virtual disk (a 20 GB file using the raw qemu format according to virt-manager and, of course, placed

Re: Poor performance with qemu

2010-04-08 Thread Avi Kivity
On 04/08/2010 06:26 PM, Chris Mason wrote: Once the O_DIRECT read patch is in, you can switch to that, or tell qemu to use a writeback cache instead. Even with writeback qemu will issue a lot of fsyncs. Oh, I didn't see that when I was testing, when does it fsync? When it

Re: Poor performance with qemu

2010-04-08 Thread Christoph Hellwig
On Thu, Apr 08, 2010 at 11:26:15AM -0400, Chris Mason wrote: With O_DIRECT the writeback rates are very reasonable. I'll work up a way to pass the barrier down from the guest to btrfs to force logging of updated metadata when required. Barriers are implemented in the guest kernel using queue

Re: Poor performance with qemu

2010-04-08 Thread Chris Mason
On Thu, Apr 08, 2010 at 06:28:54PM +0300, Avi Kivity wrote: On 04/08/2010 06:26 PM, Chris Mason wrote: Once the O_DIRECT read patch is in, you can switch to that, or tell qemu to use a writeback cache instead. Even with writeback qemu will issue a lot of fsyncs. Oh, I didn't see that when I

Re: Poor performance with qemu

2010-04-08 Thread Christoph Hellwig
On Thu, Apr 08, 2010 at 06:28:54PM +0300, Avi Kivity wrote: When it updates qcow2 metadata or when the guest issues a barrier. It's relatively new. I have a patch that introduces cache=volatile somewhere. qcow2 does not issues any fsyncs by itself, it only passes throught the guests ones.

Re: Poor performance with qemu

2010-04-08 Thread Avi Kivity
On 04/08/2010 06:34 PM, Christoph Hellwig wrote: On Thu, Apr 08, 2010 at 06:28:54PM +0300, Avi Kivity wrote: When it updates qcow2 metadata or when the guest issues a barrier. It's relatively new. I have a patch that introduces cache=volatile somewhere. qcow2 does not issues any

Re: Poor performance with qemu

2010-04-08 Thread Christoph Hellwig
On Thu, Apr 08, 2010 at 06:36:15PM +0300, Avi Kivity wrote: Shouldn't it do that then? What's the point of fsyncing guest data if qcow2 metadata is volatile? Not my territory - but in the end getting qcow2 as-is solid in face of crashes will be an uphill battel - I'd rather recommend not

Re: btrfs Bug?

2010-04-08 Thread Justin
Unfortunately I did reformat. Actually, I did a complete zero-out of the drive with dd, and then I ran badblocks -w on the drive, which returned 0 bad blocks (not sure if this is really a good test for SSD's as there's some amount of internal voo-doo on the drive itself). For future reference,

[PATCH] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots

2010-04-08 Thread Harshavardhana
rmdir on subvolumes and snapshots should return EPERM rather than ENOTEMPTY. Just to be more descriptive. Signed-off-by: Harshavardhana har...@gluster.com --- fs/btrfs/inode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index

Re: ENOTEMPTY on rm -rf for snapshot and subvolume

2010-04-08 Thread Harshavardhana
On 04/08/2010 06:52 AM, Chris Mason wrote: But either in that case too returning ENOTEMPTY does confuse a user a lot. Isn't it valid just by returning EPERM will explain a lot to users saying that this is a snapshot of a subvolume or a parent subvolume which is not

kernel BUG at /home/mafra/linux-2.6/fs/btrfs/volumes.c:2828!

2010-04-08 Thread Carlos R. Mafra
I've just got this bug in the latest 2.6.34-rc3-00388 kernel. I wasn't doing anything fancy, just doing some 'git log' in a small wmaker repo I have here. After I got this bug the cpu went to 100% and I had to reboot with the button because the laptop was not responding to any commands (but the

Re: [PATCH] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots

2010-04-08 Thread Harshavardhana
On 04/08/2010 03:07 PM, David Brown wrote: On Thu, Apr 08, 2010 at 01:35:31PM -0700, Harshavardhana wrote: if (inode-i_size BTRFS_EMPTY_DIR_SIZE || inode-i_ino == BTRFS_FIRST_FREE_OBJECTID) -return -ENOTEMPTY; +return -EPERM; Don't you want to still return

[PATCH][TAKE-1] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots

2010-04-08 Thread Harshavardhana
Break the conditional to return EPERM for subvolumes,snapshots and ENOTEMPTY for normal directories with files. Signed-off-by: Harshavardhana har...@gluster.com --- fs/btrfs/inode.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/inode.c

Re: UUID of subvolumes

2010-04-08 Thread Karel Zak
On Thu, Apr 08, 2010 at 08:51:42AM -0700, David Brown wrote: I am developing backup software (http://github.com/d3zd3z/jpool for the curious), and have been doing some testing with btrfs. Jpool currently uses the blkid database to map between device numbers (st_rdev) and the uuid of a

Re: kernel BUG at /home/mafra/linux-2.6/fs/btrfs/volumes.c:2828!

2010-04-08 Thread Yan, Zheng
On Fri, Apr 9, 2010 at 6:23 AM, Carlos R. Mafra crmaf...@gmail.com wrote: I've just got this bug in the latest 2.6.34-rc3-00388 kernel. I wasn't doing anything fancy, just doing some 'git log' in a small wmaker repo I have here. After I got this bug the cpu went to 100% and I had to reboot

Massage Therapists - 76,701 records and 8,305 emails

2010-04-08 Thread scutum
Joshua, Contact me at the email address below for a catalog of all our USA lists. Also, this week we are offering reduced costs for more than one list. Regards, Royal Giles Email Address: ester.tha...@optinlists.co.cc Forward email to rem...@optinlists.co.cc to purge you from our