Re: [PATCH V3 0/8] Cleancache: overview

2010-06-22 Thread Christoph Hellwig
What all this fails to explain is that this actually is useful for? Your series adds lots of crappy code, entiely stupid interactions with a handfull filesystems, but no actual users. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: Balancing leaves when walking from top to down (was Btrfs:...)

2010-06-22 Thread Edward Shishkin
Chris Mason wrote: On Mon, Jun 21, 2010 at 09:15:28AM -0400, Chris Mason wrote: I'll reproduce from your test case and provide a fix. mount -o max_inline=1500 would give us 50% usage in the worst case This is a very strange statement: how did you calculate this lower bound? (minus the

Re: Balancing leaves when walking from top to down (was Btrfs:...)

2010-06-22 Thread Chris Mason
On Tue, Jun 22, 2010 at 04:12:57PM +0200, Edward Shishkin wrote: Chris Mason wrote: On Mon, Jun 21, 2010 at 09:15:28AM -0400, Chris Mason wrote: I'll reproduce from your test case and provide a fix. mount -o max_inline=1500 would give us 50% usage in the worst case This is a very strange

Re: [PATCH V3 3/8] Cleancache: core ops functions and configuration

2010-06-22 Thread Christoph Hellwig
On Mon, Jun 21, 2010 at 04:19:39PM -0700, Dan Magenheimer wrote: [PATCH V3 3/8] Cleancache: core ops functions and configuration Cleancache core ops functions and configuration NACK for code that just adds random hooks all over VFS and even individual FS code, does an EXPORT_SYMBOL but

Re: [PATCH V3 3/8] Cleancache: core ops functions and configuration

2010-06-22 Thread Nitin Gupta
On 06/22/2010 08:13 PM, Christoph Hellwig wrote: On Mon, Jun 21, 2010 at 04:19:39PM -0700, Dan Magenheimer wrote: [PATCH V3 3/8] Cleancache: core ops functions and configuration Cleancache core ops functions and configuration NACK for code that just adds random hooks all over VFS and even

RE: [PATCH V3 3/8] Cleancache: core ops functions and configuration

2010-06-22 Thread Dan Magenheimer
Hi Christoph -- Thanks for the comments... replying to both in one reply. Subject: Re: [PATCH V3 0/8] Cleancache: overview What all this fails to explain is that this actually is useful for? See FAQ #1 in patch 1/8 (and repeated in patch 0/8). But, in a few words, it's useful for

Re: [PATCH V3 3/8] Cleancache: core ops functions and configuration

2010-06-22 Thread Jason Laprade
unsubscribe linux-btrfs On Tue, 2010-06-22 at 20:43 +0530, Nitin Gupta wrote: unsubscribe linux-btrfs -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 3/8] Cleancache: core ops functions and configuration

2010-06-22 Thread Dave Hansen
On Mon, 2010-06-21 at 16:19 -0700, Dan Magenheimer wrote: --- linux-2.6.35-rc2/include/linux/cleancache.h 1969-12-31 17:00:00.0 -0700 +++ linux-2.6.35-rc2-cleancache/include/linux/cleancache.h 2010-06-21 14:45:18.0 -0600 @@ -0,0 +1,88 @@ +#ifndef _LINUX_CLEANCACHE_H

Re: [PATCH] Improve support for exporting btrfs subvolumes.

2010-06-22 Thread Steve Dickson
On 06/17/2010 12:54 AM, Neil Brown wrote: If you export two subvolumes of a btrfs filesystem, they will both be given the same uuid so lookups will be confused. blkid cannot differentiate the two, so we must use the fsid from statfs64 to identify the filesystem. We cannot tell if blkid