Re: [RFC][PATCH] Btrfs: Fix uninitialized root flags for subvolumes

2011-03-30 Thread Andreas Philipp
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28.03.2011 04:01, Li Zefan wrote: root_item-flags and root_item-byte_limit are not initialized when a subvolume is created. This bug is not revealed until we added readonly snapshot support - now you mount a btrfs filesystem and you may find

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-30 Thread Tejun Heo
Hey, Peter. On Tue, Mar 29, 2011 at 07:37:33PM +0200, Peter Zijlstra wrote: On Tue, 2011-03-29 at 19:09 +0200, Tejun Heo wrote: Here's the combined patch I was planning on testing but didn't get to (yet). It implements two things - hard limit on spin duration and early break if the owner

[2.6.39-rc1] extent reference leaking...

2011-03-30 Thread Daniel J Blueman
When running the Linux Test Project against a BTRFS RAID 1 array, after some time I see BTRFS trying to free an extent that still has state [1]. Let me know if anyone is interested in a more specific reproducer and I'll take a look. Daniel --- [1] WARNING: at fs/btrfs/extent_io.c:3371

Re: [2.6.39-rc1] extent reference leaking...

2011-03-30 Thread Chris Mason
Excerpts from Daniel J Blueman's message of 2011-03-30 06:37:57 -0400: When running the Linux Test Project against a BTRFS RAID 1 array, after some time I see BTRFS trying to free an extent that still has state [1]. Let me know if anyone is interested in a more specific reproducer and I'll

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-30 Thread Peter Zijlstra
On Wed, 2011-03-30 at 10:17 +0200, Tejun Heo wrote: Hey, Peter. On Tue, Mar 29, 2011 at 07:37:33PM +0200, Peter Zijlstra wrote: On Tue, 2011-03-29 at 19:09 +0200, Tejun Heo wrote: Here's the combined patch I was planning on testing but didn't get to (yet). It implements two things -

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-30 Thread Chris Mason
Excerpts from Tejun Heo's message of 2011-03-29 12:37:02 -0400: Hello, guys. I've been running dbench 50 for a few days now and the result is, well, I don't know how to call it. The problem was that the original patch didn't do anything because x86 fastpath code didn't call into the

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-30 Thread Peter Zijlstra
On Wed, 2011-03-30 at 07:46 -0400, Chris Mason wrote: In this case, the only thing we're really missing is a way to mutex_lock without the cond_resched() So you're trying to explicitly avoid a voluntary preemption point? Seems like a bad idea, normally people add those :-) -- To unsubscribe

Re: [PATCH 1/2] Btrfs: fix OOPS of empty filesystem after balance

2011-03-30 Thread Arne Jansen
Am 10.03.2011 13:28, schrieb Chris Mason: Excerpts from liubo's message of 2011-03-10 03:50:27 -0500: On 03/07/2011 10:13 AM, liubo wrote: btrfs will remove unused block groups after balance. When a empty filesystem is balanced, the block group with tag DATA may be dropped, and after umount

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-30 Thread Chris Mason
Excerpts from Peter Zijlstra's message of 2011-03-30 07:52:04 -0400: On Wed, 2011-03-30 at 07:46 -0400, Chris Mason wrote: In this case, the only thing we're really missing is a way to mutex_lock without the cond_resched() So you're trying to explicitly avoid a voluntary preemption

[PATCH v2 0/5] btrfs-progs: scrub interface

2011-03-30 Thread Jan Schmidt
This is the next patch series for scrub userland tools. Change log v1-v2: - commands now reachable as btrfs scrub ... instead of btrfs filesystem scrub ... - ability to scrub a single device instead of a whole file system - superfluous command line options removed - resume is now a separate

[PATCH v2 5/5] scrub added to manpage

2011-03-30 Thread Jan Schmidt
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net --- man/btrfs.8.in | 66 +++- 1 files changed, 65 insertions(+), 1 deletions(-) diff --git a/man/btrfs.8.in b/man/btrfs.8.in index 26ef982..35aa44c 100644 --- a/man/btrfs.8.in +++

[PATCH v2 2/5] scrub ioctls

2011-03-30 Thread Jan Schmidt
- scrub structs added - ioctls for scrub - BTRFS_FSID_SIZE moved Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net --- ctree.h |2 +- ioctl.h | 60 +++- 2 files changed, 60 insertions(+), 2 deletions(-) diff --git a/ctree.h

[PATCH v2 4/5] scrub userland implementation

2011-03-30 Thread Jan Schmidt
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net --- scrub.c | 1568 +++ 1 files changed, 1568 insertions(+), 0 deletions(-) diff --git a/scrub.c b/scrub.c new file mode 100644 index 000..22052ed --- /dev/null +++ b/scrub.c @@

[PATCH v2 1/5] commands added

2011-03-30 Thread Jan Schmidt
- scrub commands added - open_file_or_dir no longer static (needed by scrub.c) Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net --- Makefile |4 ++-- btrfs.c | 18 +- btrfs_cmds.c |3 ++- btrfs_cmds.h |5 + 4 files changed, 26 insertions(+), 4

Do not use free space caching!

2011-03-30 Thread Josef Bacik
Hello, Just found a big bug in the free space caching stuff that will result in early ENOSPC. I'm working on fixing this bug, but it won't be until tomorrow that I'll have it completely working, so for now make sure to mount -o clear_cache so that it just clears the cache and doesn't use it.

[PATCH] Btrfs: fix /proc/mounts info.

2011-03-30 Thread Tsutomu Itoh
Some mount options are not displayed by /proc/mounts. This patch displays the option such as compress_type by /proc/mounts. Ex. [before] $ mount | grep sdc2 /dev/sdc2 on /test12 type btrfs (rw,space_cache,compress=lzo) $ cat /proc/mounts | grep sdc2 /dev/sdc2 /test12 btrfs

[PATCH 2/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-30 Thread Larry D'Anna
Signed-off-by: Larry D'Anna la...@elder-gods.org --- fs/btrfs/ioctl.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index f9717b6..10095c7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1804,6 +1804,7 @@ static

[PATCH 1/2] btrfs: remove unused argument 'root' from btrfs_release_path

2011-03-30 Thread Larry D'Anna
Signed-off-by: Larry D'Anna la...@elder-gods.org --- fs/btrfs/ctree.c| 28 ++-- fs/btrfs/ctree.h|2 +- fs/btrfs/dir-item.c |2 +- fs/btrfs/extent-tree.c | 74 fs/btrfs/file-item.c| 12 +++---