Re: minor ID for btrfs-control

2011-04-03 Thread Goffredo Baroncelli
Hello Helmut, On 04/03/2011 05:11 AM, Helmut Hullen wrote: Hallo, Goffredo, [..] As wrote by Tomasz the minor number of the btrfs-control is allocated dynamically. At which place? I replied you too fast. Btrfs register a misc device, but its number is not dynamically allocated (see [1] for

Re: minor ID for btrfs-control

2011-04-03 Thread Helmut Hullen
Hallo, Tomasz, Du meintest am 02.04.11: if I've understood some mails in this list correct, then btrfs needs a character device btrfs-control with the ID 10:55 When I look for this device in /sys/class/misc/btrfs-control/dev I see 10:234 If you do not use udev, you need to

Re: minor ID for btrfs-control

2011-04-03 Thread Helmut Hullen
Hallo, Goffredo, Du meintest am 03.04.11: As wrote by Tomasz the minor number of the btrfs-control is allocated dynamically. At which place? I replied you too fast. Btrfs register a misc device, but its number is not dynamically allocated (see [1] for further information), but it is

[PATCH] Btrfs: fix memory leak in start_transaction()

2011-04-03 Thread Yoshinori Sano
Free btrfs_trans_handle when join_transaction() fails in start_transaction() Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com --- fs/btrfs/transaction.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index

Re: minor ID for btrfs-control

2011-04-03 Thread Helmut Hullen
Hallo, Peter, Du meintest am 03.04.11: Solved (something like reverse engineering). I re-create the (permanent) entry /dev/btrfs-control using the actual contents of /sys/class/misc/btrfs-control/dev, and btrfs is happy (and me too). This is fine, and is just what udev does; it creates

Re: minor ID for btrfs-control

2011-04-03 Thread Helmut Hullen
Hallo, Peter, Du meintest am 03.04.11: Solved (something like reverse engineering). [...] My point was that it's not so much reverse engineering, it's exactly how udev works, and that also makes it a really reliable solution. But in this special case Goffredo has shown that I neither need

Re: btrfs balancing start - and stop?

2011-04-03 Thread Helmut Hullen
Hallo, Stephane, Du meintest am 03.04.11: balancing about 2 TByte needed about 20 hours. [...] Hugo has explained the limits of regarding dmesg | grep relocating or (more simple) the last lines of dmesg and looking for the relocating lines. But: what do these lines tell now?

[PATCH] Btrfs: fix memory leak in btrfs_ioctl_start_sync()

2011-04-03 Thread Tsutomu Itoh
Free btrfs_trans_handle if btrfs_commit_transaction_async() fails. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/ioctl.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -urNp linux-2.6.39-rc1/fs/btrfs/ioctl.c linux-2.6.39-rc1.new/fs/btrfs/ioctl.c ---

Re: [PATCH] Btrfs: fix memory leak in btrfs_ioctl_start_sync()

2011-04-03 Thread Tsutomu Itoh
Sorry. Ignore previous patch. New patch is as follows. Thanks, Tsutomu (2011/04/04 10:09), Tsutomu Itoh wrote: Free btrfs_trans_handle if btrfs_commit_transaction_async() fails. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/ioctl.c |4 +++- 1 file changed, 3