Re: Lockdep warning in btrfs_clear_lock_blocking

2011-05-17 Thread David Sterba
another lockdep warning, very similar to the previous. happened during xfstests/224 d/ [344121.276299] = [344121.284642] [ INFO: possible recursive locking detected ] [344121.286331] 2.6.39-rc7-default+ #22 [344121.286331]

Drive without DISCARD support crashes btrfs

2011-05-17 Thread David Sterba
Hi, while playing with lockedp, I started to hit consistent crashes with xfstests/013 (fsstress): [ 537.284234] [ cut here ] [ 537.288040] kernel BUG at fs/btrfs/tree-log.c:1792! [ 537.288040] invalid opcode: [#1] SMP [ 537.288040] last sysfs file:

[PATCH] btrfs: fix crash when no drive supports DISCARD

2011-05-17 Thread David Sterba
xfstests/013 crashes when the test partition is mounted with -o discard: walk_up_log_tree btrfs_free_reserved_extent btrfs_discard_extent return -EOPNOTSUPP BUG_ON ret btrfs_discard_extent() should be fine when drive does not support the DISCARD operation and filter the

Re: [PATCH] btrfs: fix crash when no drive supports DISCARD

2011-05-17 Thread Chris Mason
Excerpts from David Sterba's message of 2011-05-17 12:00:31 -0400: xfstests/013 crashes when the test partition is mounted with -o discard: walk_up_log_tree btrfs_free_reserved_extent btrfs_discard_extent return -EOPNOTSUPP BUG_ON ret btrfs_discard_extent() should be

ssd option for USB flash drive?

2011-05-17 Thread Stephane Chazelas
Hiya, I've not found much detail on what the ssd btrfs mount option did. Would it make sense to enable it to a fs on a USB flash drive? I'm using btrfs (over LVM) on a Live Linux USB stick to benefit from btrfs's compression and am trying to improve the performance. Would anybody have any

[PATCH] BTRFS: Remove unused node_lock

2011-05-17 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com 240f62c8756 replaced the node_lock with rcu_read_lock, but forgot to remove the actual lock in the data structure. Remove it here. Signed-off-by: Andi Kleen a...@linux.intel.com --- fs/btrfs/ctree.h |3 --- fs/btrfs/disk-io.c |1 - 2 files

Re: [PATCH] btrfs: fix crash when no drive supports DISCARD

2011-05-17 Thread Li Dongyang
On Wednesday, May 18, 2011 12:00:31 AM David Sterba wrote: xfstests/013 crashes when the test partition is mounted with -o discard: walk_up_log_tree btrfs_free_reserved_extent btrfs_discard_extent return -EOPNOTSUPP BUG_ON ret btrfs_discard_extent() should be fine when