Re: btrfs qgroup assign - ERROR: bad relation requested

2013-07-31 Thread Wang Shilong
Hello, On 07/31/2013 01:39 PM, Tomasz Chmielewski wrote: On Wed, 31 Jul 2013 13:13:37 +0800 Wang Shilong wangsl.f...@cn.fujitsu.com wrote: # git pull origin master Oops, i am sorry, here should: git pull origin qgroup would you please try it again Excellent, it works: # btrfs

ERROR: quota command failed: Invalid argument

2013-07-31 Thread Tomasz Chmielewski
I'm getting ERROR: quota command failed: Invalid argument when trying to run btrfs quota rescan - is it expected? root@bkp010 ~ # btrfs quota rescan /mnt/lxc1 ERROR: quota command failed: Invalid argument root@bkp010 ~ # btrfs quota rescan /mnt/lxc1 ERROR: quota command failed: Invalid argument

Re: ERROR: quota command failed: Invalid argument

2013-07-31 Thread Tomasz Chmielewski
On Wed, 31 Jul 2013 14:41:28 +0700 Tomasz Chmielewski man...@wpkg.org wrote: I'm getting ERROR: quota command failed: Invalid argument when trying to run btrfs quota rescan - is it expected? root@bkp010 ~ # btrfs quota rescan /mnt/lxc1 ERROR: quota command failed: Invalid argument

Re: [PATCH v2] Btrfs: add missing error check to find_parent_nodes

2013-07-31 Thread Jan Schmidt
On Wed, July 31, 2013 at 01:26 (+0200), Filipe David Borba Manana wrote: Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- V2: Ensure extent buffer is freed on error. fs/btrfs/backref.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[bug] balance BUG at fs/btrfs/relocation.c:886

2013-07-31 Thread Anand Jain
3.11.0-rc3+ -- [ 225.586356] kernel BUG at fs/btrfs/relocation.c:886! [ 225.586362] invalid opcode: [#1] SMP :: [ 225.586431] Call Trace: [ 225.586440] [a0055cd1] ? btree_read_extent_buffer_pages.clone.4+0xd1/0x120 [btrfs] [ 225.586447] [a00a9123]

Re: [bug] balance BUG at fs/btrfs/relocation.c:886

2013-07-31 Thread Liu Bo
On Wed, Jul 31, 2013 at 05:53:29PM +0800, Anand Jain wrote: 3.11.0-rc3+ -- [ 225.586356] kernel BUG at fs/btrfs/relocation.c:886! [ 225.586362] invalid opcode: [#1] SMP :: [ 225.586431] Call Trace: [ 225.586440] [a0055cd1] ?

[3.10.3] kernel BUG at fs/btrfs/ctree.c:3000

2013-07-31 Thread tim
running btrfs on kernel 3.10.3, i got the following two backtraces, first an info about a hung task and a kernel bug. are these known issues? thnx, tim [ 479.949428] INFO: task btrfs-transacti:1761 blocked for more than 120 seconds. [ 479.949430] echo 0

Re: [3.10.3] kernel BUG at fs/btrfs/ctree.c:3000

2013-07-31 Thread Josef Bacik
On Wed, Jul 31, 2013 at 02:19:25PM +0200, tim wrote: running btrfs on kernel 3.10.3, i got the following two backtraces, first an info about a hung task and a kernel bug. are these known issues? Well that's not good, can you file a bugzilla with this at bugzilla.kernel.org? Make sure the

[PATCH] Btrfs-progs: sanitize xattrs when we specify sanitization

2013-07-31 Thread Josef Bacik
Alexandre pointed out that his xattrs have sensitive information in them as well, so fix btrfs-image to zero out the data part of xattrs that we find. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com --- btrfs-image.c | 19 +++ 1 files changed, 19 insertions(+), 0

[PATCH] Btrfs: don't bug_on when we fail when cleaning up transactions

2013-07-31 Thread Josef Bacik
There is no reason for this sort of jackassery. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com --- fs/btrfs/transaction.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 18f7e71..ea8d522 100644 ---

[RFC PATCH v5 3/5] Btrfs: introduce a head ref rbtree

2013-07-31 Thread Liu Bo
The way how we process delayed refs is 1)get a bunch of head refs, 2)pick up one head ref, 3)go one node back for any delayed ref updates. The head ref is also linked in the same rbtree as the delayed ref is, so in 1) stage, we have to walk one by one including not only head refs, but delayed

[RFC PATCH v5 0/5] Online data deduplication

2013-07-31 Thread Liu Bo
Data deduplication is a specialized data compression technique for eliminating duplicate copies of repeating data.[1] This patch set is also related to Content based storage in project ideas[2]. PATCH 1 is a hang fix with deduplication on, but it's also useful without dedup in practice use.

[RFC PATCH v5 1/5] Btrfs: skip merge part for delayed data refs

2013-07-31 Thread Liu Bo
When we have data deduplication on, we'll hang on the merge part because it needs to verify every queued delayed data refs related to this disk offset but we may have millions refs. And in the case of delayed data refs, we don't usually have too much data refs to merge. So it's safe to shut it

[PATCH] Btrfs-progs: add dedup subcommand

2013-07-31 Thread Liu Bo
This aims to add deduplication subcommand, 'btrfs dedup command path', ie. register/unregister'. It can be used to enable or disable dedup support for a filesystem. Signed-off-by: Liu Bo bo.li@oracle.com --- Makefile |2 +- btrfs.c |1 + cmds-dedup.c | 101

[RFC PATCH v5 2/5] Btrfs: improve the delayed refs process in rm case

2013-07-31 Thread Liu Bo
While removing a file with dedup extents, we could have a great number of delayed refs pending to process, and these refs refer to droping a ref of the extent, which is of BTRFS_DROP_DELAYED_REF type. But in order to prevent an extent's ref count from going down to zero when there still are

[RFC PATCH v5 4/5] Btrfs: disable qgroups accounting when quota is off

2013-07-31 Thread Liu Bo
So we don't need to do qgroups accounting trick without enabling quota. This reduces my tester's costing time from ~28s to ~23s. Signed-off-by: Liu Bo bo.li@oracle.com --- fs/btrfs/extent-tree.c |6 ++ fs/btrfs/qgroup.c |6 ++ 2 files changed, 12 insertions(+), 0

[PATCH V2] xfstest: add a test for btrfs device replace operation

2013-07-31 Thread Stefan Behrens
This test performs btrfs device replace tests with all possible profiles (single/dup/mixed/raid0/raid1/raid10), one round with the '-r' option to 'btrfs replace start' and one round without this option. The cancelation is tested only once and with the dup/single profile for metadata/data. This

Re: [PATCH] xfstest: add a test for btrfs device replace operation

2013-07-31 Thread Stefan Behrens
On Fri, 26 Jul 2013 10:21:12 -0500, Eric Sandeen wrote: On 7/26/13 4:28 AM, Stefan Behrens wrote: Unfortunately this test takes 6 minutes on my SSD equiped test box since it runs all possible single/dup/raid0/raid1/raid10/mixed profiles, one round with the '-f' option to 'btrfs replace start'

Re: [PATCH] Btrfs-progs: add dedup subcommand

2013-07-31 Thread Stefan Behrens
On Wed, 31 Jul 2013 23:37:46 +0800, Liu Bo wrote: This aims to add deduplication subcommand, 'btrfs dedup command path', ie. register/unregister'. It can be used to enable or disable dedup support for a filesystem. Signed-off-by: Liu Bo bo.li@oracle.com --- Makefile |2 +-

Re: [RFC PATCH v5 2/5] Btrfs: improve the delayed refs process in rm case

2013-07-31 Thread Stefan Behrens
On Wed, 31 Jul 2013 23:37:42 +0800, Liu Bo wrote: + WARN_ON(update-ref_mod 0 update-ref_mod != 1); WARN_ON(update-ref_mod 1) -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: btrfs: stat(2) and /proc/pid/maps returns different devices

2013-07-31 Thread David Sterba
On Fri, Jul 19, 2013 at 01:51:15PM -0700, Mark Fasheh wrote: Ok checking for the operation is definitely needed. I'll check for -getattr(). The rest of the stuff in our suse patch must have been added after my own commit. Do you know why this was added? Since this is all internal to proc I

Re: Is the checkpoint interval adjustable?

2013-07-31 Thread Zach Brown
On Wed, Jul 31, 2013 at 04:02:29PM -0400, Mike Audia wrote: I believe 30 sec is the default for the checkpoint interval.  Is this adjustable? It doesn't look like it. It looks like it's implemented with raw '30's in the code. delay = HZ * 30; ... (now

Re: [RFC PATCH v5 3/5] Btrfs: introduce a head ref rbtree

2013-07-31 Thread Zach Brown
+ BUG_ON(!locked_ref); + BUG_ON(!btrfs_delayed_ref_is_head(head-node)); Please don't add more BUG_ON()s. They're unreliable because they can kill the system. If you *must* have logic asserts, use WARN_ON_ONCE and return errors. If the path is so dire

Re: [RFC PATCH v5 0/5] Online data deduplication

2013-07-31 Thread Josef Bacik
On Wed, Jul 31, 2013 at 11:37:40PM +0800, Liu Bo wrote: Data deduplication is a specialized data compression technique for eliminating duplicate copies of repeating data.[1] This patch set is also related to Content based storage in project ideas[2]. PATCH 1 is a hang fix with

Problems with incremental btrfs send (out of order instructions?)

2013-07-31 Thread Mathijs Kwik
Hi all, For some time, I've successfully deployed btrfs send/receive as a viable backup solution. It's fast and flexible and nicely scriptable =) However, every once in a while, trouble strikes on the receiving end with a message like: ERROR: rename

Re: Is the checkpoint interval adjustable?

2013-07-31 Thread Mike Audia
On Wed, Jul 31, 2013 at 04:02:29PM -0400, Mike Audia wrote: I believe 30 sec is the default for the checkpoint interval.  Is this adjustable? It doesn't look like it. It looks like it's implemented with raw '30's in the code.  delay = HZ * 30; ...  (now cur-start_time || now -

Re: [RFC PATCH v5 5/5] Btrfs: online data deduplication

2013-07-31 Thread Zach Brown
+#define BTRFS_DEDUP_HASH_SIZE 32 /* 256bit = 32 * 8bit */ +#define BTRFS_DEDUP_HASH_LEN 4 + +struct btrfs_dedup_hash_item { + /* FIXME: put a hash type field here */ + + __le64 hash[BTRFS_DEDUP_HASH_LEN]; +} __attribute__ ((__packed__)); The handling of hashes in this patch

Re: Is the checkpoint interval adjustable?

2013-07-31 Thread Zach Brown
Thank you kindly for the prompt reply.  My goal is to make them _less_ frequent. I assumed as much. I should have added some sympathy smileys :).  I am NO programmer by any stretch.  Let's say I want them to be once every 5 min (300 sec).  Is the attached patch sane to acheive this? I

Re: Is the checkpoint interval adjustable?

2013-07-31 Thread Duncan
Zach Brown posted on Wed, 31 Jul 2013 15:56:40 -0700 as excerpted: [Mike Audia wrote...]  I am NO programmer by any stretch.  Let's say I want them to be once every 5 min (300 sec).  Is the attached patch sane to acheive this?  Are there any unforeseen and effects of doing this? I don't

Fwd: Online data deduplication

2013-07-31 Thread Hemanth Kumar
I tried to apply deduplication patch on to 3.11-rc2 kernel but i am getting the following error. Can you pls thake a look at it and let me know whats wrong. linux-3805:/home/hemanth/linux-3.11-rc2 # patch -p1 /home/hemanth/RFC-V4-1-2-Btrfs-skip-merge-part-for-delayed-data-refs.patch patching

[PATCH 05/10] Btrfs-progs: add man page information for btrfs-convert

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- man/Makefile | 3 ++- man/btrfs-convert.8.in | 39 +++ 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644

[PATCH 09/10] btrfs-progs: Fix the return value of btrfs-map-logical

2013-07-31 Thread Wang Shilong
From: Qu Wenruo quwen...@cn.fujitsu.com The ret variant in the main function is not changed so even problems happen, return value is still 0. The patch fixs the minor bug and return 1 if any problems happen. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- btrfs-map-logical.c | 11

[PATCH 01/10] Btrfs-progs: add missing man page information for btrfsck

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- man/btrfsck.8.in | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/man/btrfsck.8.in b/man/btrfsck.8.in index 5004ba0..6087c14 100644

[PATCH 04/10] Btrfs-progs: add man page information for btrfs-find-root

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- man/Makefile | 2 +- man/btrfs-find-root.8.in | 36 man/btrfs-show-super.8.in | 4 ++-- 3 files changed, 39 insertions(+), 3

[PATCH 08/10] btrfs-progs: Update usage string of btrfs-map-logical

2013-07-31 Thread Wang Shilong
btrfs-map-logical supports both short and long options, and also every option should follow an arg,fix it. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- btrfs-map-logical.c | 12 1 file changed, 8 insertions(+), 4

[PATCH 10/10] Btrfs-progs: add missing man page for btrfs-map-logical

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- man/Makefile | 2 +- man/btrfs-map-logical.8.in | 39 +++ 2 files changed, 40 insertions(+), 1 deletion(-) create mode 100644

[PATCH 03/10] Btrfs-progs: add missing man page for btrfs-show-super

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- man/Makefile | 2 +- man/btrfs-show-super.8.in | 36 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644

[PATCH 02/10] Btrfs-progs: add missing man information for btrfs-debug-tree

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- btrfs-debug-tree.c| 2 +- man/Makefile | 3 ++- man/btrfs-debug-tree.8.in | 41 + 3 files changed, 44 insertions(+), 2

[PATCH 06/10] Btrfs-progs: add missing man page for btrfstune

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- man/Makefile | 2 +- man/btrfstune.8.in | 37 + 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 man/btrfstune.8.in diff

[PATCH 07/10] Btrfs-progs: add missing man page information for btrfs-zero-log

2013-07-31 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- man/Makefile| 2 +- man/btrfs-zero-log.8.in | 29 + 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 man/btrfs-zero-log.8.in