The reason is simple, for my
convenience I've added the user to the 'disk' group so I can access the
block devices without root. This patch stops to read the block devs
directly and uses the ioctl BTRFS_IOC_FS_INFO which gives me a silent
EPERM.
If I run show with sudo, then all filesystems
On Tue, October 15, 2013 at 22:41 (+0200), Zach Brown wrote:
Probably a bit too obscure to turn this into an xfstest? At least nobody
complained so far, and this reproducer takes me 1m57 to run, so nothing I
want
in each xfstest cycle.
I disagree. The entire point of regression tests is
On Wed, October 09, 2013 at 18:26 (+0200), Josef Bacik wrote:
btrfs_rename was using the root of the old dir instead of the root of the new
dir when checking for a hash collision, so if you tried to move a file into a
subvol it would freak out because it would see the file you are trying to
On Wed, Oct 16, 2013 at 05:25:37PM +0800, Anand Jain wrote:
Ah. good catch. but what do you suggest. ?
as of now user on disk-group is able to do things like,
check --repair. but won't be able to list the subvol /
manage the snapshots, and is able to run btrfs fi show -d
but won't be
This test is motivated by an issue found by a btrfs user, addressed
and described by the following GNU/Linux kernel patch:
https://patchwork.kernel.org/patch/3046931/
The steps to reproduce the issue on btrfs are the following:
$ mkfs.btrfs -f /dev/loop0
$ mount /dev/loop0 /mnt
$ mkdir /mnt/acl
On 10/16/13 11:11 AM, Filipe David Manana wrote:
On Wed, Oct 16, 2013 at 5:09 PM, Eric Sandeen sand...@sandeen.net wrote:
On 10/16/13 10:52 AM, Filipe David Borba Manana wrote:
This test is motivated by an issue found by a btrfs user, addressed
and described by the following GNU/Linux kernel
This test is motivated by an issue found by a btrfs user, addressed
and described by the following Linux kernel patch:
https://patchwork.kernel.org/patch/3046931/
The steps to reproduce the issue on btrfs are the following:
$ mkfs.btrfs -f /dev/loop0
$ mount /dev/loop0 /mnt
$ mkdir /mnt/acl
$
On 10/16/13 11:25 AM, Filipe David Borba Manana wrote:
This test is motivated by an issue found by a btrfs user, addressed
and described by the following Linux kernel patch:
https://patchwork.kernel.org/patch/3046931/
The steps to reproduce the issue on btrfs are the following:
Thanks!
Don't just skip regression testing. Please.
You are mixing up my points. The first argument you're quoting is not against
regression testing in this case, and it deserves the stress answer, I agree.
Great, then we're done.
(Yes, I'm very much ignoring your other argument that's based on
Stefan was hitting a panic in the async worker stuff because we had outstanding
read bios while we were stopping the worker threads. You could reproduce this
easily if you mount -o nospace_cache and ran generic/273. This is because the
caching thread stuff is still going and we were stopping all
Jan Schmidt list.bt...@jan-o-sch.net wrote:
[...]
You don't quote my second argument, which is not just skip regression
testing.
I'll try again in other words: A regression test only makes sense if it can
prevent us from making the same mistake again. As far as I see, the reproducer
Hi gang,
Here's some trivial cleanups that I've built up while reading through
the code. They've been run through xfstests -g quick.
- z
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at
move_pages() has an inefficient backwards byte copy of regions of two
different pages. They're different pages so the regions won't overlap
and it could use memcpy().
At that point, though, move_pages() would be a slightly dimmer
re-implementation of copy_pages() that lacked the test for
Signed-off-by: Zach Brown z...@redhat.com
---
fs/btrfs/dev-replace.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index 2a9bd5b..d3ee6e7 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@
fs/btrfs/compat.h only contained trivial macro wrappers of drop_nlink()
and inc_nlink(). This doesn't belong in mainline.
Signed-off-by: Zach Brown z...@redhat.com
---
fs/btrfs/compat.h | 7 ---
fs/btrfs/compression.c | 1 -
fs/btrfs/dev-replace.c | 1 -
fs/btrfs/disk-io.c | 1 -
Please ignore the previous post.
I have to correct myself, this is not a btrfs issue. In fact, the wrong (non 64
bit) calls have been used in the test program.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More
btrfs filesystem df output will show the size of the metadata space
and how much of it is used, and the user assumes that the difference
is all usable space. Since that's not actually the case due to the
global metadata reservation, we should provide the full picture to the
user.
This patch adds
As it was tested by David Sterba
Lokks good
Reviewed-by: Rich Johnston rjohns...@sgi.com
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This has been committed.
Thanks
--Rich
commit d4bc9576f09992dfc76eb34bb1aca3e80eaee1e7
Author: Josef Bacik jba...@fusionio.com
Date: Wed Sep 18 20:48:27 2013 +
xfstests: fix set-default test in btrfs/001
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the
This has been committed.
Thanks
--Rich
commit 774f4dd775340adc53565dce858882de0d4e6e85
Author: Tomas Racek tra...@redhat.com
Date: Thu Sep 19 16:20:37 2013 +
xfstests: unify apostrophes in output files
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the
This has been committed.
Thanks
--Rich
NOTE: the test was renumbered to the next test number.
commit 5956d1dd653decd08dd323a4be8b1c3cc40eb673
Author: Josef Bacik jba...@fusionio.com
Date: Fri Sep 27 14:27:33 2013 +
xfstests: btrfs/013 regression test for prealloc with balance
--
To
When debugging ENOSPC issues, it's nice to be able to see which
reservations failed as well as the ones which succeeded.
Signed-off-by: Jeff Mahoney je...@suse.com
---
fs/btrfs/extent-tree.c |7 +++
1 file changed, 7 insertions(+)
--- a/fs/btrfs/extent-tree.c2013-10-13
This patch has been committed.
Thanks
--Rich
NOTE: Test numbers are adjusted at commit time.
commit 2268142f6f036cdc257a7c031c511043804b5c63
Author: Gui Hecheng guihc.f...@cn.fujitsu.com
Date: Wed Oct 9 02:16:01 2013 +
xfstests: an regression test for btrfs balance
--
To
Thanks for the patch Filipe.
This has been committed.
Thanks
--Rich
commit 8bab8b31bb288b9d1b077ff8d06b6491715e8da7
Author: Filipe David Borba Manana fdman...@gmail.com
Date: Wed Oct 16 16:25:18 2013 +
xfstests: add specific test for default ACL inheritance
--
To unsubscribe from
On Wed, Oct 16, 2013 at 10:10:23AM -0500, Eric Sandeen wrote:
On 10/16/13 9:04 AM, Filipe David Borba Manana wrote:
This test is motivated by an issue found by a btrfs user, addressed
and described by the following GNU/Linux kernel patch:
https://patchwork.kernel.org/patch/3046931/
Hi
25 matches
Mail list logo
