[PATCH 1/2] btrfs-progs: don't report internal dev replace result if ioctl failed

2014-10-08 Thread Eryu Guan
If BTRFS_IOC_DEV_REPLACE ioctl failed, there's no result returned to fill args.result, it doesn't make sense to report this internal result to user. And the arg has been initialized with 0, the result is always 0, which is BTRFS_IOCTL_DEV_REPLACE_REPLACE_NO_ERROR, and the resulting error message

[PATCH 2/2] btrfs-progs: return error when canonicalize_path failed

2014-10-08 Thread Eryu Guan
Error out cmd_start_replace() if canonicalize_path() dstdev failed, add the missing goto leave_with_error; Signed-off-by: Eryu Guan guane...@gmail.com --- cmds-replace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmds-replace.c b/cmds-replace.c index 51b7aaf..d5648d5 100644 ---

Re: [PATCH] btrfs: Fix and enhance merge_extent_mapping() to insert best fitted extent map

2014-10-08 Thread Filipe David Manana
On Fri, Sep 19, 2014 at 1:31 AM, Qu Wenruo quwen...@cn.fujitsu.com wrote: Original Message Subject: Re: [PATCH] btrfs: Fix and enhance merge_extent_mapping() to insert best fitted extent map From: Filipe David Manana fdman...@gmail.com To: Qu Wenruo quwen...@cn.fujitsu.com

Re: Two uncorrectable errors across RAID1 at same logical block?

2014-10-08 Thread Liu Bo
On Mon, Oct 06, 2014 at 07:18:06PM -0700, Rich Rauenzahn wrote: On 10/6/2014 7:05 PM, Liu Bo wrote: btrfs inspect-internal logical-resolve 58464632832 $ sudo btrfs inspect-internal logical-resolve 58464632832 / ...no output? Hmm...have you tried the latest btrfs-progs? You can pull

Re: Two uncorrectable errors across RAID1 at same logical block?

2014-10-08 Thread Rich Rauenzahn
On 10/8/2014 7:20 AM, Liu Bo wrote: On Mon, Oct 06, 2014 at 07:18:06PM -0700, Rich Rauenzahn wrote: On 10/6/2014 7:05 PM, Liu Bo wrote: btrfs inspect-internal logical-resolve 58464632832 $ sudo btrfs inspect-internal logical-resolve 58464632832 / ...no output? Hmm...have you tried the

What is the vision for btrfs fs repair?

2014-10-08 Thread Eric Sandeen
I was looking at Marc's post: http://marc.merlins.org/perso/btrfs/post_2014-03-19_Btrfs-Tips_-Btrfs-Scrub-and-Btrfs-Filesystem-Repair.html and it feels like there isn't exactly a cohesive, overarching vision for repair of a corrupted btrfs filesystem. In other words - I'm an admin cruising

Re: [PATCH] btrfs: Fix and enhance merge_extent_mapping() to insert best fitted extent map

2014-10-08 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs: Fix and enhance merge_extent_mapping() to insert best fitted extent map From: Filipe David Manana fdman...@gmail.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年10月08日 20:08 On Fri, Sep 19, 2014 at 1:31 AM, Qu Wenruo