Re: [PATCH] Btrfs: cleanup btrfs_alloc_path()'s caller code

. Regards, Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com --- fs/btrfs/dir-item.c |2 + fs/btrfs/extent-tree.c | 12 +++--- fs/btrfs/file-item.c|6 +++- fs/btrfs/file.c |3 +- fs/btrfs/free-space-cache.c |4 ++- fs/btrfs/inode.c

[PATCH] Btrfs: cleanup btrfs_alloc_path()'s caller code

This patch checks return value of btrfs_alloc_path() and removes BUG_ON(). Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com --- fs/btrfs/dir-item.c|2 ++ fs/btrfs/extent-tree.c | 12 fs/btrfs/file-item.c |6 -- fs/btrfs/file.c|3 ++- fs/btrfs

[PATCH] Btrfs: fix memory leaks in btrfs_new_inode()

This patch fixes memory leaks in btrfs_new_inode(). Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com --- fs/btrfs/inode.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index aa116dc..d8c93c1 100644 --- a/fs/btrfs/inode.c

[PATCH] Btrfs: fix memory leak in start_transaction()

Free btrfs_trans_handle when join_transaction() fails in start_transaction() Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com --- fs/btrfs/transaction.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index ce48eb5

[PATCH] Btrfs: fix uncheck memory allocations

To make Btrfs code more robust, several return value checks where memory allocation can fail are introduced. I use BUG_ON where I don't know how to handle the error properly, which increases the number of using the notorious BUG_ON, though. Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com

Re: [PATCH] Btrfs: fix uncheck memory allocations

/15 Yoshinori Sano yoshinori.s...@gmail.com: To make Btrfs code more robust, several return value checks where memory allocation can fail are introduced. I use BUG_ON where I don't know how to handle the error properly, which increases the number of using the notorious BUG_ON, though. Signed

Re: [PATCH] fix uncheck memory allocations

2011年2月15日9:14 Tsutomu Itoh t-i...@jp.fujitsu.com: Sano-san, (2011/02/14 22:57), Yoshinori Sano wrote: 2011年2月14日8:57 Tsutomu Itoh t-i...@jp.fujitsu.com: (2011/02/12 20:17), Yoshinori Sano wrote: To make Btrfs code more robust, several return value checks where memory allocation can fail

[PATCH] fix uncheck memory allocations

To make Btrfs code more robust, several return value checks where memory allocation can fail are introduced. I use BUG_ON where I don't know how to handle the error properly, which increases the number of using the notorious BUG_ON, though. Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com

Re: On Removing BUG_ON macros

2010/11/8 Josef Bacik jo...@redhat.com: On Mon, Nov 08, 2010 at 10:17:50PM +0900, Yoshinori Sano wrote: To reduce the number of such BUG_ON usages, the code will be more robust, which results in increasing the number of Btrfs production use. (This is one of the way, off course.) But, as you

Re: On Removing BUG_ON macros

2010/11/8 Josef Bacik jo...@redhat.com: On Mon, Nov 08, 2010 at 10:54:07AM +0800, Ian Kent wrote: On Sun, 2010-11-07 at 09:51 -0500, Josef Bacik wrote: On Sun, Nov 07, 2010 at 04:16:47PM +0900, Yoshinori Sano wrote: This is a question I've posted on the #btrfs IRC channel today. hyperair

On Removing BUG_ON macros

with the allocation failure instead of using BUG_ON. However, (this is what most interesting thing for me) can the caller do any proper error handlings here? I mean, is this a critical situation where we cannot recover from? -- Yoshinori Sano yoshinori.s...@gmail.com -- To unsubscribe from this list: send

Btrfs Wiki: Debugging Btrfs with GDB

Btrfs development, it is worth reading, I think. (BTW, I'm a beginner, too :D) Thank you. -- Yoshinori Sano yoshinori.s...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http