Re: [PATCH] xfstests: fix flink test V2

2014-05-09 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] xfstests: fix flink test V2

2014-05-08 Thread Josef Bacik
I don't have flink support in my xfsprogs, but it doesn't fail with command not found or whatever, it fails because I don't have the -T option, whereas Eric gets an error about $TEST_DIR being a directory because his xfs_io tries to open the directory first before it parses the options. So fix

Re: [PATCH] xfstests: fix flink test V2

2014-05-08 Thread Eric Sandeen
On 5/8/14, 1:38 PM, Josef Bacik wrote: I don't have flink support in my xfsprogs, but it doesn't fail with command not found or whatever, it fails because I don't have the -T option, whereas Eric gets an error about $TEST_DIR being a directory because his xfs_io tries to open the directory

[PATCH] xfstests: fix flink test

2014-05-07 Thread Josef Bacik
I don't have flink support in my xfsprogs, but it doesn't fail with command not found or whatever, it fails because I don't have the -T option. So fix _require_xfs_io_command to check for an invalid option and not run. This way I get notrun instead of a failure. Thanks, Signed-off-by: Josef

Re: [PATCH] xfstests: fix flink test

2014-05-07 Thread Eric Sandeen
On 5/7/14, 3:54 PM, Josef Bacik wrote: I don't have flink support in my xfsprogs, but it doesn't fail with command not found or whatever, it fails because I don't have the -T option. So fix _require_xfs_io_command to check for an invalid option and not run. This way I get notrun instead