Re: [PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-22 Thread Anand Jain
On 21/05/14 00:33, David Sterba wrote: On Tue, May 20, 2014 at 02:36:48PM +0800, Anand Jain wrote: From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct

Re: [PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-21 Thread Anand Jain
(Random aside: why does btrfs support online fs relabeling, anyway?) -Eric Online you mean when mounted ? But I had an opinion that should we support label store from the sysfs interface when the (sysfs) interface can't communicate the module's specific errors back to the user.?

Re: [PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-21 Thread Eric Sandeen
On 5/21/14, 9:05 PM, Anand Jain wrote: (Random aside: why does btrfs support online fs relabeling, anyway?) -Eric Online you mean when mounted ? Yep - I'm just not sure who would ever want to do that. Aren't labels primarly used for mounting, during the mount process? So changing it

Re: [PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-21 Thread Roman Mamedov
On Wed, 21 May 2014 21:14:07 -0500 Eric Sandeen sand...@redhat.com wrote: (Random aside: why does btrfs support online fs relabeling, anyway?) -Eric Online you mean when mounted ? Yep - I'm just not sure who would ever want to do that. Aren't labels primarly used for mounting,

[PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-20 Thread Anand Jain
From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct command is echo -n test /sys/fs/btrfs/fsid/label This patch will check for this user error

Re: [PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-20 Thread Eric Sandeen
On 5/20/14, 1:36 AM, Anand Jain wrote: From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct command is echo -n test /sys/fs/btrfs/fsid/label This

Re: [PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-20 Thread David Sterba
On Tue, May 20, 2014 at 02:36:48PM +0800, Anand Jain wrote: From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct command is echo -n test

Re: [PATCH 1/2 v2] btrfs: label should not contain return char

2014-05-20 Thread Eric Sandeen
On 5/20/14, 11:33 AM, David Sterba wrote: On Tue, May 20, 2014 at 02:36:48PM +0800, Anand Jain wrote: From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct