Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-22 Thread David Sterba
On Mon, Jul 07, 2014 at 08:44:56AM +0800, Qu Wenruo wrote: The 'fi usage' is supposed to give the user-friendly overview, but the patchset is stuck because I found the numbers wrong or misleading under some circumstances. Although these patchset may not be merged, I'm curious about the wrong

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-07 Thread Vikram Goyal
On Fri, Jul 04, 2014 at 03:52:26PM +0200, David Sterba wrote: On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote: 'btrfs fi df' command is currently able to be executed on any file/dir inside btrfs since it uses btrfs ioctl to get disk usage info. However it is somewhat confusing for

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-07 Thread Eric Sandeen
On 7/4/14, 8:52 AM, David Sterba wrote: On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote: 'btrfs fi df' command is currently able to be executed on any file/dir inside btrfs since it uses btrfs ioctl to get disk usage info. However it is somewhat confusing for some end users since

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-07 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command From: Vikram Goyal vikigo...@gmail.com To: linux-btrfs@vger.kernel.org Date: 2014年07月07日 17:51 On Fri, Jul 04, 2014 at 03:52:26PM +0200, David Sterba wrote: On Fri, Jul 04

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-06 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年07月04日 21:52 On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote: 'btrfs fi df

[PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-04 Thread Qu Wenruo
'btrfs fi df' command is currently able to be executed on any file/dir inside btrfs since it uses btrfs ioctl to get disk usage info. However it is somewhat confusing for some end users since normally such command should only be executed on a mount point. This patch add mount point check in

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-04 Thread David Sterba
On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote: 'btrfs fi df' command is currently able to be executed on any file/dir inside btrfs since it uses btrfs ioctl to get disk usage info. However it is somewhat confusing for some end users since normally such command should only be

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-04 Thread Duncan
David Sterba posted on Fri, 04 Jul 2014 15:52:26 +0200 as excerpted: I disagree here, it's much more convenient to run 'fi df' anywhere and get the output. The system 'df' command works the same way. Agreed. I believe the proposed patch (at least based on its commit comment), however, simply