Re: [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-16 Thread David Sterba
On Sun, Sep 15, 2013 at 12:30:35PM +0800, Anand Jain wrote: IMO group profile is useful info to have it at both the places. end user using this new btrfs fi show would surely notice that it will reduce other commands normally used following the current btrfs fi show command. (like mount

Re: [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-14 Thread Anand Jain
--- btrfs fi show Label: none uuid: a2446ecf-68c5-4815-8b63-099d10fc373c mounted: /btrfs Group profile: metadata: single metadata: DUP data: single I didn't notice that before, this does not bring much information without the numbers as 'fi df' does. Please drop the

[PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-13 Thread Anand Jain
As of now btrfs filesystem show reads directly from disks. So sometimes output can be stale, mainly when user wants to cross verify their operation like, label or device delete or add... etc. so this patch will read from the kernel ioctl if it finds that disk is mounted. Further, to scan for the

Re: [PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-13 Thread David Sterba
On Fri, Sep 13, 2013 at 07:32:23PM +0800, Anand Jain wrote: Further, this patch adds new parameters mounted and group profile info in the filesystem show output Sorry to bother you, but the 'further' part of the patch should be separated out. The core change of the patch is to use libblkid and

[PATCH 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-08-30 Thread Anand Jain
As of now btrfs filesystem show reads directly from disks. So sometimes output can be stale, mainly when user want to verify their last operation like, labeling or device delete or add... etc. so this patch will read from the kernel ioctl if it finds that disk is mounted. Further, to scan for the