[PATCH 3/3] btrfs-progs: ctree: widen int-long due to PTR_ERR()

2013-09-09 Thread Chris West (Faux)
--- ctree.c | 74 ++-- ctree.h | 24 ++-- print-tree.c | 4 ++-- 3 files changed, 51 insertions(+), 51 deletions(-) diff --git a/ctree.c b/ctree.c index 8b1fc07..bfcf3d1 100644 --- a/ctree.c +++ b/ctree.c @@ -21,9

Re: [PATCH 3/3] btrfs-progs: ctree: widen int-long due to PTR_ERR()

2013-09-09 Thread David Sterba
I'm not sure this change is necessary. The code is inherited from kernel, I doubt that this would be wrong unnoticed. PTR_ERR should be always used after IS_ERR, this does all the typecasts and checks, the final value is in the range of -MAX_ERRNO..0. MAX_ERRNO is 4095, even if long is wider than