Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-29 Thread Qu Wenruo
On 2018/8/30 上午9:57, Misono Tomohiro wrote: > On 2018/08/28 14:21, Qu Wenruo wrote: >> On 2018/8/24 下午4:09, Misono Tomohiro wrote: >> [snip] BTW, what's the possibility of such problem in your test environment? >>> >>> It's like one in several times. >>> It may depend on hardware

Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-29 Thread Misono Tomohiro
On 2018/08/28 14:21, Qu Wenruo wrote: > On 2018/8/24 下午4:09, Misono Tomohiro wrote: > [snip] >>> >>> BTW, what's the possibility of such problem in your test environment? >> >> It's like one in several times. >> It may depend on hardware performance? (the machine is not so fast), >> >> I also

Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-27 Thread Qu Wenruo
On 2018/8/24 下午4:09, Misono Tomohiro wrote: [snip] >> >> BTW, what's the possibility of such problem in your test environment? > > It's like one in several times. > It may depend on hardware performance? (the machine is not so fast), > > I also noticed following warning happens too (not always):

Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-24 Thread Misono Tomohiro
On 2018/08/24 16:58, Qu Wenruo wrote: > > > On 2018/8/24 下午3:54, Misono Tomohiro wrote: >> On 2018/08/24 16:20, Qu Wenruo wrote: >>> >>> >>> On 2018/8/24 下午3:14, Misono Tomohiro wrote: Hi, On 2018/08/21 14:40, Qu Wenruo wrote: > Commit c6887cd11149 ("Btrfs: don't do nocow

Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-24 Thread Qu Wenruo
On 2018/8/24 下午3:54, Misono Tomohiro wrote: > On 2018/08/24 16:20, Qu Wenruo wrote: >> >> >> On 2018/8/24 下午3:14, Misono Tomohiro wrote: >>> Hi, >>> >>> On 2018/08/21 14:40, Qu Wenruo wrote: Commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to") makes nocow check less

Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-24 Thread Misono Tomohiro
On 2018/08/24 16:20, Qu Wenruo wrote: > > > On 2018/8/24 下午3:14, Misono Tomohiro wrote: >> Hi, >> >> On 2018/08/21 14:40, Qu Wenruo wrote: >>> Commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to") >>> makes nocow check less frequent to improve performance. >>> >>> However for

Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-24 Thread Qu Wenruo
On 2018/8/24 下午3:14, Misono Tomohiro wrote: > Hi, > > On 2018/08/21 14:40, Qu Wenruo wrote: >> Commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to") >> makes nocow check less frequent to improve performance. >> >> However for quota enabled case, such optimization could lead to

Re: [PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-24 Thread Misono Tomohiro
Hi, On 2018/08/21 14:40, Qu Wenruo wrote: > Commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to") > makes nocow check less frequent to improve performance. > > However for quota enabled case, such optimization could lead to extra > unnecessary data reservation, which results

[PATCH v2] btrfs: Always check nocow for quota enabled case to make sure we won't reserve unnecessary data space

2018-08-20 Thread Qu Wenruo
Commit c6887cd11149 ("Btrfs: don't do nocow check unless we have to") makes nocow check less frequent to improve performance. However for quota enabled case, such optimization could lead to extra unnecessary data reservation, which results failure for test case like btrfs/153 in fstests. Fix it