Re: [PATCH v4 1/2] btrfs: make fs_devices to be a local variable

2018-07-15 Thread Anand Jain
On 07/12/2018 02:23 PM, Gu Jinxiang wrote: fs_devices is always passed to btrfs_scan_one_device which overrides it. And in the call stack below fs_devices is passed to btrfs_scan_one_device from btrfs_mount_root. And in btrfs_mount_root the output fs_devices of this call stack is not used.

Re: [PATCH v4 1/2] btrfs: make fs_devices to be a local variable

2018-07-13 Thread David Sterba
On Thu, Jul 12, 2018 at 02:23:15PM +0800, Gu Jinxiang wrote: > fs_devices is always passed to btrfs_scan_one_device which > overrides it. And in the call stack below fs_devices is passed to > btrfs_scan_one_device from btrfs_mount_root. > And in btrfs_mount_root the output fs_devices of this call

Re: [PATCH v4 1/2] btrfs: make fs_devices to be a local variable

2018-07-12 Thread Nikolay Borisov
On 12.07.2018 09:23, Gu Jinxiang wrote: > fs_devices is always passed to btrfs_scan_one_device which > overrides it. And in the call stack below fs_devices is passed to > btrfs_scan_one_device from btrfs_mount_root. > And in btrfs_mount_root the output fs_devices of this call stack > is not

[PATCH v4 1/2] btrfs: make fs_devices to be a local variable

2018-07-12 Thread Gu Jinxiang
fs_devices is always passed to btrfs_scan_one_device which overrides it. And in the call stack below fs_devices is passed to btrfs_scan_one_device from btrfs_mount_root. And in btrfs_mount_root the output fs_devices of this call stack is not used. btrfs_mount_root ->