Re: [PATCH v4 4/6] btrfs: sync scrub with commit device removal

2011-03-24 Thread Arne Jansen
On 23.03.2011 18:28, David Sterba wrote: Hi, you are adding a new smp_mb, can you please explain why it's needed and document it? thanks, dave On Fri, Mar 18, 2011 at 04:55:07PM +0100, Arne Jansen wrote: This adds several synchronizations: - for a transaction commit, the scrub gets

Re: [PATCH v4 4/6] btrfs: sync scrub with commit device removal

2011-03-24 Thread Arne Jansen
On 24.03.2011 13:58, Arne Jansen wrote: On 23.03.2011 18:28, David Sterba wrote: Hi, you are adding a new smp_mb, can you please explain why it's needed and document it? thanks, dave On Fri, Mar 18, 2011 at 04:55:07PM +0100, Arne Jansen wrote: This adds several synchronizations: - for

Re: [PATCH v4 4/6] btrfs: sync scrub with commit device removal

2011-03-23 Thread David Sterba
Hi, you are adding a new smp_mb, can you please explain why it's needed and document it? thanks, dave On Fri, Mar 18, 2011 at 04:55:07PM +0100, Arne Jansen wrote: This adds several synchronizations: - for a transaction commit, the scrub gets paused before the tree roots are committed

[PATCH v4 4/6] btrfs: sync scrub with commit device removal

2011-03-18 Thread Arne Jansen
This adds several synchronizations: - for a transaction commit, the scrub gets paused before the tree roots are committed until the super are safely on disk - during a log commit, scrubbing of supers is disabled - on unmount, the scrub gets cancelled - on device removal, the scrub for the