Re: How to implement raid1 repair

2011-03-17 Thread Josef Bacik
On Thu, Mar 17, 2011 at 03:46:43PM +0100, Jan Schmidt wrote: Hello everyone, Currently, btrfs has its own raid1 but no repair mechanism for bad checksums or EIOs. While trying to implement such a repair mechanism, several more or less general questions came up. There are two different

Re: How to implement raid1 repair

2011-03-17 Thread Jan Schmidt
On 03/17/2011 06:09 PM, Andrey Kuzmin wrote: On Thu, Mar 17, 2011 at 5:46 PM, Jan Schmidt list.bt...@jan-o-sch.net mailto:list.bt...@jan-o-sch.net wrote: - Is it acceptable to retry reading a block immediately after the disk said it won't work? Or in case of a successful read followed

Re: How to implement raid1 repair

2011-03-17 Thread Chris Mason
Excerpts from Jan Schmidt's message of 2011-03-17 13:37:54 -0400: On 03/17/2011 06:09 PM, Andrey Kuzmin wrote: On Thu, Mar 17, 2011 at 5:46 PM, Jan Schmidt list.bt...@jan-o-sch.net mailto:list.bt...@jan-o-sch.net wrote: - Is it acceptable to retry reading a block immediately after the

Re: How to implement raid1 repair

2011-03-17 Thread Andrey Kuzmin
On Thu, Mar 17, 2011 at 8:42 PM, Chris Mason chris.ma...@oracle.com wrote: Excerpts from Jan Schmidt's message of 2011-03-17 13:37:54 -0400: On 03/17/2011 06:09 PM, Andrey Kuzmin wrote: On Thu, Mar 17, 2011 at 5:46 PM, Jan Schmidt list.bt...@jan-o-sch.net mailto:list.bt...@jan-o-sch.net

Re: How to implement raid1 repair

2011-03-17 Thread Jan Schmidt
On 03/17/2011 06:36 PM, Chris Mason wrote: Excerpts from Jan Schmidt's message of 2011-03-17 10:46:43 -0400: Hello everyone, Currently, btrfs has its own raid1 but no repair mechanism for bad checksums or EIOs. While trying to implement such a repair mechanism, several more or less general

Re: How to implement raid1 repair

2011-03-17 Thread Jan Schmidt
(snipped the parts already commented on in the other mails just sent) On 03/17/2011 06:19 PM, Josef Bacik wrote: On Thu, Mar 17, 2011 at 03:46:43PM +0100, Jan Schmidt wrote: If either of the answers is no, tracking where the initial read came from seems inevitable. Tracking would be very easy