Re: Unable to mount multiple subvolumes of a single disk

2014-09-22 Thread Stefan G. Weichinger
Am 17.09.2014 um 15:21 schrieb Chris Mason: No problem, the original patch looked right to me too. We're getting closer to rc6, I think at this point I'll revert the original patch until the next merge window. Then we can step back and nail down exactly what is going on. running

Re: Unable to mount multiple subvolumes of a single disk

2014-09-17 Thread Chris Mason
On 09/17/2014 05:47 AM, Anand Jain wrote: Hi Chris, --- diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e9676a4..1224b61 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -533,7 +533,7 @@ static noinline int device_list_add(const char *path,

Re: Unable to mount multiple subvolumes of a single disk

2014-09-16 Thread Paul Sherwood
Hi Anand On 15/09/2014 18:42, Anand Jain wrote: The patch fixes the issue, although it took a little tweaking to get it to apply cleanly. I'm working with Sam. This is what I applied, and it works: diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 340a92d..2c87b72 100644 ---

Re: Unable to mount multiple subvolumes of a single disk

2014-09-16 Thread Chris Mason
On 09/15/2014 12:09 PM, Anand Jain wrote: Sam, Thanks for reporting. Can you apply the following diff on top of 3.17rc5 and check if it helps. --- diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e9676a4..1224b61 100644 --- a/fs/btrfs/volumes.c +++

Re: Unable to mount multiple subvolumes of a single disk

2014-09-16 Thread Anand Jain
Stefan, Can you pls send me the output for cat /etc/fstab | egrep btrfs cat /proc/self/mounts | egrep btrfs mount | egrep btrfs Thanks, Anand On 17/09/2014 05:08, Stefan G. Weichinger wrote: Am 15.09.2014 um 19:42 schrieb Anand Jain: Sam, In the above context, Can you

Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Sam Thursfield
Hi! I'm having an issue with the 3.17rc5 kernel which prevents having multiple subvolumes of the same disk mounted. I'm not sure exactly the cause. I thought it might be because in my system the root file system is itself a subvolume of the disk I'm trying to mount. But if I create a second

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Chris Mason
On 09/15/2014 11:13 AM, Sam Thursfield wrote: Hi! I'm having an issue with the 3.17rc5 kernel which prevents having multiple subvolumes of the same disk mounted. I'm not sure exactly the cause. I thought it might be because in my system the root file system is itself a subvolume of the

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Anand Jain
Sam, Thanks for reporting. Can you apply the following diff on top of 3.17rc5 and check if it helps. --- diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e9676a4..1224b61 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -533,7 +533,7 @@ static noinline int

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Anand Jain
Logs from Sam, tells the problem clearly. mount is using /dev/sda, but mount error message and kernel is using /dev/vda. -- $ mount /dev/sda /home -t btrfs -o subvol=/state/home,defaults,rw,noatime mount: /dev/vda is already mounted or /home busy /dev/vda is

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Sam Thursfield
Hi Anand On 15/09/14 17:09, Anand Jain wrote: Sam, Thanks for reporting. Can you apply the following diff on top of 3.17rc5 and check if it helps. The patch fixes the issue, although it took a little tweaking to get it to apply cleanly. --- diff --git a/fs/btrfs/volumes.c

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Sam Thursfield
On 15/09/14 17:42, Anand Jain wrote: Logs from Sam, tells the problem clearly. mount is using /dev/sda, but mount error message and kernel is using /dev/vda. -- $ mount /dev/sda /home -t btrfs -o subvol=/state/home,defaults,rw,noatime mount: /dev/vda is already mounted

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Anand Jain
Hi Sam, Thanks for verifying. On 16/09/2014 01:13, Sam Thursfield wrote: Hi Anand On 15/09/14 17:09, Anand Jain wrote: Sam, Thanks for reporting. Can you apply the following diff on top of 3.17rc5 and check if it helps. The patch fixes the issue, although it took a little tweaking

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread Anand Jain
The patch fixes the issue, although it took a little tweaking to get it to apply cleanly. Sam, In the above context, Can you pls share the btrfs fi show output ? Thanks, Anand -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: Unable to mount multiple subvolumes of a single disk

2014-09-15 Thread xavier.gn...@gmail.com
This diff on top of 3.17rc5 also fixes the issue on my box (encrypted /home subvolume) Xavier Hi Sam, Thanks for verifying. On 16/09/2014 01:13, Sam Thursfield wrote: Hi Anand On 15/09/14 17:09, Anand Jain wrote: Sam, Thanks for reporting. Can you apply the following diff on top