Re: [PATCH v3] Re: btrfs does not work on usermode linux

2011-04-13 Thread Chris Mason
Excerpts from Sergei Trofimovich's message of 2011-04-12 17:23:33 -0400: On Mon, 11 Apr 2011 15:50:48 -0400 Josef Bacik jo...@redhat.com wrote: On 04/11/2011 03:44 PM, Sergei Trofimovich wrote: Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first

Re: [PATCH v3] Re: btrfs does not work on usermode linux

2011-04-13 Thread Sergei Trofimovich
On Wed, 13 Apr 2011 07:32:59 -0400 Chris Mason chris.ma...@oracle.com wrote: This is in the master branch now, please give it another test. Thanks a lot for bisecting down and patching! Tested on btrfs-unstable/master. Works correctly. Reverting 3387206f26e1b48703e810175b98611a4fd8e8ea (to

Re: [PATCH v3] Re: btrfs does not work on usermode linux

2011-04-12 Thread Sergei Trofimovich
On Mon, 11 Apr 2011 15:50:48 -0400 Josef Bacik jo...@redhat.com wrote: On 04/11/2011 03:44 PM, Sergei Trofimovich wrote: Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first when found out usermode linux crash on btrfs. ... Fair enough, BUG_ON() it is.

Re: [PATCH v2] Re: btrfs does not work on usermode linux

2011-04-11 Thread Josef Bacik
On 04/10/2011 04:58 PM, Sergei Trofimovich wrote: On Sun, 10 Apr 2011 23:24:03 +0300 Sergei Trofimovichsly...@gmail.com wrote: Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first when found out usermode linux crash on btrfs. Changes since v1:

[PATCH v3] Re: btrfs does not work on usermode linux

2011-04-11 Thread Sergei Trofimovich
Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first when found out usermode linux crash on btrfs. Changes since v2: - Code style cleanup - 2 versions of patch: BUG_ON and WARN_ON variants, _but_ see below why I prefer BUG_ON Changes since v1:

Re: [PATCH v3] Re: btrfs does not work on usermode linux

2011-04-11 Thread Niklas Schnelle
I think the problem here is that memcpy beahviour changed in recent glibc in this regard see here http://lwn.net/Articles/414467/ On Mon, 2011-04-11 at 22:44 +0300, Sergei Trofimovich wrote: Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first when found

Re: [PATCH v3] Re: btrfs does not work on usermode linux

2011-04-11 Thread Josef Bacik
On 04/11/2011 03:44 PM, Sergei Trofimovich wrote: Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first when found out usermode linux crash on btrfs. Changes since v2: - Code style cleanup - 2 versions of patch: BUG_ON and WARN_ON variants, _but_ see below

btrfs does not work on usermode linux

2011-04-10 Thread Sergei Trofimovich
According to https://btrfs.wiki.kernel.org/index.php/Debugging_Btrfs_with_GDB UML did work once. Now it corrupts data and triggers BUG_ON once you start to use it. I tried both 2.6.38 and 2.6.39-rc2 (x86_64) I need some help to track it down. doing 'touch `seq 1 11`; rm 11' kills the kernel:

Re: btrfs does not work on usermode linux

2011-04-10 Thread Sergei Trofimovich
On Sun, 10 Apr 2011 13:37:10 +0300 Sergei Trofimovich sly...@gmail.com wrote: According to https://btrfs.wiki.kernel.org/index.php/Debugging_Btrfs_with_GDB UML did work once. Now it corrupts data and triggers BUG_ON once you start to use it. I tried both 2.6.38 and 2.6.39-rc2 (x86_64) I

Re: btrfs does not work on usermode linux

2011-04-10 Thread Sergei Trofimovich
According to https://btrfs.wiki.kernel.org/index.php/Debugging_Btrfs_with_GDB UML did work once. Now it corrupts data and triggers BUG_ON once you start to use it. I tried both 2.6.38 and 2.6.39-rc2 (x86_64) I need some help to track it down. doing 'touch `seq 1 11`; rm 11'

[PATCH v2] Re: btrfs does not work on usermode linux

2011-04-10 Thread Sergei Trofimovich
On Sun, 10 Apr 2011 23:24:03 +0300 Sergei Trofimovich sly...@gmail.com wrote: Fix data corruption caused by memcpy() usage on overlapping data. I've observed it first when found out usermode linux crash on btrfs. Changes since v1: else src_kaddr = dst_kaddr; +