Re: superfluous else if ()

2014-05-12 Thread David Sterba
On Fri, May 09, 2014 at 07:12:54PM +0200, Toralf Förster wrote: But what came into my mind, wouldn't the following avoid such question in future ? : Yes and though it's a tiny change, I don't mind a patch for that. } else { /* ret 0 */ The comment is IMHO

Re: superfluous else if ()

2014-05-09 Thread David Sterba
On Sat, Apr 26, 2014 at 08:57:00PM +0200, Toralf Förster wrote: /me wonders if this if (ret = 0) { /* Add an item for the type for the first time */ eb = path-nodes[0]; slot = path-slots[0]; offset =

superfluous else if ()

2014-04-26 Thread Toralf Förster
/me wonders if this if (ret = 0) { /* Add an item for the type for the first time */ eb = path-nodes[0]; slot = path-slots[0]; offset = btrfs_item_ptr_offset(eb, slot); } else if (ret == -EEXIST) { /*