Re: [RFC][PATCH] introduce a btrfs_iget helper

2008-07-19 Thread Balaji Rao
On Saturday 19 July 2008 12:17:06 am Chris Mason wrote: On Mon, 2008-07-14 at 11:52 +0530, Balaji Rao wrote: Hello, As suggest by Cristoph, this patch factors out a btrfs_iget helper from btrfs_lookup. This is useful in situations such as in NFS export ops. Comments ? No objections,

single disk reed solomon codes

2008-07-19 Thread Ahmed Kamal
Hi, Since btrfs is someday going to be the default FS for Linux, and will be on so many single disk PCs and laptops, I was thinking it should be a good idea to insert some redundancy in single disk deployments. Of course it can help with disk failures, since it's obviously a single disk, but it

Re: single disk reed solomon codes

2008-07-19 Thread Gerald Nowitzky
ECC codes like Reed-Solomon are very useful to recognize and locate random bit-errors. On a HDD as a unit, as it is seen from OS level, I don't think it will be of any help: When a HDD drive reads a sector from disk, it does a whole bunch of error recognition and correction measures. Usually

Re: single disk reed solomon codes

2008-07-19 Thread David Woodhouse
On Sat, 2008-07-19 at 15:21 +0300, Ahmed Kamal wrote: Hi, Since btrfs is someday going to be the default FS for Linux, and will be on so many single disk PCs and laptops, I was thinking it should be a good idea to insert some redundancy in single disk deployments. Of course it can help with

Re: single disk reed solomon codes

2008-07-19 Thread Ahmed Kamal
RS-based error correction for themselves. If we're unlucky in our choice of error correction, it might even be possible to end up in a situation where the only errors we'd _see_ are the ones which were uncorrectable. but since at the FS level, the redundancy would be at a different place,

Re: single disk reed solomon codes

2008-07-19 Thread Joe Peterson
Gerald Nowitzky wrote: When a HDD drive reads a sector from disk, it does a whole bunch of error recognition and correction measures. Usually there are, at least, two layers of error correction with different bit spreads on it. *If* this still isn't enough, it is very likely that the whole

Re: single disk reed solomon codes

2008-07-19 Thread Bron Gondwana
On Sat, Jul 19, 2008 at 04:15:43PM -0600, Joe Peterson wrote: Gerald Nowitzky wrote: When a HDD drive reads a sector from disk, it does a whole bunch of error recognition and correction measures. Usually there are, at least, two layers of error correction with different bit spreads on