RE: [PATCH] btrfs file write debugging patch

2011-03-01 Thread Zhong, Xin
Is your system running out of memory or is there any other thread like flush-btrfs competing for the same page? I can only see one process in your ftrace log. You may need to trace all btrfs.ko function calls instead of a single process. Thanks! -Original Message- From:

Re: [PATCH V2] Btrfs: Batched discard support for btrfs

2011-03-01 Thread Li Dongyang
On Friday, February 25, 2011 04:16:27 PM Li Dongyang wrote: Thanks for your comments, here is the updated patch. I've tested it with xfstests 251(thanks to Lukas), and it looks fine to me. when we call btrfs_map_block() for RAID0/1/10/ or DUP, it only returns a single stripe length at most,

RE: [PATCH] btrfs file write debugging patch

2011-03-01 Thread Zhong, Xin
Hi Mitch, I suspect there's a lock contention between flush-btrfs (lock_dellalloc_pages) and btrfs_file_aio_write. However I can not recreate it locally. Could you please try below patch? Thanks! diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 65338a1..b9d0929 100644 --- a/fs/btrfs/file.c

Re: [PATCH] btrfs file write debugging patch

2011-03-01 Thread Mitch Harder
On Tue, Mar 1, 2011 at 4:14 AM, Zhong, Xin xin.zh...@intel.com wrote: Is your system running out of memory or is there any other thread like flush-btrfs competing for the same page? There's no sign of memory pressure. Although I only have 1 GB in this box, I'm still show ~1/2 GB RAM free

Re: [PATCH] btrfs file write debugging patch

2011-03-01 Thread Mitch Harder
On Tue, Mar 1, 2011 at 5:56 AM, Zhong, Xin xin.zh...@intel.com wrote: Hi Mitch, I suspect there's a lock contention between flush-btrfs (lock_dellalloc_pages) and btrfs_file_aio_write. However I can not recreate it locally. Could you please try below patch? Thanks! diff --git

[2.6.38-rc6, patch] fix delayed_refs locking on error path...

2011-03-01 Thread Daniel J Blueman
Correctly unlock delayed_refs in the error case. Signed-off-by: Daniel J Blueman daniel.blue...@gmail.com diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index e1aa8d6..c48d699 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2787,6 +2787,7 @@ static int

[2.6.38-rc6, patch] mark some internal functions static...

2011-03-01 Thread Daniel J Blueman
Prevent needless exporting of internal functions from compilation units by marking them static. Signed-off-by: Daniel J Blueman daniel.blue...@gmail.com diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index b5baff0..5e49196 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -74,7 +74,7 @@

Re: [PATCH] btrfs file write debugging patch

2011-03-01 Thread Xin Zhong
Hi, Mitch I think you can config ftrace to just trace function calls of btrfs.ko which will save a lot of trace buffer space. See below command: #echo ':mod:btrfs' /sys/kernel/debug/tracing/set_ftrace_filterAnd please send out the full ftrace log again. Another helpful information might be

btrfs wishlist

2011-03-01 Thread Roy Sigurd Karlsbakk
Hi all Having managed ZFS for about two years, I want to post a wishlist. INCLUDED IN ZFS - Mirror existing single-drive filesystem, as in 'zfs attach' - RAIDz-stuff - single and hopefully multiple-parity RAID configuration with block-level checksumming - Background scrub/fsck - Pool-like

Re: btrfs wishlist

2011-03-01 Thread Chris Mason
Excerpts from Roy Sigurd Karlsbakk's message of 2011-03-01 13:35:42 -0500: Hi all Having managed ZFS for about two years, I want to post a wishlist. INCLUDED IN ZFS - Mirror existing single-drive filesystem, as in 'zfs attach' This one is easy, we do plan on adding it. - RAIDz-stuff -

Re: btrfs wishlist

2011-03-01 Thread Freddie Cash
On Tue, Mar 1, 2011 at 10:39 AM, Chris Mason chris.ma...@oracle.com wrote: Excerpts from Roy Sigurd Karlsbakk's message of 2011-03-01 13:35:42 -0500: - Pool-like management with multiple RAIDs/mirrors (VDEVs) We have a pool of drives nowI'm not sure exactly what the vdevs are. This

Re: [PATCH] btrfs file write debugging patch

2011-03-01 Thread Mitch Harder
2011/3/1 Xin Zhong thierryzh...@hotmail.com: Hi, Mitch I think you can config ftrace to just trace function calls of btrfs.ko which will save a lot of trace buffer space. See below command: #echo ':mod:btrfs' /sys/kernel/debug/tracing/set_ftrace_filterAnd please send out the full ftrace

Re: [PATCH] btrfs file write debugging patch

2011-03-01 Thread Piotr Szymaniak
On Mon, Feb 28, 2011 at 02:20:22PM -0600, Mitch Harder wrote: As promised, I'm put together a modified file.c with many trace_printk debugging statements to augment the ftrace. *snip* Just my few cents. I've applied the patch from Chris Mason (Sun, 27 Feb 2011 20:46:05 -0500) and this one from