Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-31 Thread Christoph Hellwig
On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: This is a simple patch to allow reflinks to be made crossing subvolume boundaries. NAK. subvolumes will have to become vfsmounts sooner or later, and we really must not support any operations spanning mountpoints. -- To unsubscribe

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-31 Thread Arne Jansen
On 31.03.2011 08:36, Christoph Hellwig wrote: On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: This is a simple patch to allow reflinks to be made crossing subvolume boundaries. NAK. subvolumes will have to become vfsmounts sooner or later, and we really must not support any

[PATCH] Btrfs: fix subvolume mount by name problem when default mount subvolume is set

2011-03-31 Thread Zhong, Xin
We create two subvolumes (meego_root and meego_home) in btrfs root directory. And set meego_root as default mount subvolume. After we remount btrfs, meego_root is mounted to top directory by default. Then when we try to mount meego_home (subvol=meego_home) to a subdirectory, it failed. The problem

[PATCH] btrfs: clear __GFP_FS flag in the space cache inode

2011-03-31 Thread liubo
From: Miao Xie mi...@cn.fujitsu.com the object id of the space cache inode's key is allocated from the relative root, just like the regular file. So we can't identify space cache inode by checking the object id of the inode's key, and we have to clear __GFP_FS flag at the time we look up the

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-31 Thread Chris Mason
Excerpts from Christoph Hellwig's message of 2011-03-31 02:36:36 -0400: On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: This is a simple patch to allow reflinks to be made crossing subvolume boundaries. NAK. subvolumes will have to become vfsmounts sooner or later, and we

checkpoints to often

2011-03-31 Thread krz...@gmail.com
There should be a way to make automatic checkpoints less frequent. On the busy ssd I have about 7 cp every second. If it were for example once every 5 minutes then one could set garbage removal every few days. Also garbage removal should have option to clean only if like 90% of drive is used.

Re: checkpoints to often

2011-03-31 Thread Chris Mason
Excerpts from krz...@gmail.com's message of 2011-03-31 10:30:51 -0400: There should be a way to make automatic checkpoints less frequent. On the busy ssd I have about 7 cp every second. If it were for example once every 5 minutes then one could set garbage removal every few days. Also garbage

Re: [PATCH] Btrfs - use %pU to print fsid

2011-03-31 Thread Mitch Harder
On Wed, Feb 9, 2011 at 8:05 AM, Ilya Dryomov idryo...@gmail.com wrote: Get rid of FIXME comment.  Uuids from dmesg are now the same as uuids given by btrfs-progs. Signed-off-by: Ilya Dryomov idryo...@gmail.com ---  fs/btrfs/volumes.c |    8 ++--  1 files changed, 2 insertions(+), 6

[PATCH] Btrfs: fix free space cache when there are pinned extents and clusters

2011-03-31 Thread Josef Bacik
I noticed a huge problem with the free space cache that was presenting as an early ENOSPC. Turns out when writing the free space cache out I forgot to take into account pinned extents and more importantly clusters. This would result in us leaking free space everytime we unmounted the filesystem

Re: Do not use free space caching!

2011-03-31 Thread Calvin Walton
On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote: Hello, Just found a big bug in the free space caching stuff that will result in early ENOSPC. I'm working on fixing this bug, but it won't be until tomorrow that I'll have it completely working, so for now make sure to mount -o

Re: [PATCH 1/3] VFS/ioctl: Add punching-hole support to ioctl().

2011-03-31 Thread Sunil Mushran
Frankly I see no point extending the ioctl interface when we have a syscall interface. On 03/31/2011 12:33 AM, Tristan Ye wrote: We're currently support two paths from VFS to preallocate unwritten extents(from FS_IOC_RESVSP, or fallocate()), likewise, behavior of punching-hole should be treated

Re: [PATCH] Btrfs - use %pU to print fsid

2011-03-31 Thread Ilya Dryomov
On Thu, Mar 31, 2011 at 12:14:14PM -0500, Mitch Harder wrote: On Wed, Feb 9, 2011 at 8:05 AM, Ilya Dryomov idryo...@gmail.com wrote: Get rid of FIXME comment.  Uuids from dmesg are now the same as uuids given by btrfs-progs. Signed-off-by: Ilya Dryomov idryo...@gmail.com ---  

Re: [PATCH 1/3] VFS/ioctl: Add punching-hole support to ioctl().

2011-03-31 Thread Josef Bacik
On Thu, Mar 31, 2011 at 02:14:43PM -0700, Sunil Mushran wrote: Frankly I see no point extending the ioctl interface when we have a syscall interface. I'd even go so far as to say we could probably axe the xfs and ocfs2 ioctls since we have the fallocate interface :). Thanks, Josef -- To

Re: Do not use free space caching!

2011-03-31 Thread Josef Bacik
On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote: On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote: Hello, Just found a big bug in the free space caching stuff that will result in early ENOSPC. I'm working on fixing this bug, but it won't be until tomorrow that I'll

Re: [PATCH 1/3] VFS/ioctl: Add punching-hole support to ioctl().

2011-03-31 Thread Joel Becker
On Thu, Mar 31, 2011 at 06:56:18PM -0400, Josef Bacik wrote: On Thu, Mar 31, 2011 at 02:14:43PM -0700, Sunil Mushran wrote: Frankly I see no point extending the ioctl interface when we have a syscall interface. I'd even go so far as to say we could probably axe the xfs and ocfs2 ioctls

Re: [PATCH 1/3] VFS/ioctl: Add punching-hole support to ioctl().

2011-03-31 Thread Josef Bacik
On Thu, Mar 31, 2011 at 04:44:55PM -0700, Joel Becker wrote: On Thu, Mar 31, 2011 at 06:56:18PM -0400, Josef Bacik wrote: On Thu, Mar 31, 2011 at 02:14:43PM -0700, Sunil Mushran wrote: Frankly I see no point extending the ioctl interface when we have a syscall interface. I'd even

Re: [PATCH] Btrfs: fix compile warning from __btrfs_map_block

2011-03-31 Thread liubo
On 03/31/2011 08:10 PM, Chris Mason wrote: Excerpts from liubo's message of 2011-03-31 05:45:20 -0400: While compile btrfs modules on 32bit box, I encounter the following: WARNING: __umoddi3 [fs/btrfs/btrfs.ko] undefined! The WARNING comes from that __btrfs_map_block does not use do_div()

Re: [PATCH 1/2] Btrfs: fix OOPS of empty filesystem after balance

2011-03-31 Thread liubo
On 03/30/2011 07:58 PM, Arne Jansen wrote: Am 10.03.2011 13:28, schrieb Chris Mason: Excerpts from liubo's message of 2011-03-10 03:50:27 -0500: On 03/07/2011 10:13 AM, liubo wrote: btrfs will remove unused block groups after balance. When a empty filesystem is balanced, the block group with