[RFC PATCH] Trace: use unsigned long long in trace print frames

2011-04-01 Thread liubo
While adding tracepoint for btrfs, I got a problem: btrfs uses some macros with ULL type, but tracepoint's macros, __print_[flags,symbols](), only have unsigned long, so on 32bit box there will be 64-32 truncate WARNINGs when compiling. Here I'm inclined to make the replacement to clear those

Re: [PATCH] Btrfs: fix free space cache when there are pinned extents and clusters

2011-04-01 Thread Li Zefan
+ spin_lock(block_group-tree_lock); + if (btrfs_block_group_free_space(block_group) != This function call can be replaced by block_group-free_space, so we don't have to iterate the tree. (This function gets removed in my patchset for inode number caching) +

Re: btrfs balancing start - and stop?

2011-04-01 Thread Helmut Hullen
Hallo, Struan, Du meintest am 01.04.11: 1) Is the balancing operation expected to take many hours (or days?) on a filesystem such as this? Or are there known issues with the algorithm that are yet to be addressed? May be. Balancing about 15 GByte needed about 2 hours (or less), balancing

Re: [PATCH] Btrfs: fix free space cache when there are pinned extents and clusters

2011-04-01 Thread Josef Bacik
On Fri, Apr 01, 2011 at 03:56:33PM +0800, Li Zefan wrote: + spin_lock(block_group-tree_lock); + if (btrfs_block_group_free_space(block_group) != This function call can be replaced by block_group-free_space, so we don't have to iterate the tree. (This function gets removed in my

Re: btrfs balancing start - and stop?

2011-04-01 Thread Konstantinos Skarlatos
On 1/4/2011 3:12 μμ, Helmut Hullen wrote: Hallo, Struan, Du meintest am 01.04.11: 1) Is the balancing operation expected to take many hours (or days?) on a filesystem such as this? Or are there known issues with the algorithm that are yet to be addressed? May be. Balancing about 15 GByte

Re: Do not use free space caching!

2011-04-01 Thread Konstantinos Skarlatos
On 1/4/2011 1:59 πμ, Josef Bacik wrote: On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote: On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote: Hello, Just found a big bug in the free space caching stuff that will result in early ENOSPC. I'm working on fixing this bug, but it

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-01 Thread Christoph Hellwig
On Thu, Mar 31, 2011 at 08:02:22AM -0400, Chris Mason wrote: Excerpts from Christoph Hellwig's message of 2011-03-31 02:36:36 -0400: On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: This is a simple patch to allow reflinks to be made crossing subvolume boundaries. NAK.

Re: btrfs balancing start - and stop?

2011-04-01 Thread Helmut Hullen
Hallo, Konstantinos, Du meintest am 01.04.11: dmesg counts down the number of remaining jobs. are you sure? here is a snippet of dmesg from a balance i did yesterday (2.6.38.1) btrfs: relocating block group 15338569728 flags 9 btrfs: found 17296 extents btrfs: found 17296 extents btrfs:

Re: [RFC PATCH] Trace: use unsigned long long in trace print frames

2011-04-01 Thread Steven Rostedt
On Fri, 2011-04-01 at 14:42 +0800, liubo wrote: While adding tracepoint for btrfs, I got a problem: btrfs uses some macros with ULL type, but tracepoint's macros, __print_[flags,symbols](), only have unsigned long, so on 32bit box there will be 64-32 truncate WARNINGs when compiling. Here

Re: btrfs balancing start - and stop?

2011-04-01 Thread Hugo Mills
On Fri, Apr 01, 2011 at 03:36:00PM +0200, Helmut Hullen wrote: Hallo, Konstantinos, Du meintest am 01.04.11: dmesg counts down the number of remaining jobs. are you sure? here is a snippet of dmesg from a balance i did yesterday (2.6.38.1) btrfs: relocating block group

Re: btrfs balancing start - and stop?

2011-04-01 Thread Konstantinos Skarlatos
On 1/4/2011 4:37 μμ, Hugo Mills wrote: On Fri, Apr 01, 2011 at 04:22:39PM +0300, Konstantinos Skarlatos wrote: On 1/4/2011 3:12 μμ, Helmut Hullen wrote: Du meintest am 01.04.11: dmesg counts down the number of remaining jobs. are you sure? here is a snippet of dmesg from a balance i did

[PATCH] Btrfs: fix free space cache when there are pinned extents and clusters V2

2011-04-01 Thread Josef Bacik
I noticed a huge problem with the free space cache that was presenting as an early ENOSPC. Turns out when writing the free space cache out I forgot to take into account pinned extents and more importantly clusters. This would result in us leaking free space everytime we unmounted the filesystem

Re: Cannot set-default back to ID 0

2011-04-01 Thread arand
Bernhard Schmidt berni at birkenwald.de writes: Hi, a recent Ubuntu upgrade killed my system. Luckily I had done a btrfs snapshot before, so I set the particular subvolume as default using # btrfs subvolume set-default 261 /mnt from a rescue system and was back up in no time. I then

Re: [Ocfs2-devel] [PATCH 1/3] VFS/ioctl: Add punching-hole support to ioctl().

2011-04-01 Thread Joel Becker
On Thu, Mar 31, 2011 at 08:34:50PM -0400, Josef Bacik wrote: More interesting would be to bring the ioctls up to generic code and have them backended by fallocate. I'm not sure they map without looking deeper, but it's at least an idea. I just did a cursory look and it seems like

Re: Do not use free space caching!

2011-04-01 Thread Calvin Walton
On Thu, 2011-03-31 at 18:59 -0400, Josef Bacik wrote: On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote: On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote: Hello, Just found a big bug in the free space caching stuff that will result in early ENOSPC. I'm working on

Re: Do not use free space caching!

2011-04-01 Thread Chris Mason
Excerpts from Calvin Walton's message of 2011-04-01 13:56:51 -0400: On Thu, 2011-03-31 at 18:59 -0400, Josef Bacik wrote: On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote: On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote: Hello, Just found a big bug in the free

Re: btrfs balancing start - and stop?

2011-04-01 Thread Stephane Chazelas
On Fri, 2011-04-01 at 14:12 +0200, Helmut Hullen wrote: Hallo, Struan, Du meintest am 01.04.11: 1) Is the balancing operation expected to take many hours (or days?) on a filesystem such as this? Or are there known issues with the algorithm that are yet to be addressed? May be.

On masking access to snapshots thru single path

2011-04-01 Thread João Eduardo Luís
Hello all, I've been trying to use btrfs with a very specific purpose during my MSc thesis, and now I would very much appreciate any comments you may have on a given issue. Currently I'm trying to mask accesses to different snapshots by different processes, while still using the same FS entry

Re: btrfs balancing start - and stop?

2011-04-01 Thread Helmut Hullen
Hallo, Stephane, Du meintest am 01.04.11: balancing about 2 TByte needed about 20 hours. [...] I've got a balance running since Monday on a 9TB volume (3.5 of which are used, 3.2 allegedly free), showing no sign of finishing soon. Should I be worried? Using /proc/sys/vm/block_dump, I can

another messed-up btrfs

2011-04-01 Thread Martin Fahr
Hi, I have put a linux system on an external SSD recently, using btrfs for both root (/) and /home. After a couple of hibernation cycles the system got stuck and I had to reboot it ignoring the memory image on disk. Unfortunately, even a normal reboot did not work anymore. The kernel

Re: another messed-up btrfs

2011-04-01 Thread Peter Stuge
Martin Fahr wrote: btrfsck: disk-io.c:741: open_ctree_fd: Assertion `!(!tree_root-node)' failed. My fs is also broken this way, though for me it happened after resizing the fs and then partition. I still need to go back to the list thread and do some work on my image. The usual questions: Is

Re: another messed-up btrfs

2011-04-01 Thread Viacheslav Dobromyslov
Hi. Still waiting for this http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg08370.html Sincerely, Viacheslav Dobromyslov On Fri, Apr 1, 2011 at 8:01 PM, Peter Stuge pe...@stuge.se wrote: Martin Fahr wrote: btrfsck: disk-io.c:741: open_ctree_fd: Assertion `!(!tree_root-node)'

Re: [RFC PATCH] Trace: use unsigned long long in trace print frames

2011-04-01 Thread liubo
On 04/01/2011 09:49 PM, Steven Rostedt wrote: On Fri, 2011-04-01 at 14:42 +0800, liubo wrote: While adding tracepoint for btrfs, I got a problem: btrfs uses some macros with ULL type, but tracepoint's macros, __print_[flags,symbols](), only have unsigned long, so on 32bit box there will be

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-01 Thread Fajar A. Nugraha
On Fri, Apr 1, 2011 at 8:40 PM, Chris Mason chris.ma...@oracle.com wrote: Excerpts from Christoph Hellwig's message of 2011-04-01 09:34:05 -0400: I don't think it's a good idea to introduce any user visible operations over subvolume boundaries.  Currently we don't have any operations over