Re: [PATCH 1/4] fs: add SEEK_HOLE and SEEK_DATA flags

2011-08-20 Thread Marco Stornelli
Hi, Il 28/06/2011 17:33, Josef Bacik ha scritto: This just gets us ready to support the SEEK_HOLE and SEEK_DATA flags. Turns out using fiemap in things like cp cause more problems than it solves, so lets try and give userspace an interface that doesn't suck. We need to match solaris here, and

Re: [PATCH 1/4] fs: add SEEK_HOLE and SEEK_DATA flags

2011-08-20 Thread Marco Stornelli
Il 20/08/2011 11:41, Marco Stornelli ha scritto: Hi, Il 28/06/2011 17:33, Josef Bacik ha scritto: This just gets us ready to support the SEEK_HOLE and SEEK_DATA flags. Turns out using fiemap in things like cp cause more problems than it solves, so lets try and give userspace an interface that

Re: [PATCH] BTRFS: Free inode mutex on lseek error

2011-08-20 Thread Josef Bacik
On 08/19/2011 08:07 PM, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Introduced with b26751575a9aa55fd6dbf3febde3ff06dfadc44f This has already been fixed by 9a4327ca1f45f82edad7dc0a4e52ce9316e0950c Thanks, Josef -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2] Btrfs: use do_div to avoid compile errors on 32bit box

2011-08-20 Thread Josef Bacik
On 08/19/2011 10:17 PM, Liu Bo wrote: When doing div operation of u64 type, we need to be careful and use do_div to avoid compile ERROR on 32bit box: ERROR: __udivdi3 [fs/btrfs/btrfs.ko] undefined! make[1]: *** [__modpost] Error 1 v1-v2: - fix stupid do_div() with type signed integer.

[PATCH] Btrfs: fix 64 bit divide problem

2011-08-20 Thread Josef Bacik
This fixes a regression introduced by cdcb725c05fe0cb71777c66ddc2445fedbbb3c59 In cases where we need to divide/multiply by 2 we should just left/right shift respectively, and in cases where theres N number of devices use do_div. Also make the counters u64 to match up with rw_devices. Thanks,

Re: [PATCH] BTRFS: Free inode mutex on lseek error

2011-08-20 Thread Andi Kleen
On Sat, Aug 20, 2011 at 08:08:25AM -0400, Josef Bacik wrote: On 08/19/2011 08:07 PM, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Introduced with b26751575a9aa55fd6dbf3febde3ff06dfadc44f This has already been fixed by 9a4327ca1f45f82edad7dc0a4e52ce9316e0950c It's not.

Re: [PATCH] BTRFS: Free inode mutex on lseek error

2011-08-20 Thread Josef Bacik
On Sat, Aug 20, 2011 at 02:53:17PM +0200, Andi Kleen wrote: On Sat, Aug 20, 2011 at 08:08:25AM -0400, Josef Bacik wrote: On 08/19/2011 08:07 PM, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Introduced with b26751575a9aa55fd6dbf3febde3ff06dfadc44f This has already

Re: [GIT PULL] Btrfs updates

2011-08-20 Thread Chris Mason
Excerpts from Sage Weil's message of 2011-08-18 17:51:54 -0400: Hi Chris, Josef, Can some form of the clone ioctl transaction start reservation fix go in soon as well? That hits a BUG_ON every time. Sorry Sage, I thought I had that one. I'll get it in the next pull. -chris -- To

Re: [PATCH 1/4] fs: add SEEK_HOLE and SEEK_DATA flags

2011-08-20 Thread Sunil Mushran
On 08/20/2011 03:03 AM, Marco Stornelli wrote: Il 20/08/2011 11:41, Marco Stornelli ha scritto: Hi, Il 28/06/2011 17:33, Josef Bacik ha scritto: This just gets us ready to support the SEEK_HOLE and SEEK_DATA flags. Turns out using fiemap in things like cp cause more problems than it solves,

Re: [PATCH 1/4] fs: add SEEK_HOLE and SEEK_DATA flags

2011-08-20 Thread Marco Stornelli
Il 20/08/2011 17:36, Sunil Mushran ha scritto: On 08/20/2011 03:03 AM, Marco Stornelli wrote: Il 20/08/2011 11:41, Marco Stornelli ha scritto: Hi, Il 28/06/2011 17:33, Josef Bacik ha scritto: This just gets us ready to support the SEEK_HOLE and SEEK_DATA flags. Turns out using fiemap in

Re: Applications using fsync cause hangs for several seconds every few minutes

2011-08-20 Thread Andrew Guertin
On 08/18/2011 10:38 AM, Chris Mason wrote: Excerpts from Andrew Guertin's message of 2011-08-11 21:13:18 -0400: On 08/09/2011 05:29 PM, Andrew Guertin wrote: I have not tried 3.1-rc1, but plan to soon. I've tested now, this does still occur in 3.1-rc1. Ok, I had high hopes that the btrfs

Re: [PATCH v2] Btrfs: use do_div to avoid compile errors on 32bit box

2011-08-20 Thread Linus Torvalds
On Sat, Aug 20, 2011 at 5:21 AM, Josef Bacik jo...@redhat.com wrote: I think Linus was less complaining about how you're dividing here and more about the fact that you are.  A divide by 2 is the same as a 1.  I'll send a patch to fix this.  Thanks, Indeed. A single-bit 64-bit double shift