Re: btrfs issue with mariadb incremental backup

Hi Chris, The kernel version that I test is "4.4.0-89-generic" as I tested on ubuntu lxd If I want to change the kernel version I have to upgrade the host box. As you suggest the rsync to compare the subvolumes. I found the point. the subvolumes are different only after I start to del old

Re: [PATCH v5 3/5] btrfs: Add zstd support

On 8/10/17, 7:13 PM, "Adam Borowski" wrote: > On Wed, Aug 09, 2017 at 07:39:02PM -0700, Nick Terrell wrote: >> Add zstd compression and decompression support to BtrFS. > > Re-tested on arm64, amd64 and i386, this time everything seems fine so far. > > As I'm too lazy to

Re: [PATCH v5 3/5] btrfs: Add zstd support

On Wed, Aug 09, 2017 at 07:39:02PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. Re-tested on arm64, amd64 and i386, this time everything seems fine so far. As I'm too lazy to have a separate test setup for the zlib level patch, I'm using a dummy

Re: [PATCH v3] Btrfs: fix out of bounds array access while reading extent buffer

Hugo Mills posted on Wed, 09 Aug 2017 18:15:29 + as excerpted: > On Wed, Aug 09, 2017 at 11:10:16AM -0600, Liu Bo wrote: >> There is a cornel case that slip through the checkers in functions > ^^ corner > >Sorry, that's been bugging me every time it goes past. A cornel

Re: Replace missing disc => strange result!?

Cloud Admin posted on Thu, 10 Aug 2017 22:00:08 +0200 as excerpted: > Hi, > I had a disc failure and must replace it. I followed the description on > https://btrfs.wiki.kernel.org/index.php/Using_Btrfs_with_Multiple_Devi > ces and started the replacement. > Setup is a two disc RAID1! > After it

Replace missing disc => strange result!?

Hi, I had a disc failure and must replace it. I followed the description on https://btrfs.wiki.kernel.org/index.php/Using_Btrfs_with_Multiple_Devi ces and started the replacement. Setup is a two disc RAID1! After it was done, I called 'btrfs fi us /mn/btrfsroot' and I got the output below. What

Re: [PATCH v5 2/5] lib: Add zstd modules

On 2017-08-10 15:25, Hugo Mills wrote: On Thu, Aug 10, 2017 at 01:41:21PM -0400, Chris Mason wrote: On 08/10/2017 04:30 AM, Eric Biggers wrote: Theses benchmarks are misleading because they compress the whole file as a single stream without resetting the dictionary, which isn't how data will

Re: [PATCH v5 2/5] lib: Add zstd modules

On Thu, Aug 10, 2017 at 01:41:21PM -0400, Chris Mason wrote: > On 08/10/2017 04:30 AM, Eric Biggers wrote: > > > >Theses benchmarks are misleading because they compress the whole file as a > >single stream without resetting the dictionary, which isn't how data will > >typically be compressed in

Re: [PATCH v5 2/5] lib: Add zstd modules

On 8/10/17, 10:48 AM, "Austin S. Hemmelgarn" wrote: >On 2017-08-10 13:24, Eric Biggers wrote: >>On Thu, Aug 10, 2017 at 07:32:18AM -0400, Austin S. Hemmelgarn wrote: >>>On 2017-08-10 04:30, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote:

Re: [PATCH v5 2/5] lib: Add zstd modules

On 8/10/17, 1:30 AM, "Eric Biggers" wrote: > On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: >> >> It can compress at speeds approaching lz4, and quality approaching lzma. > > Well, for a very loose definition of "approaching", and certainly not at the > same

Re: [PATCH v5 2/5] lib: Add zstd modules

On 08/10/2017 03:00 PM, Eric Biggers wrote: On Thu, Aug 10, 2017 at 01:41:21PM -0400, Chris Mason wrote: On 08/10/2017 04:30 AM, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: The memory reported is the amount of memory the compressor requests. | Method

Re: [PATCH v5 2/5] lib: Add zstd modules

On Thu, Aug 10, 2017 at 01:41:21PM -0400, Chris Mason wrote: > On 08/10/2017 04:30 AM, Eric Biggers wrote: > >On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: > > >>The memory reported is the amount of memory the compressor requests. > >> > >>| Method | Size (B) | Time (s) | Ratio

Re: [PATCH v5 2/5] lib: Add zstd modules

On 2017-08-10 13:24, Eric Biggers wrote: On Thu, Aug 10, 2017 at 07:32:18AM -0400, Austin S. Hemmelgarn wrote: On 2017-08-10 04:30, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: It can compress at speeds approaching lz4, and quality approaching lzma.

Re: [PATCH v5 2/5] lib: Add zstd modules

On 08/10/2017 04:30 AM, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: The memory reported is the amount of memory the compressor requests. | Method | Size (B) | Time (s) | Ratio | MB/s| Adj MB/s | Mem (MB) |

Re: [PATCH v5 2/5] lib: Add zstd modules

On Thu, Aug 10, 2017 at 10:57:01AM -0400, Austin S. Hemmelgarn wrote: > Also didn't think to mention this, but I could see the max level > being very popular for use with SquashFS root filesystems used in > LiveCD's. Currently, they have to decide between read performance > and image size, while

Re: [PATCH v5 2/5] lib: Add zstd modules

On Thu, Aug 10, 2017 at 07:32:18AM -0400, Austin S. Hemmelgarn wrote: > On 2017-08-10 04:30, Eric Biggers wrote: > >On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: > >> > >>It can compress at speeds approaching lz4, and quality approaching lzma. > > > >Well, for a very loose

Re: [PATCH v5 2/5] lib: Add zstd modules

On 2017-08-10 07:32, Austin S. Hemmelgarn wrote: On 2017-08-10 04:30, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: It can compress at speeds approaching lz4, and quality approaching lzma. Well, for a very loose definition of "approaching", and certainly

Re: Btrfs umount hang

Here is a fresh snapshot hang example: Here kworker/u24:0 is blocked waiting on btrfs_tree_read_lock. And again underlaying is btrfs_search_slot after it has gone through cache_block_group. The other two has blocked on the same place in cache_block_group. So I can confirm it is hanging the same

Re: [PATCH v5 2/5] lib: Add zstd modules

On 2017-08-10 04:30, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: It can compress at speeds approaching lz4, and quality approaching lzma. Well, for a very loose definition of "approaching", and certainly not at the same time. I doubt there's a use case

Re: [PATCH v3 11/49] btrfs: avoid access to .bi_vcnt directly

> +static unsigned int get_bio_pages(struct bio *bio) > +{ > + unsigned i; > + struct bio_vec *bv; > + > + bio_for_each_segment_all(bv, bio, i) > + ; > + > + return i; > +} s/get_bio_pages/bio_nr_pages/ ? Also this seems like a useful helper for bio.h -- To

Re: [PATCH v5 2/5] lib: Add zstd modules

On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: > > It can compress at speeds approaching lz4, and quality approaching lzma. Well, for a very loose definition of "approaching", and certainly not at the same time. I doubt there's a use case for using the highest compression levels