Re: [PATCH 1/3] block: Document that bio_op() uses the data type of bio.bi_opf

chri...@redhat.com> > Cc: Christoph Hellwig <h...@lst.de> > Cc: Hannes Reinecke <h...@suse.de> > Cc: Damien Le Moal <damien.lem...@hgst.com> > --- Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn

Re: [PATCH 3/3] block: Improve bio_set_op_attrs() robustness

..@sandisk.com> > Cc: Mike Christie <mchri...@redhat.com> > Cc: Christoph Hellwig <h...@lst.de> > Cc: Hannes Reinecke <h...@suse.de> > Cc: Damien Le Moal <damien.lem...@hgst.com> > --- Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [PATCH 2/3] block, dm-crypt, btrfs: Introduce bio_flags()

lwig <h...@lst.de> > Cc: Hannes Reinecke <h...@suse.de> > Cc: Damien Le Moal <damien.lem...@hgst.com> > --- Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 07/13] block_dev: propagate bio_iov_iter_get_pages error in __blkdev_direct_IO

On 05/26/2017 10:56 AM, Christoph Hellwig wrote: > Once we move the block layer to its own status code we'll still want to > propagate the bio_iov_iter_get_pages, so restructure __blkdev_direct_IO > to take ret into account when returning the errno. > --- -ENOSIGNOFF? -- Johann

Re: [PATCH 0/6] v4 block refcount conversion patches

ions compare in performance (throughput and latency) vs atomics? It should be quite easy to measure against a null_blk device. Thanks a lot, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUS

[PATCH 0/6] btrfs: fix compiler warning with make W=1

like. As far as I can tell these variables have always been unused since they have been introduced. There are still warnings left emitted by kernel-doc but these are subject to another patchset, this one only addresses the warnings generated by gcc. Johannes Thumshirn (6): btrfs: remove unused

[PATCH 6/6] btrfs: unconditionally provide function prototypes from free-space-tree.h

-off-by: Johannes Thumshirn --- fs/btrfs/free-space-tree.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/btrfs/free-space-tree.h b/fs/btrfs/free-space-tree.h index 3133651d7d70..0f4db2ad68c8 100644 --- a/fs/btrfs/free-space-tree.h +++ b/fs/btrfs/free-space-tree.h @@ -27,7 +27,6 @@ int

[PATCH 4/6] btrfs: remove unused variable tree in bio_readpage_error()

btrfs. Signed-off-by: Johannes Thumshirn --- fs/btrfs/extent_io.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 0f8f9c035812..17a15cc6b542 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -2403,11 +2403,8 @@ static int

[PATCH 2/6] btrfs: remove set but not used variable err in btrfs_add_link

can just drop it as well. Signed-off-by: Johannes Thumshirn --- fs/btrfs/inode.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 7d17b0a654e6..57af243b3f59 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -6427,17

[PATCH 3/6] btrfs: remove unused function btrfs_sysfs_feature_update()

btrfs: synchronize incompat feature bits with sysfs files") reverted 14e46e04958d so btrfs_sysfs_feature_update() ended up as an unused function. Signed-off-by: Johannes Thumshirn --- fs/btrfs/sysfs.c | 33 - fs/btrfs/sysfs.h | 2 -- 2 files changed, 35 deletions(-)

[PATCH 5/6] btrfs: remove unused variable tree in end_compressed_bio_write()

btrfs. Signed-off-by: Johannes Thumshirn --- fs/btrfs/compression.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index bde8d0487bbb..088570c5dfb8 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -229,7 +229,6 @@ static

[PATCH 1/6] btrfs: remove unused drop_on_err in btrfs_mkdir()

is non NULL. Therefore drop_on_err is not used anymore and thus causes a warning when building with -Wunused-but-set-variable. Signed-off-by: Johannes Thumshirn --- fs/btrfs/inode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 4a2f9f7fd96e

Re: [PATCH 6/6] btrfs: unconditionally provide function prototypes from free-space-tree.h

ange it, but I'll wait for David's response first. Byte, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graha

Re: [PATCH 5/6] btrfs: remove unused variable tree in end_compressed_bio_write()

some testing. The devel repos are either > git://github.com/kdave/btrfs-devel or > git://gitlab.com/kdave/btrfs-devel, branch misc-next. Ah OK, I've used your kernel.org btrfs/for-next, I'll rebase for v2. -- Johannes ThumshirnSUSE Labs

Re: [PATCH 3/3] btrfs: document extent mapping assumptions in checksum

On 27/11/2018 17:36, Nikolay Borisov wrote: > > > On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote: >> Document why map_private_extent_buffer() cannot return '1' (i.e. the map >> spans two pages) for the csum_tree_block() case. >> >> The current algorithm for d

[PATCH v2 3/3] btrfs: document extent mapping assumptions in checksum

. Signed-off-by: Johannes Thumshirn --- Changes to v1: * Changed wording of the commit message according to Noah's suggestion --- fs/btrfs/disk-io.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 4bc270ef29b4..14d355d0cb7a 100644 --- a/fs

[PATCH v2 0/3] Misc cosmetic changes for map_private_extent_buffer

* Change wording of commit message in patch 3/3 Johannes Thumshirn (3): btrfs: don't initialize 'offset' in map_private_extent_buffer() btrfs: use offset_in_page for start_offset in map_private_extent_buffer() btrfs: document extent mapping assumptions in checksum fs/btrfs/disk-io.c

[PATCH v2 1/3] btrfs: don't initialize 'offset' in map_private_extent_buffer()

In map_private_extent_buffer() the 'offset' variable is initialized to a page aligned version of the 'start' parameter. But later on it is overwritten with either the offset from the extent buffer's start or 0. So get rid of the initial initialization. Signed-off-by: Johannes Thumshirn

[PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()

In map_private_extent_buffer() use offset_in_page() to initialize 'start_offset' instead of open-coding it. Signed-off-by: Johannes Thumshirn Reviewed-by: Nikolay Borisov --- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c b/fs

Re: [PATCH 01/10] btrfs: create a mount option for dax

btrfs_set_opt(info->mount_opt, DAX); > + break; > +#endif Can you please explain why we can't enable DAX on a multi device FS in the changelog? It's (for me at least) not obvious. Thanks, Johannes -- Johannes ThumshirnS

Re: [PATCH 02/10] btrfs: basic dax read

amp; (PAGE_SIZE - 1); Nit: unsigned offset = offset_in_page(pos); -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nor

Re: [PATCH 07/10] dax: export functions for use with btrfs

index; > @@ -531,6 +532,7 @@ static void *grab_mapping_entry(struct xa_state *xas, > xas_unlock_irq(xas); > return xa_mk_internal(VM_FAULT_FALLBACK); > } > +EXPORT_SYMBOL(grab_mapping_entry); dax_grab_mapping_entry() please. -- Johannes Thumshirn

Re: [PATCH 06/10] btrfs: dax write support

b12e6660 100644 > --- a/fs/btrfs/file.c > +++ b/fs/btrfs/file.c > @@ -1964,7 +1964,9 @@ static ssize_t btrfs_file_write_iter(struct kiocb *iocb, > if (sync) > atomic_inc(_I(inode)->sync_writers); > > - if (iocb->ki_flags & IOCB_DIRECT) {

[PATCH 0/3] btrfs: use offset_in_page and PAGE_ALIGNED

Use the offset_in_page() and PAGE_ALIGNED() macros instead of open-coding them throughout btrfs. This series also includes a patch for 'make coccicheck' which is marked as an RFC and I've CCed Julia in the hoping to get input from her. Johannes Thumshirn (3): btrfs: use offset_in_page instead

[PATCH 2/3] btrfs: use PAGE_ALIGNED instead of open-coding it

When using a 'var & (PAGE_SIZE - 1)' construct one is checking for a page alignment and thus should use the PAGE_ALIGNED() macro instead of open-coding it. Convert all open-coded occurrences of PAGE_ALIGNED(). Signed-off-by: Johannes Thumshirn --- fs/btrfs/check-integrity.c | 8

[PATCH 1/3] btrfs: use offset_in_page instead of open-coding it

Constructs like 'var & (PAGE_SIZE - 1)' or 'var & ~PAGE_MASK' can denote an offset into a page. So replace them by the offset_in_page() macro instead of open-coding it if they're not used as an alignment check. Signed-off-by: Johannes Thumshirn --- fs/btrfs/check-integrit

[RFC PATCH 3/3] coccinelle: api: add offset_in_page.cocci

instead of offset_in_page() yet. Cc: Julia Lawall Signed-off-by: Johannes Thumshirn --- scripts/coccinelle/api/offset_in_page.cocci | 81 + 1 file changed, 81 insertions(+) create mode 100644 scripts/coccinelle/api/offset_in_page.cocci diff --git a/scripts/coccin

Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()

On 28/11/2018 16:41, David Sterba wrote: > On Wed, Nov 28, 2018 at 09:54:55AM +0100, Johannes Thumshirn wrote: >> In map_private_extent_buffer() use offset_in_page() to initialize >> 'start_offset' instead of open-coding it. > > Can you please fix all instances where it'

Re: [PATCH 00/10] btrfs: Support for DAX devices

id(E) sd_mod(E) sr_mod(E) cdrom(E) ast(E) i2c_algo_bit(E) drm_kms_helper(E) syscopyarea(E) ahci(E) sysfillrect(E) xhci_pci(E) sysimgblt(E) fb_sys_fops(E) libahci(E) xhci_hcd(E) ttm(E) crc32c_intel(E) drm(E) libata(E) usbcore(E) wmi(E) nfit(E) libnvdimm(E) button(E) sg(E) dm_multipath(E) dm_mod(E) scs

Re: [RFC PATCH 3/3] coccinelle: api: add offset_in_page.cocci

not really into cocinelle so I guessed it might take some iterations. Do you have an example for this? > Why not include the cast case for the context and org cases? This is an oversight actually as I couldn't test it due to a bug in openSUSE's coccinelle rpm. Th

Re: [PATCH 1/4] btrfs: merge btrfs_submit_bio_done to its caller

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/4] btrfs: replace async_cow::root with fs_info

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 3/4] btrfs: remove redundant csum buffer in btrfs_io_bio

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH v2] btrfs: improve error handling of btrfs_add_link()

so the user knows what kind of error has encountered. Link: https://lore.kernel.org/linux-btrfs/20181119141323.gc24...@twin.jikos.cz Signed-off-by: Johannes Thumshirn --- Changes to v1: * Only print an error message and let the callers abort the transaction (Dave) --- fs/btrfs/inode.c | 13

[PATCH] btrfs: remove btrfs_bio_end_io_t

not needed anywhere. Signed-off-by: Johannes Thumshirn --- fs/btrfs/volumes.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h index 8b092bb1e2ee..c93097b0b469 100644 --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h @@ -295,9 +295,6 @@ struct btrfs_

Re: [PATCH 4/4] btrfs: replace btrfs_io_bio::end_io with a simple helper

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH 0/3] Misc cosmetic changes for map_private_extent_buffer

While trying to understand the checksum code I came across some oddities regarding map_private_extent_buffer() and it's interaction with csum_tree_block(). These patches address them but are either purely cosmetic or only add a comment documenting behaviour. Johannes Thumshirn (3): btrfs

[PATCH 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()

In map_private_extent_buffer() use offset_in_page() to initialize 'start_offset' instead of open-coding it. Signed-off-by: Johannes Thumshirn --- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index

[PATCH 3/3] btrfs: document extent mapping assumptions in checksum

can't be true. Signed-off-by: Johannes Thumshirn --- fs/btrfs/disk-io.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 4bc270ef29b4..14d355d0cb7a 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -279,6 +279,12 @@ static int

[PATCH 1/3] btrfs: don't initialize 'offset' in map_private_extent_buffer()

In map_private_extent_buffer() the 'offset' variable is initialized to a page aligned version of the 'start' parameter. But later on it is overwritten with either the offset from the extent buffer's start or 0. So get rid of the initial initialization. Signed-off-by: Johannes Thumshirn --- fs

[PATCH] btrfs: improve error handling of btrfs_add_link()

instead of removing 'err', start handling the errors of btrfs_del_root_ref()/btrfs_del_inode_ref() by aborting the transaction in btrfs_add_link() directly instead of the call-sites. Link: https://lore.kernel.org/linux-btrfs/20181119141323.gc24...@twin.jikos.cz/ Signed-off-by: Johannes Thumshirn

Re: [PATCH] btrfs: improve error handling of btrfs_add_link()

On 22/11/2018 14:35, David Sterba wrote: > On Thu, Nov 22, 2018 at 02:15:28PM +0100, Johannes Thumshirn wrote: >> err holds the return value of either btrfs_del_root_ref() or >> btrfs_del_inode_ref() but it hasn't been checked since it's >> introduction with commit fe66a05

[PATCH v2 1/5] btrfs: remove unused drop_on_err in btrfs_mkdir()

is non NULL. Therefore drop_on_err is not used anymore and thus causes a warning when building with -Wunused-but-set-variable. Signed-off-by: Johannes Thumshirn Reviewed-by: Omar Sandoval Reviewed-by: Nikolay Borisov Reviewed-by: Qu Wenruo --- fs/btrfs/inode.c | 3 --- 1 file changed, 3 deletions

[PATCH v2 4/5] btrfs: introduce EXPORT_FOR_TESTS macro

depending on CONFIG_BTRFS_FS_RUN_SANITY_TESTS either adds the 'static' keyword to a function or not. Signed-off-by: Johannes Thumshirn --- fs/btrfs/ctree.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index e62824cae00a..5119dacab981 100644 --- a/fs

[PATCH v2 0/5] btrfs: fix compiler warning with make W=1

already applied patches 4 + 5 * Added EXPORT_FOR_TESTS + users Johannes Thumshirn (5): btrfs: remove unused drop_on_err in btrfs_mkdir() btrfs: remove set but not used variable err in btrfs_add_link btrfs: remove unused function btrfs_sysfs_feature_update() btrfs: introduce EXPORT_FOR_TESTS macro

[PATCH v2 3/5] btrfs: remove unused function btrfs_sysfs_feature_update()

btrfs: synchronize incompat feature bits with sysfs files") reverted 14e46e04958d so btrfs_sysfs_feature_update() ended up as an unused function. Signed-off-by: Johannes Thumshirn Reviewed-by: Omar Sandoval Reviewed-by: Nikolay Borisov Reviewed-by: Qu Wenruo --- fs/btrfs/sy

[PATCH v2 2/5] btrfs: remove set but not used variable err in btrfs_add_link

can just drop it as well. Signed-off-by: Johannes Thumshirn Reviewed-by: Nikolay Borisov Reviewed-by: Qu Wenruo --- fs/btrfs/inode.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 9becf8543489..7f56a235c0b1 100644

[PATCH v2 5/5] btrfs: use EXPORT_FOR_TESTS for conditionally shared functions

, these functions could not be declared as static and the compiler had a harder task when optimizing and inlining them. As we have EXPORT_FOR_TESTS now, use it where appropriate to support the compiler. Signed-off-by: Johannes Thumshirn --- fs/btrfs/extent_io.c | 14 ++ fs

Re: [PATCH v2] btrfs: improve error handling of btrfs_add_link()

h left to do and the abort either > happened earlier in the callees or is necessary here. OK, now you've lost me. Isn't that what my previous patch did? Byte, Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de

Re: [PATCH 2/3] btrfs: cleanup the useless DEFINE_WAIT in cleanup_transaction

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 2/9] btrfs: switch BTRFS_BLOCK_RSV_* to enums

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/9] btrfs: switch BTRFS_FS_STATE_* to enums

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 8/9] btrfs: switch BTRFS_ORDERED_* to enums

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 9/9] btrfs: drop extra enum initialization where using defaults

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 4/9] btrfs: switch BTRFS_ROOT_* to enums

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 6/9] btrfs: switch EXTENT_FLAG_* to enums

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 3/3] btrfs: remove redundant nowait check for buffered_write

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 5/9] btrfs: swtich EXTENT_BUFFER_* to enums

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg