Re: [PATCH 1/2] btrfs-progs: fix the long lines

2013-07-16 Thread Anand Jain
Strings being grep-able is important. Thanks Stefan and Eric for the comments. Hopefully we shall have some better ways to handle long strings. OR shorter error message and still communicate the intended message is another choice but challenging. :-) I have dropped this patch for

Re: [PATCH 1/2] btrfs-progs: fix the long lines

2013-07-15 Thread Stefan Behrens
On Mon, 15 Jul 2013 13:35:26 +0800, Anand Jain wrote: trivial: cmds-replace.c contains long lines fix it Signed-off-by: Anand Jain anand.j...@oracle.com --- cmds-replace.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/cmds-replace.c

Re: [PATCH 1/2] btrfs-progs: fix the long lines

2013-07-15 Thread Eric Sandeen
On 7/15/13 12:35 AM, Anand Jain wrote: trivial: cmds-replace.c contains long lines fix it I realize that this is total bikeshedding, so you can take or leave it, but: One downside to this is that it makes it a little harder to grep for strings when they get arbitrarily split across lines. One

[PATCH 1/2] btrfs-progs: fix the long lines

2013-07-14 Thread Anand Jain
trivial: cmds-replace.c contains long lines fix it Signed-off-by: Anand Jain anand.j...@oracle.com --- cmds-replace.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/cmds-replace.c b/cmds-replace.c index 6397bb5..c68986a 100644 --- a/cmds-replace.c +++