I can't say I like the structure.
A list_pop that removes and entry from the head or returns NULL if the
list is empty would lead to nice while loops that are obviously
readable instead.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to
On Mon, Jun 03, 2013 at 03:55:55PM -0400, J??rn Engel wrote:
Actually, when I compare the two invocations, I prefer the
list_for_each_entry_del() variant over list_pop_entry().
while ((ref = list_pop_entry(prefs, struct __prelim_ref, list))) {
list_for_each_entry_del(ref,
On Wed, Aug 07, 2013 at 12:57:18PM -0700, Mark Fasheh wrote:
stat(2) on btrfs returns a custom device, but proc uses s_dev from the super
block. This causes problems (abi breakage) because software (and users) are
not expecting the kernel to return different devices from these calls.
So fix
On Wed, Aug 07, 2013 at 04:51:46PM -0400, Josef Bacik wrote:
Not possible, this will break other things as subvolumes have their own inode
space, it will confuse applications that get multiples of an inode number for
different devices with the same st_dev. Each subvolume has it's own anonymous
On Thu, Aug 08, 2013 at 09:02:07AM -0400, Josef Bacik wrote:
This won't work, try having 1 subvolumes with dirty inodes and do sync
then
go skiing, you'll have time :). Thanks,
Why would the dirty inodes make any difference? If you share the bdi
between the subvolumes the sync workflow
On Thu, Aug 08, 2013 at 11:44:54AM -0400, Josef Bacik wrote:
On Thu, Aug 08, 2013 at 06:48:05AM -0700, Christoph Hellwig wrote:
On Thu, Aug 08, 2013 at 09:02:07AM -0400, Josef Bacik wrote:
This won't work, try having 1 subvolumes with dirty inodes and do
sync then
go skiing
On Wed, May 28, 2008 at 12:41:24AM +0200, Sven Wegener wrote:
I have a patch (see below) that does an explicit d_drop() on the dentry
after looking it up via d_find_alias() and d_lookup(), starting at the root
inode. Currently it's for snapshot creation only, subvolume creation needs
the
use normal kbuild syntax to build acl.o conditinally and remove comment
out lines.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: btrfs-unstable/Makefile
===
--- btrfs-unstable.orig/Makefile2008-06-10 14:29
Allows to specify one or multiple device=/dev/foo options during mount
so that ioctls on the control device can be avoided. Especially useful
when trying to mount a multi-device setup as root.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: btrfs-unstable/super.c
On Sun, Jun 22, 2008 at 10:10:06AM -0400, Chris Mason wrote:
The idea is that backup programs already know how to do xattrs and can
easily be changed to preserve them. Every ioctl interface we
create/make up has to be handed coded into the backup program.
Actually they don't. Because of the
On Tue, Aug 12, 2008 at 02:46:46PM +0100, David Woodhouse wrote:
+static inline struct dentry *d_obtain_alias(struct inode *inode)
+{
+ struct dentry *d = d_alloc_anon(inode);
+ if (!d)
+ iput(inode);
+ return d;
+}
+#endif
I'm not sure when al wants to merge with
On Mon, Aug 18, 2008 at 09:20:39PM +0100, David Woodhouse wrote:
On Mon, 2008-08-18 at 15:47 -0400, Chris Mason wrote:
Lets pretend I had put in commments something like the code below.
The important part is that directories have only one link, so they
have only one backref.
OK. Now can
On Mon, Sep 08, 2008 at 09:49:42AM -0700, Stephen Hemminger wrote:
Not to mention the problem that developers seem to have faster machines than
average user, but slower than the enterprise and future generation CPU's.
So any tuning value seems to get out of date fast.
So where do my fellow
once we allow for subvolumes anywher in the tree,
and not just below a hidden root.
Note that snapshots will need the same treatment, but do to the delay
in creating them we can't do it currently. Chris promised to fix that
issue, so I'll wait on that.
Signed-off-by: Christoph Hellwig [EMAIL
On Thu, Oct 09, 2008 at 03:40:50AM +0200, Christian Parpart wrote:
This patch denies renames and linking of inodes across subvolumes, as it
causes disk format corruption.
I guess a long-term goal *might* be to just handle these special cases with
care, to allow them by properly handling
On Thu, Oct 16, 2008 at 03:25:01PM -0400, Valerie Aurora Henson wrote:
Both deduplication and compression have an interesting side effect in
which a write to a previously allocated block can return ENOSPC.
This is even more exciting when you factor in mmap. Any thoughts on
how to handle this?
Shut up various sparse warnings about symbols that should be either
static or have their declarations in scope.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: btrfs-unstable/fs/btrfs/disk-io.c
===
--- btrfs-unstable.orig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: btrfs-unstable/fs/btrfs/extent_io.c
===
--- btrfs-unstable.orig/fs/btrfs/extent_io.c2008-11-20 19:37:10.0
+0100
+++ btrfs-unstable/fs/btrfs/extent_io.c 2008-11-20
Provide a void __user *argp pointer so that we can avoid duplicating
the cast for various sub-command calls.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: btrfs-unstable/fs/btrfs/ioctl.c
===
--- btrfs-unstable.orig/fs
Cleans the code up a little and also avoids a sparse warning due to the
incorrect cast in the current version of the code.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: btrfs-unstable/fs/btrfs/ioctl.c
===
--- btrfs
On Wed, Dec 10, 2008 at 08:44:47AM -0500, Chris Mason wrote:
I had planned to make the bits inheritable from the directory inode
flags. There are two different discussions around xattrs for this. One
is using xattrs to store the flag, which I'd would rather avoid because
it is checked in
FYI: here's a little writeup I did this summer on support for
filesystems spanning multiple block devices:
--
=== Notes on support for multiple devices for a single filesystem ===
== Intro ==
Btrfs (and an experimental XFS version) can support multiple underlying block
devices for a single
On Tue, Jan 06, 2009 at 02:29:17AM +0900, Ryusuke Konishi wrote:
2009/1/6 Chris Mason chris.ma...@oracle.com:
On Wed, 2008-12-24 at 17:56 +0900, Ryusuke Konishi wrote:
Hi Chris,
I've started to read and try btrfs, and soon met the following build
errors. The attached patch fixes the
On Mon, Apr 13, 2009 at 09:28:28AM -0400, Chris Mason wrote:
On Sun, 2009-04-12 at 02:03 +0200, Harald Glatt wrote:
Hi,
I have set up a btrfs within a 200 GB file that I mount via -o loop.
It worked fine so far but today it crashed when there was alot of
concurrent writing/reading
Get rid of the hacks for building out of tree, and always use += for
assigning to the object lists.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/btrfs/Makefile
===
--- linux-2.6.orig/fs/btrfs/Makefile2009-04
Just use kmem_cache_create directly.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: btrfs-unstable/fs/btrfs/extent_io.c
===
--- btrfs-unstable.orig/fs/btrfs/extent_io.c2008-12-17 18:33:15.0
+0100
+++ btrfs
Currently the extent_map code is only for btrfs so don't export it's
symbols.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/btrfs/extent_map.c
===
--- linux-2.6.orig/fs/btrfs/extent_map.c2009-04-13 13:15
, but can't actually be set anywhere from the
filesystem code.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/btrfs/ioctl.c
===
--- linux-2.6.orig/fs/btrfs/ioctl.c 2009-04-17 10:08:11.758948607 +0200
+++ linux-2.6/fs
On Thu, Apr 23, 2009 at 10:00:55AM -0400, Chris Ball wrote:
Hi Christoph,
Add support for the standard attributes set via chattr and read
vis lsattr. Currently we store the attributes in the flags value
in the btrfs inode, but I wonder whether we should split it into
two so
On Fri, Jun 12, 2009 at 06:49:45PM -0700, Amit Gud wrote:
An ioctl is needed to set compress flag (i.e. clear
BTRFS_INODE_NOCOMPRESS flag) on per file basis. This patch adds that.
Introduces a generic function to be used by subsequent patches.
It's probably a better idea to fit these into
Use filemap_fdatawrite_range and filemap_fdatawait_range instead of
local copies of the functions. For filemap_fdatawait_range that
also means replacing the awkward old wait_on_page_writeback_range
calling convention with the regular filemap byte offsets.
Signed-off-by: Christoph Hellwig h
The discard support code in btrfs currently is guarded by ifdefs for
BIO_RW_DISCARD, which is never defines as it's the name of an enum
memeber. Just remove the useless ifdefs to actually enable the code.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/btrfs/extent-tree.c
On Thu, Oct 29, 2009 at 09:52:15PM +0100, Andi Drebes wrote:
As recently discussed on the list, btrfsck should only be run on unmounted
filesystems. This patch adds a short check for the mount status at the
beginning of btrfsck. If the FS is mounted, the program aborts showing an
error
Discard the whole device before starting to create the filesystem structures.
Modelled after similar support in mkfs.xfs.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: btrfs-progs-unstable/utils.c
===
--- btrfs-progs
I played around with the btrfs discard support now that I've finished
trying up the ATA TRIM support to the block layer. These numbers are
with an OCZ-Vertex SSD with the 1.4 firmware, on a 2.6.32-rc7 kernel
and current git btrfs-progs with my patch do discard the whole device
at mkfs time.
I
On Fri, Mar 04, 2011 at 08:39:03AM +1100, Dave Chinner wrote:
WTF? Why does append mode have any effect on whether we can punch
holes in a file or not? There's no justification for adding this in
the commit message. Why is it even in a patch that is for checking
immutable inodes? What is the
I think there's a better and more efficient way to archive this.
We already have a bd_super field in struct block_device. Just
generalize it, and use it from the freeze code instead of doing the
get_active_super loop.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote:
This is a simple patch to allow reflinks to be made crossing subvolume
boundaries.
NAK. subvolumes will have to become vfsmounts sooner or later, and we
really must not support any operations spanning mountpoints.
--
To unsubscribe
On Thu, Mar 31, 2011 at 08:02:22AM -0400, Chris Mason wrote:
Excerpts from Christoph Hellwig's message of 2011-03-31 02:36:36 -0400:
On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote:
This is a simple patch to allow reflinks to be made crossing subvolume
boundaries.
NAK.
On Fri, Apr 15, 2011 at 09:24:18AM -0700, Randy Dunlap wrote:
Can this also be used to stop this warning that has been around
like forever (on i386)?
linux-next-20110415/fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format
'%llx' expects type 'long long unsigned int', but argument 22 has
Sorry, but this is too ugly to live. If the reason for this really is
good enough we'll just need to push the filemap_write_and_wait_range
and i_mutex locking into every -fsync instance.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to
On Fri, Apr 15, 2011 at 03:34:57PM -0400, Chris Mason wrote:
Excerpts from Christoph Hellwig's message of 2011-04-15 15:24:12 -0400:
Sorry, but this is too ugly to live. If the reason for this really is
good enough we'll just need to push the filemap_write_and_wait_range
and i_mutex
We'll also need:
- a patch to lseek(2) to document the new flags
- some testcases for xfstests, specially dealing with things that
were problematic in FIEMAP, e.g. data in delalloc extents, making
sure stuff in unwrittent extents partially converted actually gets
copied, etc.
--
To
[Eric: please don't drop the Cc list, thanks!]
On Thu, Apr 21, 2011 at 09:22:55PM -0400, Josef Bacik wrote:
since all files have a virtual hole at the end, but leaves the position
unchanged). ??I'd have to write a test program on Solaris to see whether
that
definition is actually true,
On Wed, May 18, 2011 at 07:44:42PM -0700, Sunil Mushran wrote:
It is improved since the last post. It runs cleanly on zfs, ocfs2 and ext3
(default behavior). Users testing on zfs will need to flip the values of
SEEK_HOLE/DATA.
sounds like we should switch the around, just to cause the least
On Wed, May 18, 2011 at 07:44:44PM -0700, Sunil Mushran wrote:
Unwritten (preallocated) extents are considered holes because the file system
treats reads to such regions in the same way as it does to holes.
How does this work for the case of an unwrittent extent that has been
written to in the
On Tue, May 24, 2011 at 04:26:03PM -0400, Josef Bacik wrote:
This test just runs through all of the basic btrfs commands that manipulate
our
subvolume stuff. It creates a snapshot, a subvolume, sets the subvolume as a
default, lists the volumes and deletes the snapshot. Thanks,
Now that the last users is gone these can be removed.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/include/linux/rwsem.h
===
--- linux-2.6.orig/include/linux/rwsem.h2011-06-20 14:58:15.449148809
+0200
Wait for all direct I/O requests to finish before performing a truncate.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/btrfs/inode.c
===
--- linux-2.6.orig/fs/btrfs/inode.c 2011-06-11 12:58:46.615017504 +0200
i_alloc_sem has always been a bit of an odd lock. It's the only remaining
rw_semaphore that can be released by a different thread than the one that
locked it, and it's use case in the core direct I/O code is more like a
counter given that the writers already have external serialization.
This
Reject zero sized reads as soon as we know our I/O length, and don't
borther with locks or allocations that might have to be cleaned up
otherwise.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/direct-io.c
operation.
This scheme is much simpler, and saves the space of a spinlock_t and a
struct list_head in struct inode (typically 160 bytes on a non-debug 64-bit
system).
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/direct-io.c
-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/ocfs2/file.c
===
--- linux-2.6.orig/fs/ocfs2/file.c 2011-06-20 09:28:54.516815966 +0200
+++ linux-2.6/fs/ocfs2/file.c 2011-06-20 09:31:34.706807855 +0200
@@ -1142,6 +1142,8 @@ int
i_dio_count manipulations are replaced with
the common code noew available.
As a result inode_dio_wake can now be made static in direct-io.c.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/direct-io.c
===
--- linux-2.6
Add a new rw_semaphore to protect page_mkwrite against truncate. Previous
i_alloc_sem was abused for this, but it's going away in this series.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/ext4/inode.c
Add a new rw_semaphore to protect bmap against truncate. Previous
i_alloc_sem was abused for this, but it's going away in this series.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/fat/inode.c
===
--- linux-2.6
On Mon, Jun 20, 2011 at 04:15:33PM -0400, Christoph Hellwig wrote:
This series removes it in favour of a simpler counter scheme, thus getting
rid of the rw_semaphore non-owner APIs as requests by Thomas, while at the
same time shrinking the size of struct inode by 160 bytes on 64-bit systems
On Mon, Jun 20, 2011 at 02:32:03PM -0700, Joel Becker wrote:
Are we guaranteed that all allocation changes are locked out by
i_dio_count0? I don't think we are. The ocfs2 code very strongly
assumes the state of a file's allocation when it holds i_alloc_sem. I
feel like we lose that
On Mon, Jun 20, 2011 at 02:29:24PM -0700, Joel Becker wrote:
Oh god you're making the world scary. Are you guaranteeing that
all allocation changes are locked out by the time we get into
file_aio_write() and file_aio_read()? This is not obvious to me.
I have no idea how ocfs2's
On Tue, Jun 21, 2011 at 03:40:56PM +1000, Dave Chinner wrote:
Modification of inode-i_state is not safe outside the
inode-i_lock.
We never actually set the new bit in i_state, we just use it as a key
for the hashed lookups. Or rather we try to, as I misunderstood how
wait_on_bit works, so
On Wed, Jun 22, 2011 at 12:57:43AM +0900, OGAWA Hirofumi wrote:
Christoph Hellwig h...@infradead.org writes:
Add a new rw_semaphore to protect bmap against truncate. Previous
i_alloc_sem was abused for this, but it's going away in this series.
In FAT case, -i_mutex was better. But, last
On Tue, Jun 21, 2011 at 06:34:50PM +0200, Lukas Czerner wrote:
this looks like a bug fix, so we should rather do it in a separate
commit. Could you send it separately, or at least mention that in commit
description ?
What looks like a bugfix?
--
To unsubscribe from this list: send the line
On Wed, Jun 22, 2011 at 01:54:25AM +0200, Jan Kara wrote:
ext4 abuse should be gone when Ted merges my rewrite of
ext4_page_mkwrite()... Ted, what happened to that patch. Should I resend
it?
So how should we coordinate merging the two?
--
To unsubscribe from this list: send the line
On Wed, Jun 22, 2011 at 08:13:42PM +0200, Jan Kara wrote:
No problem. Just we have to somehow coordinate with Christoph... Either
he can avoid touching ext4 and merge his patch set after you merge my patch
or he can take my patch instead of his ext4 change. Since my patch touches
only
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
we drop the i_lock all we
hold here is the i_mutex on an unrelated parent directory.
Instead copy the logic of d_materialise_unique.
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord
- return d_obtain_alias(inode);
+ return d_obtain_alias_root(inode);
Can we call this d_obtain_root or similar, please?
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Wed, Apr 16, 2014 at 11:36:23AM +0100, Filipe David Manana wrote:
The xattr is needed for the case where an acl is inherited. And 5
units are required for orphan insertion (see comment on top of
btrfs_orphan_add).
I'll update the comment.
I don't think think a tmpfile should inherit any
On Wed, Apr 16, 2014 at 12:25:07PM +0100, Filipe David Manana wrote:
Interesting Christoph.
I was following the ext4 implementation initially.
So it seems the question is still open, and none of the following
alternatives is decided yet (unless I missed something in the thread
at fsdevel):
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 16, 2014 at 02:46:11PM +1000, Dave Chinner wrote:
Hi folks,
As requested I've created a new mailing list for xfstests
development and discussion. Reflecting the fact that the test
harness is not really XFS specific anymore, the list is:
fste...@vger.kernel.org
Isn't
On Sat, May 17, 2014 at 08:19:30AM +1000, Dave Chinner wrote:
Renaming the test suite take a lot more work - .e.g renaming/moving
source trees and a fixing all the documentation that points to it...
In that case please call the list xfstests - a name different by a
single character is utterly
On Fri, Jun 06, 2014 at 10:52:48AM -0500, Eric Sandeen wrote:
On 6/6/14, 5:03 AM, Karel Zak wrote:
On Fri, Jun 06, 2014 at 11:44:28AM +0200, Karel Zak wrote:
I personally have no problem to maintain information about arbitrary
FS in mount.8, the problem are updates. Unfortunately, kernel
Reject zero sized reads as soon as we know our I/O length, and don't
borther with locks or allocations that might have to be cleaned up
otherwise.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/direct-io.c
i_alloc_sem has always been a bit of an odd lock. It's the only remaining
rw_semaphore that can be released by a different thread than the one that
locked it, and it's use case in the core direct I/O code is more like a
counter given that the writers already have external serialization.
This
operation.
This scheme is much simpler, and saves the space of a spinlock_t and a
struct list_head in struct inode (typically 160 bytes on a non-debug 64-bit
system).
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/direct-io.c
-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/ocfs2/file.c
===
--- linux-2.6.orig/fs/ocfs2/file.c 2011-06-20 09:28:54.516815966 +0200
+++ linux-2.6/fs/ocfs2/file.c 2011-06-20 09:31:34.706807855 +0200
@@ -1142,6 +1142,8 @@ int
with
the common code now enable.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/direct-io.c
===
--- linux-2.6.orig/fs/direct-io.c 2011-06-24 15:18:52.0 +0200
+++ linux-2.6/fs/direct-io.c2011-06-24 15
, but left to the filesystem maintainers. At least
for XFS it's not needed yet either as XFS has an internal equivalent
to i_dio_count.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/direct-io.c
===
--- linux-2.6.orig/fs
From: Jan Kara j...@suse.cz
Rewrite ext4_page_mkwrite() to use __block_page_mkwrite() helper. This
removes the need of using i_alloc_sem to avoid races with truncate which
seems to be the wrong locking order according to lock ordering documented in
mm/rmap.c. Also calling ext4_da_write_begin()
Add a new rw_semaphore to protect bmap against truncate. Previous
i_alloc_sem was abused for this, but it's going away in this series.
Note that we can't simply use i_mutex, given that the swapon code
calls -bmap under it.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: linux-2.6/fs/fat
This scheme is much simpler, and saves the space of a spinlock_t and a
struct list_head in struct inode (typically 160 bytes on a non-debug 64-bit
system).
And I still haven't fixed that typo, damn. Updated in local version now
to make sure it won't be missed next time.
--
To unsubscribe
On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and
will
adjust as
On Wed, Jun 29, 2011 at 11:42:38AM +0100, P?draig Brady wrote:
There is the argument, that if this interface can distinguish
these dirty unwritten extents, then why can't the fiemap interface too?
The advantage of the fiemap interface is that it can distinguish
empty extents vs holes. Empty
On Fri, Jul 15, 2011 at 05:26:38PM -0400, Josef Bacik wrote:
Everybody else does this, we need to do it too. If we're syncing, we need to
tag the pages we're going to write for writeback so we don't end up writing
the
same stuff over and over again if somebody is constantly redirtying our
On Tue, Jul 19, 2011 at 01:30:22PM -0400, Chris Mason wrote:
We've seen a number of benchmarks dominated by contention on the root
node lock. This changes our locks into a simple reader/writer lock.
They are based on mutexes so that we still take advantage of the mutex
adaptive spins for
On Mon, Jul 25, 2011 at 04:04:49PM +0200, Victor Stinner wrote:
According to agraf__ on IRC (#kvm on FreeNode), the cache mode has
the following effect:
- cache=writethrough calls fsync() after every write()
It uses O_DSYNC, which an be appromiately described as an fdatasync
after every
On Thu, Jul 28, 2011 at 10:27:58AM +0200, Stefan Behrens wrote:
Added btrfs to the list of supported filesystems for this test.
Remove output of mkfs since this is specific to mkfs.xfs and now filtered
out.
Why can't it be generic? Any reason this one doesn't work on e.g. ext2
or reiserfs?
Same questions as for the previous one.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 28, 2011 at 10:28:00AM +0200, Stefan Behrens wrote:
Added btrfs to the list of supported filesystems for test 015, and
increased free space reporting tolerance to 10% for btrfs.
Replaced the call to _scratch_mkfs_xfs with the XFS specific size
parameter by the generic one for sized
On Thu, Jul 28, 2011 at 10:28:01AM +0200, Stefan Behrens wrote:
Added btrfs to the list of supported filesystems for test 079.
In src/t_immutable.c which is compiled for Linux only, add support for
btrfs by replacing the ioctl(EXT2_IOC_SETFLAGS) with
ioctl(FS_IOC_SETFLAGS) which is defined to
On Thu, Jul 28, 2011 at 07:54:45PM +0200, Stefan Behrens wrote:
To add a 10% tolerance for btrfs was a bad idea.
Since the output of df(1) is not yet reliable on btrfs volumes while
data is not flushed to disk, the better implementation would be to
either let this test fail, or to force a
On Fri, Jul 29, 2011 at 04:07:36PM +0800, Li Zefan wrote:
# mount -t btrfs /dev/sda7 /mnt
# dd if=/dev/zero of=/mnt/src bs=10K count=1
# sync
# clone 4K from /mnt/src to /mnt/dst
kernel BUG at fs/btrfs/delayed-inode.c:1693!
Sounds like a regression test you should add to xfstests.
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and
will
adjust as necessary.
Can you resend this with any updates that happened in
On Fri, Sep 02, 2011 at 03:56:25PM +0800, Li Zefan wrote:
There's an off-by-one bug:
# create a file with lots of 4K file extents
# btrfs fi defrag /mnt/file
# sync
# filefrag -v /mnt/file
Filesystem type is: 9123683e
File size of /mnt/file is 1228800 (300 blocks, blocksize
On Fri, Aug 12, 2011 at 04:01:33AM +0800, Anand Jain wrote:
Added test case 259 for the btrfs raid features. SCRATCH_DEV_POOL must
be set to 2 or more disks.
Any chance you can document how SCRATCH_DEV_POOL is supposed to be
used in the README file? An addition patch is fine, no need to update
On Mon, Sep 05, 2011 at 06:23:23PM +0200, Tomasz Chmielewski wrote:
That's because dpkg is known for using (f)sync very heavily. btrfs
honours the sync request in all cases, so it's much much slower than
ext3, which doesn't.
Hmm, is it really the case with ext3/ext4 (ignoring fsync in
On Sun, Sep 11, 2011 at 11:33:36PM +0300, Grazvydas Ignotas wrote:
Currently getdents syscall returns wrong offset for '.' directory entry,
which confuses some programs like wine. This can be observed with an
example program getdents(2) manpage:
Can you submit a patch to add your testcase to
On Mon, Sep 12, 2011 at 03:19:07AM +0300, Grazvydas Ignotas wrote:
The test checks if no duplicate d_off values are returned and that
those values are seekable to the right inodes.
Signed-off-by: Grazvydas Ignotas nota...@gmail.com
Thanks a lot! I've applied it locally and will push it out
On Thu, Sep 15, 2011 at 04:06:47PM -0700, Andi Kleen wrote:
From: Andi Kleen a...@linux.intel.com
Introduced by 9a4327ca1f45f82edad7dc0a4e52ce9316e0950c
I think this should go to Chris/Linus ASAP. But a slightly better
patch description wouldn't hurt either.
Also any reason you captialize
1 - 100 of 661 matches
Mail list logo
