the -k option was missing from the usage() output and was present
only in the man page synopsis. Say a few more words about it.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
diff --git a/blktrace.c b/blktrace.c
index 89c..4e96573 100644
--- a/blktrace.c
+++ b/blktrace.c
@@ -450,6
On 5/8/13 8:33 PM, Eric Sandeen wrote:
the -k option was missing from the usage() output and was present
only in the man page synopsis. Say a few more words about it.
Gah, sorry. email address auto-fill bit me. :(
Signed-off-by: Eric Sandeen sand...@redhat.com
---
diff --git
On 5/14/13 10:19 AM, Rich Johnston wrote:
On 04/26/2013 01:45 PM, Eric Sandeen wrote:
test 284 had... some issues.
First, it took so long nobody ran it; so shorten the extent
count by a factor of about 100.
Having fixed that, we see failures in 2 cases; when start or
len is -1
testcase]
Signed-off-by: Koen De Wit koen.de@oracle.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
Originally submitted as test 297
diff --git a/common/rc b/common/rc
index fe6bbfc..4560715 100644
--- a/common/rc
+++ b/common/rc
@@ -2098,6 +2098,27 @@ _require_dumpe2fs()
fi
-off-by: Koen De Wit koen.de@oracle.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
Originally submitted as
xfstests: 298: sparse copy of a directory tree on btrfs
diff --git a/tests/btrfs/309 b/tests/btrfs/309
new file mode 100755
index 000..b3927ba
--- /dev/null
+++ b/tests/btrfs/309
-by: Eric Sandeen sand...@redhat.com
---
Originally submitted as
xfstests: 299: moving and deleting sparse copies on btrfs
diff --git a/tests/btrfs/310 b/tests/btrfs/310
new file mode 100755
index 000..f87e782
--- /dev/null
+++ b/tests/btrfs/310
@@ -0,0 +1,79 @@
+#! /bin/bash
+# FS QA Test
with the reflink=auto option.
# A normal copy should be created.
#- Copy a file with the reflink=always option. Should result in error,
# no file should be created.
[sandeen: mostly cosmetic changes]
Signed-off-by: Koen De Wit koen.de@oracle.com
Signed-off-by: Eric Sandeen sand
gone over all of them, will try to get the rest
tidied up and resubmitted unless you want to - which would be
just fine!
-Eric
On 5/23/13 11:43 AM, Eric Sandeen wrote:
# Tests file clone functionality of btrfs (reflinks) on directory trees.
# - Create directory and subdirectory, each having
On 5/23/13 10:09 PM, Eryu Guan wrote:
On Thu, May 23, 2013 at 11:36:32AM -0500, Eric Sandeen wrote:
From: Koen De Wit koen.de@oracle.com
# Tests file clone functionality of btrfs (reflinks):
# - Reflink a file
# - Reflink the reflinked file
# - Modify the original file
[sandeen: mostly cosmetic changes]
Signed-off-by: Koen De Wit koen.de@oracle.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
Originally submitted as
xfstests: 298: sparse copy of a directory tree on btrfs
V2: drop -F from $XFS_IO_PROG
diff --git a/tests/btrfs/309 b/tests/btrfs/309
new
testcase]
Signed-off-by: Koen De Wit koen.de@oracle.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
Originally submitted as test 297
V2: move to test 306, remove -F from $XFS_IO_PROG
diff --git a/common/rc b/common/rc
index fe6bbfc..4560715 100644
--- a/common/rc
+++ b/common/rc
@@ -2098,6
On 5/26/13 4:35 AM, Zhi Yong Wu wrote:
HI,
This issue still exists when xfstests is run on debian although
xfstests has contained this patch.
this issue must be different, then; same error (Invalid argument)
but it can no longer be due to the -x option to filefrag. There
must be some
On 6/6/13 10:20 AM, Jan Schmidt wrote:
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool, which is
not part of the test suite but can skip the test if it is missing.
Signed-off-by: Jan Schmidt
On 6/7/13 5:29 AM, Dave Chinner wrote:
On Fri, Jun 07, 2013 at 09:18:58AM +0200, Jan Schmidt wrote:
(cc Arne for far-progs discussion)
On Thu, June 06, 2013 at 19:54 (+0200), Eric Sandeen wrote:
On 6/6/13 10:20 AM, Jan Schmidt wrote:
Basic send / receive functionality test for btrfs
On 6/10/13 9:56 AM, Anand Jain wrote:
btrfs_scan_for_fsid uses only one argument run_ioctl out of 3
so remove the rest two of them
and run_ioctl is only ever '1' (and it's completely unobvious
at the call point what '1' means).
Why not just go with 0 args?
Then only btrfs_scan_one_dir and
These are some patches I've been sitting on for a while that I think
clean up the btrfs-progs tree a bit; there are still quite a few files
left in the top-level dir, but moving tests cmd files into cmd/
seems to clean things up a bit. Curious to see what people think.
This is just file-moves
Move test tools to tests/
Signed-off-by: Eric Sandeen sand...@redhat.com
---
Makefile | 23 +
tests/Makefile | 49
.../btrfs-corrupt-block.c |0
dir-test.c
Preparatory patch to move cmd test files into their
own subdirs.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
Makefile | 38 +++---
man/Makefile |1 -
2 files changed, 31 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index
Move btrfs cmd files to cmd/ subdir
Signed-off-by: Eric Sandeen sand...@redhat.com
---
Makefile | 38 ++---
cmd/Makefile | 61
btrfs.c = cmd/btrfs.c |0
cmds
On 6/11/13 6:15 PM, Eric Sandeen wrote:
Move btrfs cmd files to cmd/ subdir
Signed-off-by: Eric Sandeen sand...@redhat.com
crud just realized this doesn't DTRT w/ btrfsck links, will have
to send a V2 for this one I guess.
-Eric
---
Makefile | 38
Move btrfs cmd files to cmd/ subdir
Signed-off-by: Eric Sandeen sand...@redhat.com
---
V2: move btrfsck symlink handling to cmd/Makefile too
Makefile | 38 ++---
cmd/Makefile | 61
Fix .gitignore for new file locations.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
(could update other patches rather than add 4th if it's better)
diff --git a/.gitignore b/.gitignore
index a7e1b19..abc7ca6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,17 +4,10 @@
version.h
version
On 6/12/13 10:56 PM, Anand Jain wrote:
Per wiki an idea seems to maintain same code (probably
as much as possible) between btrfs-progs and btrfs
There must have been a/few critical advantage, but
what are they ?
Thanks, Anand
Because they work with the same on-disk
, another gig to write.
Did you test other filesystems w/ the change?
Seems like a reasonable expedient solution though, so:
Reviewed-by: Eric Sandeen sand...@redhat.com
Signed-off-by: Josef Bacik jba...@fusionio.com
---
tests/generic/274 |2 +-
1 files changed, 1 insertions(+), 1 deletions
On 6/26/13 5:47 PM, Stefan Behrens wrote:
On 06/26/2013 21:55, Zach Brown wrote:
+if (!uuid_root) {
+WARN_ON_ONCE(1);
+ret = -ENOENT;
+goto out;
+}
WARN_ON_ONCE specifically returns the condition so that you can write:
if (WARN_ON_ONCE(!uuid_root)) {
cutting out file names from the output. I did this in the first version
of the patch:
md5sum $TESTDIR1/$F | $AWK_PROG 'END {print $1}'
but Eric Sandeen suggested to include them in order to provide more context
in the output. (See http://oss.sgi.com/archives/xfs/2013-03/msg00231.html
On 7/15/13 12:35 AM, Anand Jain wrote:
trivial: cmds-replace.c contains long lines fix it
I realize that this is total bikeshedding, so you can take or leave it, but:
One downside to this is that it makes it a little harder to grep for strings
when they get arbitrarily split across lines.
One
On 7/26/13 4:28 AM, Stefan Behrens wrote:
Unfortunately this test takes 6 minutes on my SSD equiped test box since
it runs all possible single/dup/raid0/raid1/raid10/mixed profiles, one
round with the '-f' option to 'btrfs replace start' and one round
without this option. The cancelation is
btrfs can pass this test too. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
I don't know for sure that that makes brtfs awesome ;), but its' not what
we're testing here, so ignoring it seems reasonable.
Reviewed-by: Eric Sandeen sand...@redhat.com
---
tests/generic/314 |2
On 7/29/13 12:21 PM, Josef Bacik wrote:
So df in btrfs is tricky at best, and relying on it for accurate information
is
not great, but it's the best way to verify this test. So we need to add
another
sync to make sure the pinned blocks are all freed up and the df space is
really
really
On 7/29/13 12:31 PM, Eric Sandeen wrote:
Honest question: does one more sync make this deterministic, or is it a
best-effort, um, hack?
I'm not quite sure why even 1 sync is needed. :(
I'm not sure what bug this is trying to test; if you need 2 syncs for global
space stats to accurately
On 7/10/13 11:12 AM, David Sterba wrote:
On Tue, Jul 09, 2013 at 07:49:53PM +0100, Filipe David Borba Manana wrote:
The module cmds-restore.c was defining its own next_leaf()
function, which did exactly the same as btrfs_next_leaf()
from ctree.c.
This has been removed by Eric's patch
the codebase...
Signed-off-by: Eric Sandeen sand...@redhat.com
---
(note, this is against kdave's integration tree)
diff --git a/btrfs-convert.c b/btrfs-convert.c
index c500ddd..a9ac9a5 100644
--- a/btrfs-convert.c
+++ b/btrfs-convert.c
@@ -436,7 +436,7 @@ static int record_file_extent(struct
cmds-recieve.c cmds-send.c seem to have weird wrappers and
indirections, and groups of commands which have only
one member, which are never referenced in the code.
I think these can be removed.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-receive.c | 19 +--
cmds
On 8/2/13 7:34 PM, Eric Sandeen wrote:
On 7/10/13 11:12 AM, David Sterba wrote:
On Tue, Jul 09, 2013 at 07:49:53PM +0100, Filipe David Borba Manana wrote:
The module cmds-restore.c was defining its own next_leaf()
function, which did exactly the same as btrfs_next_leaf()
from ctree.c
On 7/3/13 8:25 AM, Miao Xie wrote:
Signed-off-by: Miao Xie mi...@cn.fujitsu.com
---
btrfs-find-root.c | 137 +++-
disk-io.c | 473
+++---
disk-io.h | 12 ++
3 files changed, 307 insertions(+), 315 deletions(-)
Turns out btrfs-convert broke on July 3, and lo! we
do not have a regression test, and now we have one,
and there was much rejoicing.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
diff --git a/tests/btrfs/309 b/tests/btrfs/309
new file mode 100755
index 000..acb2d6d
--- /dev/null
+++ b
On 8/4/13 6:24 PM, Wang Shilong wrote:
Hello Eric,
I have sent a patch to fix up this regression:
https://patchwork.kernel.org/patch/2828820/
Would you please try and see if this can solve problems.
Ah, thanks. I missed that, I'll try it.
Chris, maybe one to pick up sooner than later!
Port kernel commit 1bec1aed to userspace.
use __le64 instead of u64 in on-disk structure definition.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
diff --git a/ctree.h b/ctree.h
index 4f602d4..257396d 100644
--- a/ctree.h
+++ b/ctree.h
@@ -593,7 +593,7 @@ struct btrfs_shared_data_ref
actually look at compat_flags.
This
will mess any attempt to use compat flags up. The fix is obvious. Thanks,
Signed-off-by: Josef Bacik jo...@redhat.com
Signed-off-by: Chris Mason chris.ma...@oracle.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
diff --git a/ctree.h b
If an array is 5 chars in size:
char answer[5];
and we write the 6th char (counting from 0)...
answer[5] = '\0';
we get problems:
cmds-chunk.c: In function 'ask_user.clone.0':
cmds-chunk.c:1343: warning: array subscript is above array bounds
Fix it...
Signed-off-by: Eric
On 8/5/13 10:57 PM, Zach Brown wrote:
On Mon, Aug 05, 2013 at 09:52:57PM -0500, Eric Sandeen wrote:
If an array is 5 chars in size:
char answer[5];
and we write the 6th char (counting from 0)...
answer[5] = '\0';
*high fives*
-answer[5] = '\0';
+answer[4] = '\0
On 8/6/13 1:27 PM, Filipe David Borba Manana wrote:
This change allows for most mount options to be persisted in
the filesystem, and be applied when the filesystem is mounted.
If the same options are specified at mount time, the persisted
values for those options are ignored.
The only
On 8/6/13 3:45 PM, Filipe David Manana wrote:
On Tue, Aug 6, 2013 at 9:37 PM, Eric Sandeen sand...@redhat.com wrote:
On 8/6/13 1:27 PM, Filipe David Borba Manana wrote:
This change allows for most mount options to be persisted in
the filesystem, and be applied when the filesystem is mounted
2 patches, one for shared kernel files, one for pure userspace.
In kernelspace, lots of unused functions purged. Some functions
which could be static are left alone if they aren't marked static
in kernelspace.
userspace only has a couple removals, mostly just marking static
removing prototypes
In files copied from the kernel, mark many functions as static,
and remove any resulting dead code.
Some functions are left unmarked if they aren't static in the
kernel tree.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
ctree.c|2
ctree.h| 43
Mark many functions as static, and remove any resulting dead code.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
btrfs-convert.c |8
btrfs-find-root.c |2 +-
btrfs-list.c| 10 +-
btrfs-list.h|3 ---
btrfs-map-logical.c |4
On 8/6/13 8:20 PM, Duncan wrote:
Eric Sandeen posted on Tue, 06 Aug 2013 15:37:30 -0500 as excerpted:
On 8/6/13 1:27 PM, Filipe David Borba Manana wrote:
This change allows for most mount options to be persisted in the
filesystem, and be applied when the filesystem is mounted.
If the same
On 8/6/13 1:27 PM, Filipe David Borba Manana wrote:
This change allows for most mount options to be persisted in
the filesystem, and be applied when the filesystem is mounted.
If the same options are specified at mount time, the persisted
values for those options are ignored.
I thought the
On 8/6/13 8:05 PM, Eric Sandeen wrote:
Mark many functions as static, and remove any resulting dead code.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
...
Actually, what the heck was this (note, this patch was against kdave's
integration tree):
diff --git a/send-utils.c b/send
On 8/7/13 2:54 AM, Stefan Behrens wrote:
On Tue, 06 Aug 2013 22:49:32 -0500, Eric Sandeen wrote:
On 8/6/13 8:05 PM, Eric Sandeen wrote:
Mark many functions as static, and remove any resulting dead code.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
...
Actually, what the heck
On 8/7/13 4:43 PM, Sergei Trofimovich wrote:
...
Meet uselex.rb: one-file script to parse 'nm' output:
https://github.com/trofi/uselex/blob/master/uselex.rb
Nice to meet you! I think I've met your close relative,
ftp://ftp.samba.org/pub/unpacked/junkcode/findstatic.pl :)
On 8/8/13 3:17 AM, Jan Schmidt wrote:
These two patches add the announced tests for btrfs send / receive. As
requested, the fssum tool is now included.
One drawback is that I'm unable to edit configure.ac or whatever needs
to be modified in an autotools preferred way. Any hints appreciated,
On 8/8/13 3:17 AM, Jan Schmidt wrote:
fssum is a tool to build a recursive checksum for a file system. The home
repository of fssum is
git://git.kernel.org/pub/scm/linux/kernel/git/arne/far-progs.git
It is added as an optional target, because it depends on glibc = 2.15 for
SEEK_HOLE /
On 8/8/13 3:17 AM, Jan Schmidt wrote:
Basic send / receive functionality test for btrfs. Requires current
version of fsstress built (-x support). Relies on fssum tool but can
skip the test if it failed to build.
Signed-off-by: Jan Schmidt list@jan-o-sch.net
Reviewed-by: Josef Bacik
Mark many functions as static, and remove any resulting dead code.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
V2: Keep the special subvol_uuid_search_add()-which-only-frees-pointers
because I'm picking my battles :)
btrfs-convert.c |8
btrfs-find-root.c |2
On 8/9/13 5:48 PM, David Sterba wrote:
On Fri, Aug 09, 2013 at 03:20:47PM -0500, Eric Sandeen wrote:
Mark many functions as static, and remove any resulting dead code.
Thanks.
-struct btrfs_root *link_subvol(struct btrfs_root *root, const char *base,
- u64
On 8/9/13 9:04 PM, anand jain wrote:
btrfs fi show
Label: none uuid: e7aae9f0-1aa8-41f5-8fb6-d4d8f80cdb2c
Total devices 1 FS bytes used 28.00KiB
devid2 size 2.00GiB used 0.00 path /dev/sdc -- WRONG
devid1 size 2.00GiB used 20.00MiB path /dev/sdb
Ok,
On Aug 11, 2013, at 8:15 PM, Dave Chinner da...@fromorbit.com wrote:
On Thu, Aug 08, 2013 at 12:40:55PM -0500, Eric Sandeen wrote:
On 8/8/13 3:17 AM, Jan Schmidt wrote:
SUBDIRS =
LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL)
+OPT_LDLIBS = -lssl -lcrypto
Hm, new deps. I guess it's
numbers are based off of a different counter. Thanks,
The problem itself isn't totally clear to me, but the test itself looks
fine. ;)
Signed-off-by: Josef Bacik jba...@fusionio.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
tests/btrfs/002 | 85
On 8/12/13 2:40 PM, Josef Bacik wrote:
We were allowing users to delete their default subvolume, which is
problematic.
This test is a regression test to make sure we don't let that happen in the
future. Thanks,
Signed-off-by: Josef Bacik jba...@fusionio.com
---
tests/btrfs/003 |
On 8/13/13 10:28 AM, Josef Bacik wrote:
On Sun, Aug 11, 2013 at 09:54:41PM -0500, Eric Sandeen wrote:
On Aug 11, 2013, at 8:15 PM, Dave Chinner da...@fromorbit.com wrote:
On Thu, Aug 08, 2013 at 12:40:55PM -0500, Eric Sandeen wrote:
On 8/8/13 3:17 AM, Jan Schmidt wrote:
SUBDIRS =
LLDLIBS
On 8/13/13 12:24 PM, Jan Schmidt wrote:
These two patches add the announced tests for btrfs send / receive. As
requested, the fssum tool is now included.
Thanks for the updates.
Both:
Reviewed-by: Eric Sandeen sand...@redhat.com
--
v1-v2:
- included fssum
- test number is now 316
the comments made by Eric Sandeen.
tests/btrfs/003 | 66
+++
tests/btrfs/003.out |2 +
tests/btrfs/group |1 +
3 files changed, 69 insertions(+), 0 deletions(-)
create mode 100755 tests/btrfs/003
create mode 100644 tests/btrfs/003
and abstract out the subvolid logic as per Eric's
suggestions
V1-V2: address the comments made by Eric Sandeen.
Thank you, sir. :)
Reviewed-by: Eric Sandeen sand...@redhat.com
common/rc |8 ++
tests/btrfs/003 | 63
On 8/16/13 9:51 AM, Stefan Behrens wrote:
This test failed for me with output from 'btrfs balance':
QA output created by 003
+Done, had to relocate 4 out of 4 chunks
+Done, had to relocate 5 out of 5 chunks
Silence is golden
Signed-off-by: Stefan Behrens
...@giantdisaster.de
---
V1 - V2:
Redirect errors to $seqres.full as proposed by Eric.
Thanks!
Reviewed-by: Eric Sandeen sand...@redhat.com
tests/btrfs/003 | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/tests/btrfs/003 b/tests/btrfs/003
index
-by: Eric Sandeen sand...@redhat.com
# Convert string read from stdin like 128K to bytes and print it to stdout
diff --git a/common/filter.btrfs b/common/filter.btrfs
index e9a2bc2..1584596 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -33,6 +33,7
On 8/16/13 12:44 PM, Stefan Behrens wrote:
Signed-off-by: Stefan Behrens sbehr...@giantdisaster.de
Reviewed-by: Eric Sandeen sand...@redhat.com
---
tests/btrfs/009 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/btrfs/009 b/tests/btrfs/009
index d46744c..08aa508 100755
On 8/17/13 10:25 PM, Tom Gundersen wrote:
On Sat, Aug 17, 2013 at 7:59 PM, Chris Mason chris.ma...@fusionio.com wrote:
The problem with the progs release is I keep finding more things I want
to add. My local git tree has about a dozen commits that I feel are
important enough for v1.0. I just
On 8/20/13 4:14 AM, Stefan Behrens wrote:
On Mon, 19 Aug 2013 16:53:17 -0400, Josef Bacik wrote:
There was a problem with send trying to overwrite a file that wasn't actually
the same. This is a test to check this particular case where receive fails
when
it should succeed properly. I
On 8/20/13 6:20 AM, Geert Uytterhoeven wrote:
u64 is unsigned long long on all architectures now, so there's no need to
cast it when formatting it using the ll length modifier.
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
fs/btrfs/backref.c | 24 ++--
On 8/21/13 11:03 AM, Josef Bacik wrote:
I've been periodically failing btrfs/003 because my box sometimes takes a
little
longer to unregister the device when we remove it and so the output from btrfs
dev show doesn't match what we are wanting since it still sees the device. To
fix this just
On 8/26/13 12:38 AM, chandan wrote:
On Sunday, August 25, 2013 11:54:30 AM Eric Sandeen wrote:
Can you explain why this is necessary?
What failures do you see, on what filesystems?
generic/255 currently fails on Btrfs on a ppc64 machine with 64k page size and
hence 64k block size
things which are logic assertions vs. things which are just punts
in more common error-handling paths.
Acked-by: Eric Sandeen sand...@redhat.com
Thanks,
-Eric
---
fs/btrfs/Kconfig |9 +
fs/btrfs/ctree.h | 16
2 files changed, 25 insertions(+), 0 deletions
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/27/13 4:07 PM, Jeff Mahoney wrote:
On 8/27/13 4:56 PM, Josef Bacik wrote:
On Tue, Aug 27, 2013 at 03:28:24PM -0400, Jeff Mahoney wrote:
On 8/26/13 4:56 PM, Josef Bacik wrote:
One of the complaints we get a lot is how many BUG_ON()'s we have.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 8/27/13 4:25 PM, Jeff Mahoney wrote:
On 8/27/13 5:21 PM, Eric Sandeen wrote:
On 8/27/13 4:07 PM, Jeff Mahoney wrote:
On 8/27/13 4:56 PM, Josef Bacik wrote:
On Tue, Aug 27, 2013 at 03:28:24PM -0400, Jeff Mahoney wrote:
On 8/26/13 4:56 PM, Josef
On 8/28/13 12:01 AM, Hidetoshi Seto wrote:
(2013/08/26 23:23), Eric Sandeen wrote:
Thanks for looking into this - how small of a device did you test?
I tried a 2MB device w/ these 2 patches and still got:
[btrfs-progs]# truncate --size=2m testfile
[btrfs-progs]# ./mkfs.btrfs testfile
On 8/29/13 8:21 AM, David Sterba wrote:
On Tue, Aug 13, 2013 at 02:38:05PM -0500, Eric Sandeen wrote:
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+_require_scratch
+
+_scratch_mkfs /dev/null 21
+_scratch_mount
On 8/29/13 3:19 PM, Chris Murphy wrote:
On Aug 29, 2013, at 1:53 PM, Hugo Mills h...@carfax.org.uk wrote:
On Thu, Aug 29, 2013 at 01:44:54PM -0600, Chris Murphy wrote:
Certainly, if known for sure it won't be more than 30 seconds?
Mmm... it'll depend on the setting of the commit
.
-Eric
Thanks,
Wang
From:
Just whitespace fixes, and magical return value removal.
Signed-off-by: Eric Sandeen sand...@redhat.com
---
cmds-subvolume.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/cmds-subvolume.c b/cmds-subvolume.c
index 01b982c
On 9/2/13 9:45 AM, David Sterba wrote:
On Tue, Jun 11, 2013 at 07:38:03PM -0500, Eric Sandeen wrote:
Move btrfs cmd files to cmd/ subdir
Are you ok with naming the subdirectory 'cmds'?
david
yep! That's the _last_ bike shed I want to paint. ;)
I had picked cmd because
On 9/2/13 9:43 AM, David Sterba wrote:
On Tue, Jun 11, 2013 at 06:15:18PM -0500, Eric Sandeen wrote:
Move test tools to tests/
rename btrfs-corrupt-block.c = tests/btrfs-corrupt-block.c (100%)
IMO this is not a test by itself, so it should stay in the toplevel dir.
Hum, well, it has
MOn Sep 3, 2013, at 8:22 PM, Wang Shilong wangsl.f...@cn.fujitsu.com wrote:
On 09/03/2013 11:50 PM, Eric Sandeen wrote:
On 9/3/13 8:13 AM, Wang Shilong wrote:
Hello Eric,
Recently, i notice btrfs-progs's magic return value. For example, EACCESS
return 12.
Magic return value is confusing
On 9/5/13 9:43 AM, Тимофей Титовец wrote:
Hello guys, i try to convert ext4 volume, but btrfs-convert show me error:
No valid Btrfs found on file
unable to open ctree
conversion aborted.
Ubuntu 13.04
Kernel: 3.11
btrfs-progs git version 0.20-git20130822~194aa4a13
way to reproduce error:
On 9/9/13 12:13 PM, Josef Bacik wrote:
On Mon, Sep 09, 2013 at 06:32:04PM +0200, David Sterba wrote:
On Fri, Sep 06, 2013 at 02:50:56PM -0400, Josef Bacik wrote:
We need to start adding some sanity tests to btrfs-progs to make sure we
aren't
breaking things with our patches. The most
On 9/17/13 8:11 PM, rongqing...@windriver.com wrote:
From: Roy Li rongqing...@windriver.com
The dependencies of all: version.h or other similar ones can not
fix the parallel build failure, only reduce the times; In fact,
many *.o files require version.h file.
#grep '#include
Change the suffix rule to ensure that version.h is
built before we try to create any .o file.
Reported-by: Roy Li rongqing...@windriver.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
I dunno, does this work? My gnu make is rusty.
diff --git a/Makefile b/Makefile
index 3d715d8..d25054f
On 9/17/13 8:56 PM, Eric Sandeen wrote:
Change the suffix rule to ensure that version.h is
built before we try to create any .o file.
Reported-by: Roy Li rongqing...@windriver.com
Signed-off-by: Eric Sandeen sand...@redhat.com
---
I dunno, does this work? My gnu make is rusty.
I'm
and introduces a filter for the older style output.
[dchinner: modified to use a global filter in check rather than
per-test filters]
Signed-off-by: Tomas Racek tra...@redhat.com
Signed-off-by: Dave Chinner dchin...@redhat.com
Reviewed-by: Eric Sandeen sand...@redhat.com
---
(Resending as proper top
On 9/19/13 11:54 AM, Ilya Dryomov wrote:
...
diff --git a/check b/check
index 4085eae..ba7fd21 100755
--- a/check
+++ b/check
@@ -478,6 +478,10 @@ do
echo - no qualified output
err=true
else
+
+ # coreutils 2.16+ changed quote
() which does take a
struct extent_buffer as the first arg.
But on technical terms anyway,
Reviewed-by: Eric Sandeen sand...@redhat.com
Thanks,
-Eric
---
btrfs-calc-size.c |2 +-
btrfs-image.c |6 +++---
cmds-restore.c|2 +-
ctree.c | 30
On 9/20/13 8:27 AM, Ross Kirk wrote:
Remove unused parameter, 'eb'. Unused since introduction in
5f39d397dfbe140a14edecd4e73c34ce23c4f9ee
Signed-off-by: Ross Kirk ross.k...@gmail.com
A few points; was this against latest upstream?
Upstream, fba6aa75654394fccf2530041e9451414c28084f removed
get this from blkid, but maybe not.
In the meantime it does do the right thing, so:
Reviewed-by: Eric Sandeen sand...@redhat.com
Signed-off-by: David Sterba dste...@suse.cz
---
utils.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/utils.c b/utils.c
On 9/23/13 10:44 AM, David Sterba wrote:
On Mon, Sep 23, 2013 at 10:08:08AM -0500, Eric Sandeen wrote:
On 9/20/13 11:42 AM, David Sterba wrote:
The message about trim was printed unconditionally, we should check if
trim is supported at all.
Good idea, but I wonder if there's any risk
On 9/24/13 8:02 AM, Ross Kirk wrote:
Internally, btrfs_header_fsid() calculates an unsigned long, but casts
it to a pointer, while all callers cast it to unsigned long again.
Thanks for doing this; my only nitpick is to keep
the lines under 80 cols.
Committed to btrfs as
On 9/24/13 4:07 AM, Ross Kirk wrote:
Remove unused parameter, 'eb'. Unused since introduction in
5f39d397dfbe140a14edecd4e73c34ce23c4f9ee
Updated to be rebased against current upstream.
This doesn't apply...
- write_extent_buffer(cow, root-fs_info-fsid, btrfs_(cow),
+
-by: Eric Sandeen sand...@redhat.com
Signed-off-by: Ross Kirk ross.k...@gmail.com
---
fs/btrfs/ctree.c | 10 +-
fs/btrfs/ctree.h |2 +-
fs/btrfs/disk-io.c |6 +++---
fs/btrfs/ioctl.c |2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs
On 9/24/13 6:39 PM, vgrvelu wrote:
hi
I created btrfs file system on one of sda partition. when I mount
with mount -t /dev/sda17 /btrfs,
# mount -t /dev/sda17 /btrfs?
That doesn't work. Maybe you meant :
# mount -t btrfs /dev/sda17 /btrfs ?
it is failing with wrong fs type bad
On 9/25/13 8:00 AM, vgrvelu wrote:
Hi
after doing mofprobe btrfs I could see btrfs entry in proc file
system. But still mount command is failing. It looks like super block
is corrupted
Seems doubtful if you *just* ran mkfs.btrfs.
Can you paste the exact commands you issued, from mkfs to
1 - 100 of 574 matches
Mail list logo
