Re: [RFC][PATCH 03/10] cifs: register CIFS for caching

2010-06-25 Thread Suresh Jayaraman
On 06/23/2010 10:21 PM, David Howells wrote: Suresh Jayaraman sjayara...@suse.de wrote: +rc = cifs_fscache_register(); +if (rc) +goto out; + rc = cifs_init_inodecache(); if (rc) goto out_clean_proc; @@ -949,8 +954,10 @@ init_cifs(void)

Re: [RFC][PATCH 05/10] cifs: define superblock-level cache index objects and register them

2010-06-25 Thread Suresh Jayaraman
On 06/23/2010 10:28 PM, David Howells wrote: Suresh Jayaraman sjayara...@suse.de wrote: Define superblock-level cache index objects (managed by cifsTconInfo structs). Each superblock object is created in a server-level index object and in itself an index into which inode-level objects are

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread David Howells
Suresh Jayaraman sjayara...@suse.de wrote: I think the creation time is currently being ignored as we won't be able to accomodate in POSIX stat struct. The FS-Cache interface doesn't use the POSIX stat struct, but it could be really useful to save it and use it for cache coherency inside the

Re: [RFC][PATCH 05/10] cifs: define superblock-level cache index objects and register them

2010-06-25 Thread David Howells
Suresh Jayaraman sjayara...@suse.de wrote: Also, considering the UNC name of the resource (//server/share) may not be a good idea too as the cache will not be used when for e.g. IPaddress is used to mount. You could convert the UNC name to an IP address, and just use that as your key.

Re: Build infrastructure for storing NTLM creds in kernel keyring

2010-06-25 Thread Jeff Layton
On Fri, 25 Jun 2010 22:36:04 +0400 Igor Druzhinin jaxbr...@gmail.com wrote: I think the right thing to do is to not worry about upcalls for this at first. Instead I think you'll want to create something like a ntlminit program that takes user, password and host or domainname and puts that

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread Jeff Layton
On Fri, 25 Jun 2010 22:46:38 +0100 David Howells dhowe...@redhat.com wrote: Jeff Layton jlay...@samba.org wrote: Looks like it mostly uses the ctime. IMO, the mtime would be a better choice since it changes less frequently, but I don't guess that it matters very much. I'd've thought

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread David Howells
Jeff Layton jlay...@samba.org wrote: IIUC, updating mtime for a write is also an attribute change, and that affects ctime. According to the stat(2) manpage: You're right. Okay, ctime is the more frequently changed. Note that Ext4 appears to have a file creation time field in its inode

Re: [RFC][PATCH 06/10] cifs: define inode-level cache object and register them

2010-06-25 Thread Steve French
On Fri, Jun 25, 2010 at 5:26 PM, Jeff Layton jlay...@samba.org wrote: On Fri, 25 Jun 2010 22:46:38 +0100 David Howells dhowe...@redhat.com wrote: Jeff Layton jlay...@samba.org wrote: Looks like it mostly uses the ctime. IMO, the mtime would be a better choice since it changes less